Bug 1990882 - Mic/Mute light on Thinkpad t520 is always on after boot since update to 5.13.6-200.fc34.x86_64 kernel
Summary: Mic/Mute light on Thinkpad t520 is always on after boot since update to 5.13....
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: alsa-lib
Version: 34
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Jaroslav Kysela
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-06 14:09 UTC by halginsberg1963
Modified: 2022-06-08 06:24 UTC (History)
24 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-06-08 06:24:12 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description halginsberg1963 2021-08-06 14:09:45 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Shutdown laptop - Lenovo Thinkpad T520
2. Restart Laptop 
3.

Actual results:
Mic/Mute light comes on during reboot - before logging in - and cannot be turned off by toggling switch. Toggling switch does disable and enable microphone.


Expected results: Toggling switch will turn off or on mic/mute light.


Additional info:

Comment 1 Angelo Geulin 2021-08-08 11:16:43 UTC
I am also hitting this issue on the X220. There have been reports of the issue on T420 as well. It looks like this affects all machines using the same keyboard Mic Mute button.

Comment 2 jorgeluiscarrillo 2021-08-09 05:36:47 UTC
Can confirm this issue on my X220 since upgrading to kernel 5.13. Downgrading to kernel 5.12.5 fixes it for me.

Comment 3 Angelo Geulin 2021-08-11 13:30:24 UTC
This issue was introduced in this merge: https://github.com/torvalds/linux/commit/b71428d7ab333a157216a1d73c8c82a178efada9

I'm not too proficient with git, but it looks like there's a bunch of commits inside there. I'll have to test more to see which specific commit introduced it.

Comment 4 Hans de Goede 2021-08-12 08:57:05 UTC
Great job on narrowing this down to that merge, if you can further narrow it down to a single commit then that will be of great help in getting this fixed. You could try git-bisect to further narrow this down.

Comment 5 jorgeluiscarrillo 2021-08-13 02:27:30 UTC
I'm not too experienced but this commit might be related: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e65bf99718b538c2f34e9444dfe1087789b58f94

Comment 6 Hans de Goede 2021-08-13 06:40:51 UTC
<changing component to alsa-lib since we have now narrowed this down to the sound part of the kernel.

> I'm not too experienced but this commit might be related: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e65bf99718b538c2f34e9444dfe1087789b58f94

Yes that looks like it might be the culprit, can you try building a recent kernel with that commit reverted ? And then test that kernel and see if that helps?

Comment 7 Angelo Geulin 2021-08-13 20:03:08 UTC
I can confirm commit e65bf99718b538c2f34e9444dfe1087789b58f94 causes the issue described here. Reverting the said commit fixes the issue.

I'm testing with a recent kernel built from Linus's tree (commit f8e6dfc64f6135d1b6c5215c14cd30b9b60a0008, if that matters).

Comment 8 Jaroslav Kysela 2021-08-19 16:22:39 UTC
It's a really old bug in the HDA driver which is visible with the new LED notification layer.

The fix patch: https://lore.kernel.org/alsa-devel/20210811161441.1325250-1-perex@perex.cz/

Comment 9 Angelo Geulin 2021-08-19 23:52:42 UTC
Thanks! Applying that patch solves the issue.

Comment 10 halginsberg1963 2021-08-20 23:59:51 UTC
Can you provide step-by-step instructions or a link that clearly sets forth how to apply the patch?

Comment 11 Angelo Geulin 2021-08-21 06:30:06 UTC
Click the link Jaroslav Kysela sent and save the diff section to a text (*.patch) file.

Download and extract the latest stable kernel from here: https://www.kernel.org/

Assuming you saved the previous diff section into a file called fix-thinkpad-keyboard-micmute-led.patch, cd into the directory and apply the patch like so:

    patch -p1 < fix-thinkpad-keyboard-micmute-led.patch

From then, you can configure and build the kernel to whatever fits your hardware. I believe, the Gentoo and Arch Wiki has good information on this, if you haven't tried building your own kernel before:

- https://wiki.gentoo.org/wiki/Handbook:AMD64/Full/Installation#Kernel_configuration_and_compilation
- https://wiki.archlinux.org/title/Kernel/Traditional_compilation
- https://fedoraproject.org/wiki/Building_a_custom_kernel

Comment 12 Angelo Geulin 2021-08-21 06:38:57 UTC
I should also mention that patch is already in Linus's tree, as you can see from this mirror: https://github.com/torvalds/linux/commit/a2befe9380dd04ee76c871568deca00eedf89134

If you'd like, you can just wait for that patch to end up in the stable kernel. Or, you can build the kernel from his git repository.

Comment 13 halginsberg1963 2021-08-21 13:14:03 UTC
Thanks so much! This is way above my paygrade. I'll stick to reporting bugs.

Comment 14 Ben Cotton 2022-05-12 16:52:31 UTC
This message is a reminder that Fedora Linux 34 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 34 on 2022-06-07.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '34'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 34 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 15 Ben Cotton 2022-06-08 06:24:12 UTC
Fedora Linux 34 entered end-of-life (EOL) status on 2022-06-07.

Fedora Linux 34 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.