Bug 1991573 - Enable typescript strictNullCheck on network-policies files
Summary: Enable typescript strictNullCheck on network-policies files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.9
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.10.0
Assignee: Joel Takvorian
QA Contact: Mehul Modi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-09 13:15 UTC by Joel Takvorian
Modified: 2022-03-12 04:37 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-12 04:37:24 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 9656 0 None None None 2021-08-09 13:16:39 UTC
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-12 04:37:46 UTC

Description Joel Takvorian 2021-08-09 13:15:18 UTC
Description of problem:

BZ-backing JIRA https://issues.redhat.com/browse/NETOBSERV-29
For increased type-safety, we can enable strictNullCheck selectively by overriding the global tsconfig file per directory.

Note, there is no special thing to test for QE regarding this pull-request, (apart from usual non-regression in network policy creation through the form). It's purely a technical / code issue.


How reproducible:

n/a

Comment 1 Joel Takvorian 2021-08-09 14:19:05 UTC
Closing: PR on hold until 4.10

Comment 4 Mehul Modi 2021-09-15 21:50:45 UTC
@jtakvori - as we discussed this isn't making it in 4.9, do you want to mark this invalid for 4.9? Or change the version to 4.10 and mark it duplicate of https://issues.redhat.com/browse/NETOBSERV-29?

Comment 5 Mehul Modi 2021-09-15 22:03:40 UTC
@jtakvori never mind, I see the target release is changed from 4.9 to 4.10 in here, so it's a duplicate of  https://issues.redhat.com/browse/NETOBSERV-29. FWIW NETOBSERV-29 was marked with QEStatus:Not Required, I've verified this based on other tests done in https://issues.redhat.com/browse/NETOBSERV-6. Thanks! 

BZ won't allow to have duplicate issue link to JIRA, so I'll mark it as won't fix.

Comment 6 Mehul Modi 2021-09-16 19:01:28 UTC
Verified as part of testing https://issues.redhat.com/browse/NETOBSERV-6 and https://issues.redhat.com/browse/NETOBSERV-29

Comment 10 errata-xmlrpc 2022-03-12 04:37:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056


Note You need to log in before you can comment on or make changes to this bug.