Bug 1991796
| Summary: | Nginx is not built with --with-compat, breaking the ability to build and use external nginx modules | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Neal Gompa <ngompa13> | ||||
| Component: | nginx | Assignee: | Luboš Uhliarik <luhliari> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Branislav Náter <bnater> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 8.4 | CC: | bnater, bstinson, carl, davide, daxelrod, fedora, jwboyer, psklenar | ||||
| Target Milestone: | beta | Keywords: | Triaged | ||||
| Target Release: | --- | Flags: | pm-rhel:
mirror+
|
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | nginx-1.20-8050020210820165208.b4937e53 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2021-11-09 18:13:59 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Fixing to set to the correct RHEL version (8.4). I have also provided a COPR which shows a build of nginx 1.18 with the nginx-mod-vts package built against it that works together because of this: https://copr.fedorainfracloud.org/coprs/ngompa/nginx-1.18-with-mods-el8/ I've also filed this as a support case: https://access.redhat.com/support/cases/#/case/03007218 I see that this bug's state has changed to ON_QA; however, I'm not sure what is happening. Thanks for taking a look and working on this bug! Could you share the release plans and which nginx streams will have this fixed? I ask about the nginx streams because it seems like nginx:1.20 is listed here even though the bug is for nginx:1.18. I also created bug 1991787 for CentOS Stream 8 / RHEL 8.5, which includes a patch for fully solving this problem with nginx 1.20 stream like I did in Fedora. I'm also willing and able to test and validate things as desired/needed, as I have sample packages (which are also now in Fedora) and the ability to test it. (In reply to Neal Gompa from comment #12) > I see that this bug's state has changed to ON_QA; however, I'm not sure what > is happening. Thanks for taking a look and working on this bug! Could you > share the release plans and which nginx streams will have this fixed? I ask > about the nginx streams because it seems like nginx:1.20 is listed here even > though the bug is for nginx:1.18. > > I also created bug 1991787 for CentOS Stream 8 / RHEL 8.5, which includes a > patch for fully solving this problem with nginx 1.20 stream like I did in > Fedora. I'm also willing and able to test and validate things as > desired/needed, as I have sample packages (which are also now in Fedora) and > the ability to test it. Hi Gompa, for RHEL-8.5, I think it is too late to do the changes which were merged in Fedora, we can just rebuild nginx 1.20 (new stream) with --with-compat config option. In next release, we can try to look at adopting changes, which has been made to nginx package in Fedora. I rebuilt only nginx 1.20 with "--with-compat" config option, but in case you need also older releases with this config options, please open a customer ticket in customer portal and I can take a look at it. (In reply to Luboš Uhliarik from comment #13) > (In reply to Neal Gompa from comment #12) > > I see that this bug's state has changed to ON_QA; however, I'm not sure what > > is happening. Thanks for taking a look and working on this bug! Could you > > share the release plans and which nginx streams will have this fixed? I ask > > about the nginx streams because it seems like nginx:1.20 is listed here even > > though the bug is for nginx:1.18. > > > > I also created bug 1991787 for CentOS Stream 8 / RHEL 8.5, which includes a > > patch for fully solving this problem with nginx 1.20 stream like I did in > > Fedora. I'm also willing and able to test and validate things as > > desired/needed, as I have sample packages (which are also now in Fedora) and > > the ability to test it. > > Hi Gompa, > > for RHEL-8.5, I think it is too late to do the changes which were merged in > Fedora, we can just rebuild nginx 1.20 (new stream) with --with-compat > config option. In next release, we can try to look at adopting changes, > which has been made to nginx package in Fedora. > Oh, that's unfortunate. I'd hoped it'd be able to be added since the nginx 1.20 stream hasn't even been built yet for CentOS Stream 8 and it's completely new for RHEL 8.5. My assumption was that for totally new things, it'd be easier to get that stuff in right out of the gate, since there are less expectations around it. > I rebuilt only nginx 1.20 with "--with-compat" config option, but in case > you need also older releases with this config options, please open a > customer ticket in customer portal and I can take a look at it. In the support case (which already exists and I mentioned in comment 3), I mention that I do need it for nginx 1.18, which is what we're using right now. That's also why this bug is aimed at nginx 1.18. So I would certainly appreciate having this done for nginx 1.18 too. (In reply to Neal Gompa from comment #14) > (In reply to Luboš Uhliarik from comment #13) > > (In reply to Neal Gompa from comment #12) > > > I see that this bug's state has changed to ON_QA; however, I'm not sure what > > > is happening. Thanks for taking a look and working on this bug! Could you > > > share the release plans and which nginx streams will have this fixed? I ask > > > about the nginx streams because it seems like nginx:1.20 is listed here even > > > though the bug is for nginx:1.18. > > > > > > I also created bug 1991787 for CentOS Stream 8 / RHEL 8.5, which includes a > > > patch for fully solving this problem with nginx 1.20 stream like I did in > > > Fedora. I'm also willing and able to test and validate things as > > > desired/needed, as I have sample packages (which are also now in Fedora) and > > > the ability to test it. > > > > Hi Gompa, > > > > for RHEL-8.5, I think it is too late to do the changes which were merged in > > Fedora, we can just rebuild nginx 1.20 (new stream) with --with-compat > > config option. In next release, we can try to look at adopting changes, > > which has been made to nginx package in Fedora. > > > > Oh, that's unfortunate. I'd hoped it'd be able to be added since the nginx > 1.20 stream hasn't even been built yet for CentOS Stream 8 and it's > completely new for RHEL 8.5. My assumption was that for totally new things, > it'd be easier to get that stuff in right out of the gate, since there are > less expectations around it. > > > I rebuilt only nginx 1.20 with "--with-compat" config option, but in case > > you need also older releases with this config options, please open a > > customer ticket in customer portal and I can take a look at it. > > In the support case (which already exists and I mentioned in comment 3), I > mention that I do need it for nginx 1.18, which is what we're using right > now. That's also why this bug is aimed at nginx 1.18. So I would certainly > appreciate having this done for nginx 1.18 too. We can look at this for a future update for the 1.18 stream (it is already late to update nginx 1.18 in RHEL-8.5). In case this we have capacity to fix this, just please bear in mind, that nginx 1.18 stream has limited lifetime support, so I think it would be worth to think about moving to 1.20. I will also try to get proposed changes (adding -mod-devel subpackage) adopted in next nginx update. Thanks for creating support cases and I will let you know as soon as we will start with RHEL-8.6 planning. (In reply to Luboš Uhliarik from comment #15) > (In reply to Neal Gompa from comment #14) > > (In reply to Luboš Uhliarik from comment #13) > > > (In reply to Neal Gompa from comment #12) > > > > I see that this bug's state has changed to ON_QA; however, I'm not sure what > > > > is happening. Thanks for taking a look and working on this bug! Could you > > > > share the release plans and which nginx streams will have this fixed? I ask > > > > about the nginx streams because it seems like nginx:1.20 is listed here even > > > > though the bug is for nginx:1.18. > > > > > > > > I also created bug 1991787 for CentOS Stream 8 / RHEL 8.5, which includes a > > > > patch for fully solving this problem with nginx 1.20 stream like I did in > > > > Fedora. I'm also willing and able to test and validate things as > > > > desired/needed, as I have sample packages (which are also now in Fedora) and > > > > the ability to test it. > > > > > > Hi Gompa, > > > > > > for RHEL-8.5, I think it is too late to do the changes which were merged in > > > Fedora, we can just rebuild nginx 1.20 (new stream) with --with-compat > > > config option. In next release, we can try to look at adopting changes, > > > which has been made to nginx package in Fedora. > > > > > > > Oh, that's unfortunate. I'd hoped it'd be able to be added since the nginx > > 1.20 stream hasn't even been built yet for CentOS Stream 8 and it's > > completely new for RHEL 8.5. My assumption was that for totally new things, > > it'd be easier to get that stuff in right out of the gate, since there are > > less expectations around it. > > > > > I rebuilt only nginx 1.20 with "--with-compat" config option, but in case > > > you need also older releases with this config options, please open a > > > customer ticket in customer portal and I can take a look at it. > > > > In the support case (which already exists and I mentioned in comment 3), I > > mention that I do need it for nginx 1.18, which is what we're using right > > now. That's also why this bug is aimed at nginx 1.18. So I would certainly > > appreciate having this done for nginx 1.18 too. > > We can look at this for a future update for the 1.18 stream (it is already > late > to update nginx 1.18 in RHEL-8.5). In case this we have capacity to fix > this, > just please bear in mind, that nginx 1.18 stream has limited lifetime > support, so > I think it would be worth to think about moving to 1.20. > > I will also try to get proposed changes (adding -mod-devel subpackage) > adopted > in next nginx update. > I'm fine with moving to 1.20 since we're not getting the flag built for nginx 1.18 as a z-stream update. I can rebase my patch in bug 1991787 on top of your changes once they are pushed to https://git.centos.org/rpms/nginx/commits/c8s-stream-1.20 if that would help getting the -mod-devel package to land sooner. > Thanks for creating support cases and I will let you know as soon as we will > start > with RHEL-8.6 planning. Thanks! It would also be great to get it to land in RHEL 9.0 too. I have bug 1991720 for that, and there's an MR submitted to CentOS Stream for it: https://gitlab.com/redhat/centos-stream/rpms/nginx/-/merge_requests/6 Hey Neal, I'm OK to rebase the Patch by myself, but as I said it is too late now to make these changes to RHEL-8.5. I will try to get them to next RHEL-8 release and I will also take a look at RHEL-9.0. Is it useful for you to have nginx 1.20 built with "--with-compat", but without having "-mod-devel" subpackage for now? (In reply to Luboš Uhliarik from comment #17) > Hey Neal, > > I'm OK to rebase the Patch by myself, but as I said it is too late now to > make these changes to RHEL-8.5. I will try to get them to next RHEL-8 > release and I will also take a look at RHEL-9.0. > > Is it useful for you to have nginx 1.20 built with "--with-compat", but > without having "-mod-devel" subpackage for now? Yes, that's still quite helpful. I can hack around things in the short-term. (In reply to Neal Gompa from comment #18) > (In reply to Luboš Uhliarik from comment #17) > > Hey Neal, > > > > I'm OK to rebase the Patch by myself, but as I said it is too late now to > > make these changes to RHEL-8.5. I will try to get them to next RHEL-8 > > release and I will also take a look at RHEL-9.0. > > > > Is it useful for you to have nginx 1.20 built with "--with-compat", but > > without having "-mod-devel" subpackage for now? > > Yes, that's still quite helpful. I can hack around things in the short-term. To make it clearer, having the flag in RHEL 8.5, and then having the "-mod-devel" subpackage coming into 8.6 is fine, *if* the -mod-devel subpackage stuff can land in CentOS Stream soon. I can *build* on CS8 and then *deploy* on RHEL 8.5 without too much hassle. (In reply to Neal Gompa from comment #19) > (In reply to Neal Gompa from comment #18) > > (In reply to Luboš Uhliarik from comment #17) > > > Hey Neal, > > > > > > I'm OK to rebase the Patch by myself, but as I said it is too late now to > > > make these changes to RHEL-8.5. I will try to get them to next RHEL-8 > > > release and I will also take a look at RHEL-9.0. > > > > > > Is it useful for you to have nginx 1.20 built with "--with-compat", but > > > without having "-mod-devel" subpackage for now? > > > > Yes, that's still quite helpful. I can hack around things in the short-term. > > To make it clearer, having the flag in RHEL 8.5, and then having the > "-mod-devel" subpackage coming into 8.6 is fine, *if* the -mod-devel > subpackage stuff can land in CentOS Stream soon. I can *build* on CS8 and > then *deploy* on RHEL 8.5 without too much hassle. Understood Neal. As soon as RHEL-8.6 is branched, I can start working on adding -mod-devel subpackage stuff and as soon as it is in our RHEL-8.6 distgit repo, it will get mirrored to c8s (CentOS Stream 8) and you can build it. I Can not tell you the exact timeframe now, but I will give it a priority as soon as RHEL-8.6 is branched. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (new module: nginx:1.20), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2021:4207 |
Created attachment 1812663 [details] nginx-mod-vts RPM built for nginx 1.18 Description of problem: Nginx is not built with the flag "--with-compat" set at configure time, which makes it so that Nginx is unable to use third-party Nginx modules built externally. Please update nginx so that this is fixed. Version-Release number of selected component (if applicable): 1.18.0-3.module+el8.4.0+11152+f736ed63.1 How reproducible: Always Steps to Reproduce: 1. Enable the nginx:1.18 module 2. Install nginx 3. Install the attached RPM 4. Try to run nginx Actual results: Nginx fails with the following error: nginx: [emerg] module "/usr/lib64/nginx/modules/ngx_http_vhost_traffic_status_module.so" is not binary compatible in /usr/share/nginx/modules/mod-vhost-traffic-status.conf:1 Expected results: Nginx successfully loads. Additional info: This is an issue on all Nginx versions provided, though I initially discovered this with nginx 1.18.