Bug 1991976 - block: fix New warning in nvme_setup_discard [NEEDINFO]
Summary: block: fix New warning in nvme_setup_discard
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: kernel
Version: 8.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: beta
: ---
Assignee: Ming Lei
QA Contact: ChanghuiZhong
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-10 13:53 UTC by Ming Lei
Modified: 2021-11-10 06:27 UTC (History)
4 users (show)

Fixed In Version: kernel-4.18.0-337.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-11-09 19:27:01 UTC
Type: Bug
Target Upstream Version:
minlei: needinfo?


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gitlab redhat/rhel/src/kernel rhel-8 merge_requests 1132 0 None None None 2021-08-11 03:44:38 UTC
Red Hat Issue Tracker RHELPLAN-93035 0 None None None 2021-08-10 14:39:44 UTC
Red Hat Product Errata RHSA-2021:4356 0 None None None 2021-11-09 19:27:18 UTC

Description Ming Lei 2021-08-10 13:53:01 UTC
Description of problem:

https://lore.kernel.org/linux-nvme/YQJ09eaGIssStGXt@T590/#r


Introduced by the following commit, which is added to rhel8 recently

commit 2705dfb2094777e405e065105e307074af8965c1
Author: Ming Lei <ming.lei>
Date:   Mon Jun 28 10:33:12 2021 +0800

    block: fix discard request merge




Version-Release number of selected component (if applicable):


How reproducible:

not easy to reproduce


Steps to Reproduce:

N/A


Actual results:


Expected results:


Additional info:

Comment 4 Ming Lei 2021-08-25 00:47:59 UTC
Hi Changhui,

I don't have a reproducer for this BZ, and originally it was reported by
Oleksandr Natalenko on Fedora or upstream, and I remember it is very hard to
trigger.

So I think it is fine to run a sanity test for moving on.

Thanks,

Comment 5 ChanghuiZhong 2021-08-25 00:53:38 UTC
(In reply to Ming Lei from comment #4)
> Hi Changhui,
> 
> I don't have a reproducer for this BZ, and originally it was reported by
> Oleksandr Natalenko on Fedora or upstream, and I remember it is very hard to
> trigger.
> 
> So I think it is fine to run a sanity test for moving on.
> 
> Thanks,

Hi,Ming

yes,I tried it and it is not easy to reproduce.

I will run sanity test, and feedback the test result as soon as possible.

Thanks

Comment 6 Ming Lei 2021-08-25 01:00:24 UTC
(In reply to ChanghuiZhong from comment #5)
> (In reply to Ming Lei from comment #4)
> > Hi Changhui,
> > 
> > I don't have a reproducer for this BZ, and originally it was reported by
> > Oleksandr Natalenko on Fedora or upstream, and I remember it is very hard to
> > trigger.
> > 
> > So I think it is fine to run a sanity test for moving on.
> > 
> > Thanks,
> 
> Hi,Ming
> 
> yes,I tried it and it is not easy to reproduce.
> 
> I will run sanity test, and feedback the test result as soon as possible.
> 

Hi Changhui,

OK, thanks!

BTW, Rob mentioned in email, if this bug can't be moved on today, we will have to re-submit
it and run the whole BZ procedure again for post-beta.

So if possible, can test/update the BZ today?

Thanks,
Ming

Comment 7 ChanghuiZhong 2021-08-25 01:04:54 UTC
(In reply to Ming Lei from comment #6)
> 
> BTW, Rob mentioned in email, if this bug can't be moved on today, we will
> have to re-submit
> it and run the whole BZ procedure again for post-beta.
> 
> So if possible, can test/update the BZ today?


ok, I think I can,I will try to update this bz before the end of today

Thanks

Comment 8 ChanghuiZhong 2021-08-25 09:54:12 UTC
sanity test passed with 4.18.0-330.el8.mr1132_210811_0355:
https://beaker.engineering.redhat.com/jobs/5734978

Setting to verified:tested

Comment 13 ChanghuiZhong 2021-08-28 02:15:21 UTC
sanity test passed with kernel-4.18.0-337.el8:
https://beaker.engineering.redhat.com/jobs/5740299

All fix patches has included to kernel tree:
$ git log kernel-4.18.0-337.el8 --oneline --grep=1991976
218e521b73cd Merge: block: return ELEVATOR_DISCARD_MERGE if possible
6806ca28a0b3 block: return ELEVATOR_DISCARD_MERGE if possible

move to verified

Comment 16 errata-xmlrpc 2021-11-09 19:27:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: kernel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4356


Note You need to log in before you can comment on or make changes to this bug.