Spec URL: https://jjames.fedorapeople.org/python-pari-jupyter/python-pari-jupyter.spec SRPM URL: https://jjames.fedorapeople.org/python-pari-jupyter/python-pari-jupyter-1.3.2-1.fc35.src.rpm Fedora Account System Username: jjames Description: This package contains a Jupyter kernel for PARI/GP.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - Please offer your patches upstream and link to the issue or PR. https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/ - Please add %py_provides python3-PARIKernel See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides_for_importable_modules. ===== Notes ===== - In spec/kernel.json, an unversioned “python” command is used, but this is supposed to be OK because of https://github.com/jupyter/jupyter_client/commit/8467a0c129518587810d54828716a289b9733d52, so I think you can leave it as-is. ===== MUST items ===== C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. These are properly-installed compiled Python extensions. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License v3.0 or later", "GNU General Public License v3.0 or later". 14 files have unknown license. Detailed output of licensecheck in /home/reviewer/1992881-python-pari-jupyter/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-pari-jupyter [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pari-jupyter-1.3.2-1.fc35.aarch64.rpm python-pari-jupyter-debugsource-1.3.2-1.fc35.aarch64.rpm python-pari-jupyter-1.3.2-1.fc35.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- python3-pari-jupyter: /usr/lib64/python3.10/site-packages/PARIKernel/io.cpython-310-aarch64-linux-gnu.so python3-pari-jupyter: /usr/lib64/python3.10/site-packages/PARIKernel/kernel.cpython-310-aarch64-linux-gnu.so python3-pari-jupyter: /usr/lib64/python3.10/site-packages/PARIKernel/svg.cpython-310-aarch64-linux-gnu.so Source checksums ---------------- https://github.com/jdemeyer/pari_jupyter/archive/1.3.2/pari-jupyter-1.3.2.tar.gz : CHECKSUM(SHA256) this package : c86fba9ebaada033bcdb6c7dda6b579aa4aa5a91e30786b12f04338711213fc2 CHECKSUM(SHA256) upstream package : c86fba9ebaada033bcdb6c7dda6b579aa4aa5a91e30786b12f04338711213fc2 Requires -------- python3-pari-jupyter (rpmlib, GLIBC filtered): config(python3-pari-jupyter) ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libpari-gmp-tls.so.7()(64bit) libreadline.so.8()(64bit) pari-gp python(abi) python-jupyter-filesystem python3.10dist(ipykernel) rtld(GNU_HASH) python-pari-jupyter-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-pari-jupyter: config(python3-pari-jupyter) python-pari-jupyter python3-pari-jupyter python3-pari-jupyter(aarch-64) python3.10-pari-jupyter python3.10dist(pari-jupyter) python3dist(pari-jupyter) python-pari-jupyter-debugsource: python-pari-jupyter-debugsource python-pari-jupyter-debugsource(aarch-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1992881 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Python, Shell-api Disabled plugins: SugarActivity, Perl, fonts, Java, C/C++, Haskell, PHP, R, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
The patches have (mostly) been submitted upstream, and URLs provided in the spec file. The bug fix part of the second patch has been submitted upstream, but I omitted the part that actually changes the language level. Upstream will have their own time frame for doing that, or more likely it will happen whenever Cython changes the default language level. I like to do that for Fedora, because we only support python 3 and it turns up problems that will surface whenever Cython does change the default. The suggested %py_provides has been added. Thanks! I don't think I've ever done a package before containing a module that isn't named by the package itself, so I've learned something. New URLs: Spec URL: https://jjames.fedorapeople.org/python-pari-jupyter/python-pari-jupyter.spec SRPM URL: https://jjames.fedorapeople.org/python-pari-jupyter/python-pari-jupyter-1.3.2-2.fc35.src.rpm
Looks good, thanks! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. These are properly-installed compiled Python extensions. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License v3.0 or later", "GNU General Public License v3.0 or later". 14 files have unknown license. Detailed output of licensecheck in /home/reviewer/1992881-python-pari-jupyter/re-review/1992881-python- pari-jupyter/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package does not use a name that already exists. Note: Couldn't connect to Pagure, check manually [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/jdemeyer/pari_jupyter/archive/1.3.2/pari- jupyter-1.3.2.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ This was a transient GitHub issue. The spec file is fine. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-pari-jupyter [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. Upstream offers no tests. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pari-jupyter-1.3.2-2.fc35.aarch64.rpm python-pari-jupyter-debugsource-1.3.2-2.fc35.aarch64.rpm python-pari-jupyter-1.3.2-2.fc35.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- python3-pari-jupyter: /usr/lib64/python3.10/site-packages/PARIKernel/io.cpython-310-aarch64-linux-gnu.so python3-pari-jupyter: /usr/lib64/python3.10/site-packages/PARIKernel/kernel.cpython-310-aarch64-linux-gnu.so python3-pari-jupyter: /usr/lib64/python3.10/site-packages/PARIKernel/svg.cpython-310-aarch64-linux-gnu.so Requires -------- python3-pari-jupyter (rpmlib, GLIBC filtered): config(python3-pari-jupyter) ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libpari-gmp-tls.so.7()(64bit) libreadline.so.8()(64bit) pari-gp python(abi) python-jupyter-filesystem python3.10dist(ipykernel) rtld(GNU_HASH) python-pari-jupyter-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-pari-jupyter: config(python3-pari-jupyter) python-PARIKernel python-pari-jupyter python3-PARIKernel python3-pari-jupyter python3-pari-jupyter(aarch-64) python3.10-PARIKernel python3.10-pari-jupyter python3.10dist(pari-jupyter) python3dist(pari-jupyter) python-pari-jupyter-debugsource: python-pari-jupyter-debugsource python-pari-jupyter-debugsource(aarch-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1992881 Buildroot used: fedora-rawhide-aarch64 Active plugins: Python, Generic, Shell-api Disabled plugins: R, PHP, Java, Perl, SugarActivity, fonts, Ocaml, Haskell, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pari-jupyter
Built in Rawhide and F35.