RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1993290 - thin_repair should clear the needs_check flag in the repaired metadata
Summary: thin_repair should clear the needs_check flag in the repaired metadata
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: device-mapper-persistent-data
Version: 8.5
Hardware: All
OS: Linux
low
low
Target Milestone: beta
: ---
Assignee: Ming-Hung Tsai
QA Contact: Filip Suba
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-12 17:27 UTC by Ming-Hung Tsai
Modified: 2021-11-10 09:26 UTC (History)
7 users (show)

Fixed In Version: device-mapper-persistent-data-0.9.0-4.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-11-09 19:51:17 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-93447 0 None None None 2021-08-12 17:29:10 UTC
Red Hat Product Errata RHBA-2021:4457 0 None None None 2021-11-09 19:51:22 UTC

Description Ming-Hung Tsai 2021-08-12 17:27:56 UTC
Description of problem:

From the user perspective, a repaired metadata built by thin_repair should be clean and without the needs_check flag that imposes further examination. Therefore, thin_repair should remove the needs_check flag if it is present in the source metadata.

thin_restore should follow the same rule.

Users can barely find this issue since RHEL is shipped with thin_check-enabled by default, the flag therefore is automatically removed during volume activation.


Version-Release number of selected component (if applicable):

0.9.0-3.el8


Steps to Reproduce:

1. Create a flagged metadata using thin_restore (requires dmpd 0.9.0-3.el8 or older versions):

# dd if=/dev/zero of=src.bin bs=1M count=4
# thin_restore -i input.xml -o src.bin

in which input.xml 

2. Repair the flagged source metadata

# dd if=/dev/zero of=dest.bin bs=1M count=4
# thin_repair -i src.bin -o dest.bin

3. Check presence of the needs_check flag in the dest metadata

# thin_dump dest.bin


Actual results:
<superblock uuid="" time="1" transaction="1" flags="1"

Expected results:
The superblock flag should be zeroed
<superblock uuid="" time="1" transaction="1" flags="0" ... >

Comment 1 Ming-Hung Tsai 2021-08-12 17:48:21 UTC
The patch has been upstreamed
https://github.com/jthornber/thin-provisioning-tools/commit/c32517f827f04f4f079a0913fa25b57b8b4c2960

And here's the backport for dmpd v0.9.0, as well as the test cases
https://github.com/mingnus/thin-provisioning-tools/commit/6b698fb7a4205d629dfcfdbbb158ec176ee05f40

Two new test cases are introduced for testing the reproduce steps above.

# ./configure --enable-testing ...
# make functional-test

...
thin-repair
  clear-needs-check-flag ................................... pass
  ...
thin-restore
  clear-needs-check-flag ................................... pass

Comment 6 Filip Suba 2021-08-27 11:05:16 UTC
Verified with device-mapper-persistent-data-0.9.0-4.el8.

Comment 10 errata-xmlrpc 2021-11-09 19:51:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (device-mapper-persistent-data bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4457


Note You need to log in before you can comment on or make changes to this bug.