Spec URL: https://dcavalca.fedorapeople.org/review/rust-statrs/rust-statrs.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-statrs/rust-statrs-0.15.0-1.fc36.src.rpm Description: Statistical computing library for Rust. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=73790057
Taking this review. Blocking issue: Do you know the license of those "data/nist/*" files? I *think* NIST should publish things into the public domain, but it would be good to check. Non-blocking minor issues: 1) Convert README to unix line encodings (possibly with dox2unix): rust-statrs-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/rust-statrs-devel/README.md 2) Drop the "nightly" feature (it will never work in Fedora because we only have stable Rust). 3) Leave "# Initial patched metadata" generated comment in the spec file. 4) Open a PR / link the upstream PR for the nalgebra 0.27.1 → 0.29 bump. 5) Drop the useless "data" files from %doc: "%doc README.md CHANGELOG.md data/nist/numacc4.txt data/nist/numacc3.txt data/nist/numacc2.txt data/nist/numacc1.txt data/nist/michaelso.txt data/nist/mavro.txt data/nist/lottery.txt data/nist/lew.txt" Those do not look like documentation at all, but rather data. They should not be marked as %doc, leaving only "%doc README.md CHANGELOG.md".
It looks like the NIST data comes from this dataset: https://www.itl.nist.gov/div898/strd/univ/backgroundinfo.html . I couldn't find a license statement there, but I did find https://www.nist.gov/open/copyright-fair-use-and-licensing-statements-srd-data-software-and-technical-series-publications#srd which seems to imply this is under a generic attribution license and should be freely redistributable. I'm not sure how this should be represented in the License of the package though.
Well ... better ask on the legal <at> lists.fedoraproject.org list if we're not sure about the terms of the license.
Done, thanks! https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/LSM6MO6TAHTIDNF5COCA6UWQDHWRF3AH/
Updated to address feedback. Changelog: - remove non-redistributable data files and disable the corresponding tests - drop nightly feature - fix README EOL encoding - add upstream PR link
Looks like my message to the legal list was blocked for moderation, so I'm posting it here too: > I'm not sure that this will be enough. After all, source packages > (including the original sources, with those data sets) are > redistributed by Fedora, as well. > In such situations, it's usually necessary to create "clean" tarballs > such that the offending material is also not redistrubited with SRPMs, > either. > (For an example where I needed to do this for another Rust package, > look at ompl: https://src.fedoraproject.org/rpms/rust-opml)
Updated to address feedback. Changelog: - generate clean tarball without non-redistributable data files
Great, thanks! Final review: Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all (runnable) unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - non-redistributable test data is removed before creating a clean source tarball - package complies with Rust Packaging Guidelines Package APPROVED.
Thanks! $ fedpkg request-repo rust-statrs 1993498 https://pagure.io/releng/fedora-scm-requests/issue/36683
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-statrs