Bug 1993506 - Review Request: rust-cpc - Evaluates math expressions, with support for units and conversion between units
Summary: Review Request: rust-cpc - Evaluates math expressions, with support for units...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-13 16:26 UTC by Davide Cavalca
Modified: 2022-08-12 01:41 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-01 23:22:24 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2021-08-13 16:26:55 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-cpc/rust-cpc.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-cpc/rust-cpc-1.7.0-1.fc36.src.rpm

Description:
Evaluates math expressions, with support for units and conversion between
units.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2021-08-13 16:26:57 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=73793135

Comment 2 Fabio Valentini 2022-01-21 22:04:34 UTC
A few comments:

- please regenerate the package with rust2rpm 20
- update to the latest version 1.8.0, if possible

Do you want to ship the cpc binary as well, or do you only need the library?
If you decide to package the binary, you need to make sure that the "-n %{crate}" subpackage gets the correct License field for all statically linked components.

If you don't want to include the cpc binary, it is easy to disable generating the subpackage and building the binary:
When running "rust2rpm -p", add the line "autobins = false" to the "[package]" section. It will make the crate behave as if it only shipped the library, and not a binary too.

Comment 3 Davide Cavalca 2022-02-13 06:26:32 UTC
Effective license calculation:
ASL 2.0 and (MIT or ASL 2.0) and MIT and (Unlicense or MIT) = ASL 2.0 and MIT

Full list:
# ASL 2.0: rust-decimal 2.1.0
# MIT or ASL 2.0: rust-bitflags 1.3.2
# MIT or ASL 2.0: rust-cc 1.0.72
# MIT or ASL 2.0: rust-libc 0.2.117
# MIT or ASL 2.0: rust-ord_subset 3.1.1
# MIT or ASL 2.0: rust-regex 1.5.4
# MIT or ASL 2.0: rust-regex-syntax 0.6.25
# MIT or ASL 2.0: rust-rustc-serialize 0.3.24
# MIT or ASL 2.0: rust-serde 1.0.136
# MIT or ASL 2.0: rust-unicode-segmentation 1.9.0
# MIT: rust-cpc 1.8.0
# Unlicense or MIT: rust-aho-corasick 0.7.18
# Unlicense or MIT: rust-memchr 2.4.1

Comment 4 Davide Cavalca 2022-02-13 06:30:40 UTC
Yeah, I'd like to include the binary, I think it's pretty useful.

Spec URL: https://dcavalca.fedorapeople.org/review/rust-cpc/rust-cpc.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-cpc/rust-cpc-1.8.0-1.fc37.src.rpm

Changelog:
- re-run rust2rpm
- update to 1.8.0
- update effective license for the cpc subpackage

Comment 5 Fabio Valentini 2022-05-01 13:48:02 UTC
Please refresh the spec file with rust2rpm 21 before importing it,
and add something like the breakdown from Comment 3 or a simplified version of it to the spec.
Other than that, looks good to me.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 6 Michel Lind 2022-08-01 16:43:55 UTC
Reapproving as the approval has expired

Comment 7 Davide Cavalca 2022-08-01 16:44:59 UTC
Thanks!

$ fedpkg request-repo rust-cpc 1993506
https://pagure.io/releng/fedora-scm-requests/issue/46110
$ fedpkg request-branch --all-releases --repo rust-cpc
https://pagure.io/releng/fedora-scm-requests/issue/46111
https://pagure.io/releng/fedora-scm-requests/issue/46112

Comment 8 Gwyn Ciesla 2022-08-01 17:05:25 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cpc

Comment 9 Fedora Update System 2022-08-01 23:21:34 UTC
FEDORA-2022-3fbca4d71b has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3fbca4d71b

Comment 10 Fedora Update System 2022-08-01 23:22:24 UTC
FEDORA-2022-3fbca4d71b has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2022-08-01 23:59:49 UTC
FEDORA-2022-fd1530cd8b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-fd1530cd8b

Comment 12 Fedora Update System 2022-08-02 01:16:47 UTC
FEDORA-2022-fd1530cd8b has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-fd1530cd8b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-fd1530cd8b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-08-02 18:42:58 UTC
FEDORA-2022-6a794dffa9 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-6a794dffa9

Comment 14 Fedora Update System 2022-08-03 02:56:56 UTC
FEDORA-2022-6a794dffa9 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-6a794dffa9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-6a794dffa9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-08-10 01:16:33 UTC
FEDORA-2022-fd1530cd8b has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2022-08-12 01:41:37 UTC
FEDORA-2022-6a794dffa9 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.