Spec URL: https://dcavalca.fedorapeople.org/review/rust-cpc/rust-cpc.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-cpc/rust-cpc-1.7.0-1.fc36.src.rpm Description: Evaluates math expressions, with support for units and conversion between units. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=73793135
A few comments: - please regenerate the package with rust2rpm 20 - update to the latest version 1.8.0, if possible Do you want to ship the cpc binary as well, or do you only need the library? If you decide to package the binary, you need to make sure that the "-n %{crate}" subpackage gets the correct License field for all statically linked components. If you don't want to include the cpc binary, it is easy to disable generating the subpackage and building the binary: When running "rust2rpm -p", add the line "autobins = false" to the "[package]" section. It will make the crate behave as if it only shipped the library, and not a binary too.
Effective license calculation: ASL 2.0 and (MIT or ASL 2.0) and MIT and (Unlicense or MIT) = ASL 2.0 and MIT Full list: # ASL 2.0: rust-decimal 2.1.0 # MIT or ASL 2.0: rust-bitflags 1.3.2 # MIT or ASL 2.0: rust-cc 1.0.72 # MIT or ASL 2.0: rust-libc 0.2.117 # MIT or ASL 2.0: rust-ord_subset 3.1.1 # MIT or ASL 2.0: rust-regex 1.5.4 # MIT or ASL 2.0: rust-regex-syntax 0.6.25 # MIT or ASL 2.0: rust-rustc-serialize 0.3.24 # MIT or ASL 2.0: rust-serde 1.0.136 # MIT or ASL 2.0: rust-unicode-segmentation 1.9.0 # MIT: rust-cpc 1.8.0 # Unlicense or MIT: rust-aho-corasick 0.7.18 # Unlicense or MIT: rust-memchr 2.4.1
Yeah, I'd like to include the binary, I think it's pretty useful. Spec URL: https://dcavalca.fedorapeople.org/review/rust-cpc/rust-cpc.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-cpc/rust-cpc-1.8.0-1.fc37.src.rpm Changelog: - re-run rust2rpm - update to 1.8.0 - update effective license for the cpc subpackage
Please refresh the spec file with rust2rpm 21 before importing it, and add something like the breakdown from Comment 3 or a simplified version of it to the spec. Other than that, looks good to me. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches
Reapproving as the approval has expired
Thanks! $ fedpkg request-repo rust-cpc 1993506 https://pagure.io/releng/fedora-scm-requests/issue/46110 $ fedpkg request-branch --all-releases --repo rust-cpc https://pagure.io/releng/fedora-scm-requests/issue/46111 https://pagure.io/releng/fedora-scm-requests/issue/46112
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cpc
FEDORA-2022-3fbca4d71b has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3fbca4d71b
FEDORA-2022-3fbca4d71b has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-fd1530cd8b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-fd1530cd8b
FEDORA-2022-fd1530cd8b has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-fd1530cd8b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-fd1530cd8b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-6a794dffa9 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-6a794dffa9
FEDORA-2022-6a794dffa9 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-6a794dffa9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-6a794dffa9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-fd1530cd8b has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-6a794dffa9 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.