Bug 1993720 - inst.rescue crashes if /etc/fstab '/' mount point lacks a subvol= mount option (btrfs)
Summary: inst.rescue crashes if /etc/fstab '/' mount point lacks a subvol= mount optio...
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 35
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Anaconda Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: Btrfs
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-16 00:29 UTC by Chris Murphy
Modified: 2022-12-13 15:34 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-12-13 15:34:00 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
screenshot of crash (345.64 KB, image/png)
2021-08-16 00:29 UTC, Chris Murphy
no flags Details
syslog (472.05 KB, text/plain)
2021-08-16 00:31 UTC, Chris Murphy
no flags Details
storage.log (115.15 KB, text/plain)
2021-08-16 00:31 UTC, Chris Murphy
no flags Details
anaconda.log (12.52 KB, text/plain)
2021-08-16 00:32 UTC, Chris Murphy
no flags Details
program.log (2.82 KB, text/plain)
2021-08-16 00:32 UTC, Chris Murphy
no flags Details

Description Chris Murphy 2021-08-16 00:29:10 UTC
Created attachment 1814308 [details]
screenshot of crash

Description of problem:

Continuation/variation on bug 1993718.

Version-Release number of selected component (if applicable):
anaconda 35.21-1.fc35

How reproducible:
Always

Steps to Reproduce:
1. Install Fedora-Workstation-Live-x86_64-35-20210814.n.0.iso using default/auto partitioning
2. Modify the /etc/fstab on this installation
- UUID=$fsuuid / btrfs subvol=root,compress=zstd:1 0 0
+ UUID=$fsuuid / btrfs compress=zstd:1 0 0
3. Reboot the installation... it boots and mounts fine because rootflags=subvol=root in BLS snippets gives the proper hint
4. Reboot Fedora-Everything-netinst-x86_64-35-20210814.n.0.iso
5. Choose option 1) Continue



Actual results:

Crash (see screenshot)

inst.rescue needs the subvol hint in fstab or it doesn't know what to mount and then crashes

Expected results:

Similar to bug 1993718. Needs a design and a plan.

Additional info:

Comment 1 Chris Murphy 2021-08-16 00:31:43 UTC
Created attachment 1814309 [details]
syslog

Comment 2 Chris Murphy 2021-08-16 00:31:57 UTC
Created attachment 1814310 [details]
storage.log

Comment 3 Chris Murphy 2021-08-16 00:32:09 UTC
Created attachment 1814311 [details]
anaconda.log

Comment 4 Chris Murphy 2021-08-16 00:32:31 UTC
Created attachment 1814312 [details]
program.log

Comment 5 Chris Murphy 2021-08-16 00:53:04 UTC
Crash does not happen following 'btrfs sub set-default 258 /mnt' i.e. setting the default subvolume so that the mount command mounts the 'root' subvolume by default, works around the problem. And assembly is correct.

So inst.rescue isn't crashing on the lack of subvol=root being present; it's crashing because it's not finding what's expected when it mounts the top-level (ID 5) subvolume, which is not a Fedora root.

Comment 6 Chris Murphy 2021-08-16 00:55:45 UTC
See also https://pagure.io/fedora-btrfs/project/issue/51

Comment 7 Ben Cotton 2022-11-29 17:03:16 UTC
This message is a reminder that Fedora Linux 35 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 35 on 2022-12-13.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '35'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 35 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 8 Ben Cotton 2022-12-13 15:34:00 UTC
Fedora Linux 35 entered end-of-life (EOL) status on 2022-12-13.

Fedora Linux 35 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.