Bug 1994094 - Some hardcodes are detected at the code level in OpenShift console components
Summary: Some hardcodes are detected at the code level in OpenShift console components
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Kubevirt Plugin
Version: 4.8
Hardware: All
OS: All
unspecified
low
Target Milestone: ---
: 4.10.0
Assignee: Matan Schatzman
QA Contact: Guohua Ouyang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-16 17:33 UTC by Robb Hamilton
Modified: 2022-03-10 16:05 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of: 1991439
Environment:
Last Closed: 2022-03-10 16:05:18 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 10749 0 None open Bug 1994094: Added missing translations 2021-12-29 12:39:55 UTC
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-10 16:05:37 UTC

Comment 1 Robb Hamilton 2021-08-16 17:34:46 UTC
Files that need updating:
* frontend/packages/kubevirt-plugin/src/components/cdi-upload-provider/upload-pvc-form/upload-pvc-form-status.tsx
* frontend/packages/kubevirt-plugin/src/components/cdi-upload-provider/upload-pvc-popover.tsx
* frontend/packages/kubevirt-plugin/src/components/cdi-upload-provider/upload-pvc-popover.tsx
* frontend/packages/kubevirt-plugin/src/components/modals/scheduling-modals/affinity-modal/components/affinity-table/affinity-table.tsx
* frontend/packages/kubevirt-plugin/src/components/vms/vm-console/connectors/SerialConsoleConnector.tsx

Comment 2 Robb Hamilton 2021-08-16 18:16:10 UTC
Additional file needing updating:
* frontend/packages/network-attachment-definition-plugin/src/components/network-attachment-definitions/NetworkAttachmentDefinitionsForm.tsx

Comment 3 Matan Schatzman 2021-12-29 13:55:08 UTC
Hi @rhamilto , @gouyang ,


files:
pod.ts - should not be translated, it's part of an internal object and not related to something that will be presented to the user.
SerialConsoleConnector.tsx - those that arent translated in this file are prints errors - should it be translated?

Thanks
Matan

Comment 4 Guohua Ouyang 2022-01-04 02:11:02 UTC
I have no problem for these files not to be translated.

Comment 10 errata-xmlrpc 2022-03-10 16:05:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056


Note You need to log in before you can comment on or make changes to this bug.