Bug 1994481 - Review Request: golang-github-openshift-online-ocm-sdk - SDK for the Red Hat OpenShift Cluster Manager
Summary: Review Request: golang-github-openshift-online-ocm-sdk - SDK for the Red Hat ...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1996827 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-08-17 11:12 UTC by Sanne Raymaekers
Modified: 2021-08-24 15:45 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-08-24 07:56:49 UTC
Type: ---
Embargoed:
davide: fedora-review+

Attachments (Terms of Use)

Description Sanne Raymaekers 2021-08-17 11:12:49 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/gundersanne/golang-github-openshift-online-ocm-sdk/fedora-rawhide-x86_64/02525470-golang-github-openshift-online-ocm-sdk/golang-github-openshift-online-ocm-sdk.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/gundersanne/golang-github-openshift-online-ocm-sdk/fedora-rawhide-x86_64/02525470-golang-github-openshift-online-ocm-sdk/golang-github-openshift-online-ocm-sdk-0.1.200-1.fc36.src.rpm
Description:
This SDK simplifies the use of the OCM API on https://api.openshift.com/, and provides several go modules which simplify the development of services for the platform.
Fedora Account System Username: gundersanne
Comment 1 Sanne Raymaekers 2021-08-23 14:35:26 UTC 
koji build succeeded https://koji.fedoraproject.org/koji/taskinfo?taskID=74396433
Comment 2 Davide Cavalca 2021-08-23 16:19:21 UTC 
Taking this review
Comment 3 Davide Cavalca 2021-08-23 16:34:04 UTC 
go2pm package, simplifying review considerably:
- license is correct and acceptable
- dependencies are all packaged
- no notable rpmlint warnings
- package builds and installs without issues

APPROVED
Comment 4 Sanne Raymaekers 2021-08-23 17:22:45 UTC 
Thank you for the review!
Comment 5 Sanne Raymaekers 2021-08-23 19:23:58 UTC 
*** Bug 1996827 has been marked as a duplicate of this bug. ***
Comment 6 Sanne Raymaekers 2021-08-24 07:56:49 UTC 
Closing this, reopened here under correct reporter email https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=1996995 ; if you have time to re-ack it (it's the exact same package) please do. My fault.
Comment 7 Davide Cavalca 2021-08-24 15:39:57 UTC 
Looks like Tom Gundersen already took care of it, so you should be good to go.
Comment 8 Sanne Raymaekers 2021-08-24 15:45:32 UTC 
Indeed, thank you nonetheless!
Note You need to log in before you can comment on or make changes to this bug.