Fedora Account System
Red Hat Associate
Red Hat Customer
I think we want something like the following. rm baseLocation/plugins/com.ibm.icu.base_3.4.4.1.jar ln -s %{_javadir}/icu4j.jar baseLocation/plugins/com.ibm.icu.base_3.4.4.1.jar rm baseLocation/plugins/com.ibm.icu_3.4.4.1.jar ln -s %{_javadir}/icu4j.jar baseLocation/plugins/com.ibm.icu_3.4.4.1.jar rm features/org.eclipse.platform.launchers/bin/startup.jar rm plugins/org.eclipse.swt.tools/swttools.jar rm plugins/org.eclipse.swt.win32.win32.x86/swt.jar rm plugins/org.eclipse.swt/extra_jars/exceptions.jar For icu4j, I tried upstream release 3.4.4 (packaged as a rpm based on an old JPackage version of icuj) and it didn't appear to work. The difference between com.ibm.icu.base and com.ibm.icu seem to be the number of classes, where base is some subset of the full version. The `diff' between the included jar and upstream 3.4.4 jar is: @@ -1,9 +1,5 @@ META-INF/ META-INF/MANIFEST.MF -about.html -about_files/ -about_files/license.html -about_files/ucdterms.txt com/ com/ibm/ com/ibm/icu/ @@ -33,6 +29,7 @@ com/ibm/icu/impl/CollectionUtilities$MultiComparator.class com/ibm/icu/impl/CollectionUtilities$ObjectMatcher.class com/ibm/icu/impl/CollectionUtilities$PrefixIterator.class +com/ibm/icu/impl/CollectionUtilities$RegexIterator.class com/ibm/icu/impl/CollectionUtilities.class com/ibm/icu/impl/ICUBinary$Authenticate.class com/ibm/icu/impl/ICUBinary.class @@ -1062,4 +1059,3 @@ com/ibm/icu/util/ValueIterator$Element.class com/ibm/icu/util/ValueIterator.class com/ibm/icu/util/VersionInfo.class -plugin.properties
We currently build the icu4j 3.4.5 in the eclipse srpm. We are going to move this build from the the eclipse srpm to the icu4j package and make an icu4j-eclipse subpackage. The build logic for the icu4j-eclipse subpackage is currently in the eclispe spec file from FC-6. Any help here would be appreciated. Feel free to ping me if you have any questions. Thanks.
I have an icu4j 3.4.5 spec. Would this be useful? I can attach it.
Yeah, that would be useful if we can't get it any place else. Thanks.
Re-assigning to Jeff as he will be doing this work.
Created attachment 144927 [details] Proposed patch to icu4j/devel/icu4j.spec
I need to look at the patch some more. The src.zip file is not being generated for com.ibm.icu.source plugin.
Created attachment 145093 [details] Proposed patch to icu4j/devel/icu4j.spec revised.
Assigning to Fernando to review proposed spec patch.
Working on it....
Created attachment 146254 [details] Merged spec file, ready to build (already tested on non-official mock)
OK guys, I've merged this with upstream, built and uploaded there, built and uploaded on the Toronto office FC7 mock. RPMs at /home/fnasser/icu4j (for x86_64) However, when I've tried to build on Brew I've got: 546290 build (dist-fc7, devel:icu4j-3_4_5-2jpp_1): open (btest1.z900.redhat.com) -> FAILED: BuildError: package icu4j not in list for tag dist-fc7 0 free 0 open 1 done 1 failed So I guess icu4j never really made it to Fedora Core. So someone would have to suggest it as a new package. Can someone who know the arguments for that propose it through the "New Package Process"? I will take care of any changes required by the review process. As test1 is tomorrow, this is kind of urgent.
icu4j has never been in Fedora, you are correct. Please submit it for review here: http://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora%20Core&format=core-review I can do the review if no one else is free. I needs to go into Core because it is needed by Eclipse which is in Core.
I'd rather we do the opposite. I prefer to do the review as we will be doing it for 100+ packages anyway. And I'd rather someone else from outside our groups asking for it. We are already asking for 90+ maven-related dependencies ;-)
(In reply to comment #13) > I'd rather we do the opposite. I prefer to do the review as we will be doing it > for 100+ packages anyway. And I'd rather someone else from outside our groups > asking for it. We are already asking for 90+ maven-related dependencies ;-) I'm confused. The package *must* go through the submission process via the link I submitted. We can always ask someone else to do the review, but it must be submitted there first.
Yes, that is what I am saying: _you_ propose the package for inclusion and we take care of any fixes, builds etc. required by the reviwers.
Just for reference, here is my spec for icu4j 3.4.5: http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/icu4j/current/SPECS/icu4j.spec?revision=74076&view=markup
Closing this bug because it is not relevant anymore - the eclipse package in F7 includes a copy of the icu4j eclipse package. I'll try to sort this out for F8.