Based on a customer case, we need to state that the `nodectl init` command must come at the end of the %post section. We can add the following note at the end of 6.1.3.3.3. Creating and running a Kickstart file [1], after step 2. [NOTE] ==== Ensure that the `nodectl init` command is at the very end of the %post section, so that it is the last command executed in that section. ==== This note is based on [2]. [1] https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/installing_red_hat_virtualization_as_a_self-hosted_engine_using_the_command_line#Creating_and_Running_a_Kickstart_File [2] See also https://bugzilla.redhat.com/show_bug.cgi?id=1842484#c32
(In reply to Steve Goodman from comment #0) > Based on a customer case, we need to state that the `nodectl init` command > must come at the end of the %post section. > > We can add the following note at the end of 6.1.3.3.3. Creating and running > a Kickstart file [1], after step 2. > > [NOTE] > ==== > Ensure that the `nodectl init` command is at the very end of the %post > section, so that it is the last command executed in that section. > ==== > > This note is based on [2]. > > [1] > https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/ > html-single/installing_red_hat_virtualization_as_a_self- > hosted_engine_using_the_command_line#Creating_and_Running_a_Kickstart_File > > [2] See also https://bugzilla.redhat.com/show_bug.cgi?id=1842484#c32 Just a small note - though it may be obvious - it must come at the end of the %post section, but *before* the reboot code, if any.
(In reply to Lev Veyde from comment #1) > Just a small note - though it may be obvious - it must come at the end of > the %post section, but *before* the reboot code, if any. Like this? [NOTE] ==== Ensure that the `nodectl init` command is at the very end of the %post section, so that it is the last command executed in that section. For example: ---- %post --log=/root/ks.post.log --erroronfail ... nodectl init sync systemctl reboot %end ---- ====
(In reply to Steve Goodman from comment #2) > (In reply to Lev Veyde from comment #1) > > Just a small note - though it may be obvious - it must come at the end of > > the %post section, but *before* the reboot code, if any. > > > Like this? > > [NOTE] > ==== > Ensure that the `nodectl init` command is at the very end of the %post > section, so that it is the last command executed in that section. For > example: > > ---- > %post --log=/root/ks.post.log --erroronfail > > ... > > nodectl init > > sync > systemctl reboot > %end > ---- > ==== I'm wondering if it's a good idea to actually include the reboot code in the sample, as I would like to prevent it from being included by default, as most customers should not use it like that. Thus I think it's better to just add a warning, or have it part of of the explanation i.e. that the nodectl init should be added at the very end of the %post section, before the reboot code if any.
(In reply to Lev Veyde from comment #3) > (In reply to Steve Goodman from comment #2) > > (In reply to Lev Veyde from comment #1) > > > Just a small note - though it may be obvious - it must come at the end of > > > the %post section, but *before* the reboot code, if any. > > > > > > Like this? > > > > [NOTE] > > ==== > > Ensure that the `nodectl init` command is at the very end of the %post > > section, so that it is the last command executed in that section. For > > example: > > > > ---- > > %post --log=/root/ks.post.log --erroronfail > > > > ... > > > > nodectl init > > > > sync > > systemctl reboot > > %end > > ---- > > ==== > > I'm wondering if it's a good idea to actually include the reboot code in the > sample, as I would like to prevent it from being included by default, as > most customers should not use it like that. > Thus I think it's better to just add a warning, or have it part of of the > explanation i.e. that the nodectl init should be added at the very end of > the %post section, before the reboot code if any. To clarify - normally customers should not include the commands to reboot the machine after the installation in the %post section. Instead they should use the "reboot" instruction in the kickstart file, to order the installation to reboot at the end of the installation. So adding the command to reboot in the %post section is actually a bad practice.
*** Bug 1842484 has been marked as a duplicate of this bug. ***
I'm on it.
One minor note -- otherwise, LGTM.
Verify this bug according above comments.
Published: https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/installing_red_hat_virtualization_as_a_self-hosted_engine_using_the_command_line/index#Creating_and_Running_a_Kickstart_File
LGTM, ready to close. Looks like this bug was reopened to test by QE. Testing done and verified on 14-Feb-2022. The content is live in the 4.4 documentation https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html-single/installing_red_hat_virtualization_as_a_self-hosted_engine_using_the_command_line/index#Creating_and_Running_a_Kickstart_File