RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1997064 - Setting adminStatus=disabled does not survive reboot
Summary: Setting adminStatus=disabled does not survive reboot
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: lldpad
Version: 8.4
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: rc
: ---
Assignee: Aaron Conole
QA Contact: Matt Lucius
URL:
Whiteboard:
Depends On:
Blocks: 1928312
TreeView+ depends on / blocked
 
Reported: 2021-08-24 11:03 UTC by Ales Musil
Modified: 2024-12-20 20:48 UTC (History)
17 users (show)

Fixed In Version: lldpad-1.0.1-19.git036e314.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-08 10:56:47 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-94591 0 None None None 2021-08-24 11:08:01 UTC
Red Hat Knowledge Base (Solution) 6287681 0 None None None 2021-08-27 16:19:01 UTC
Red Hat Product Errata RHBA-2022:7807 0 None None None 2022-11-08 10:56:52 UTC

Internal Links: 2138970

Description Ales Musil 2021-08-24 11:03:58 UTC 
Description of problem:
In RHEL7 it was possible to set adminStatus=disasbled for interface
and this status was persisted across reboot. 

Version-Release number of selected component (if applicable):
lldpad-1.0.1-14.git036e314.el8.x86_64.

How reproducible:
100%

Steps to Reproduce:
1. lldptool set-lldp –i $INTERFACE adminStatus=disabled
2. Reboot
3. lldptool get-lldp -i $INTERFACE adminStatus

Actual results:
Returns: "rx" or "rxtx"

Expected results:
Returns: "disabled"
Comment 1 Marina Kalinin 2021-08-27 16:39:53 UTC 
I am wondering if the fixes from bz#1915458 will also address this bz. Asked this question there.
Comment 2 Aaron Conole 2021-09-09 14:46:01 UTC 
I see what is happened now.

The ifindex is changing on the system, and this interacts negatively with:

  e272d34f45bc ("Use interface index instead of name in libconfig")

For example, I have a system where I booted it a few times, and got different ifindex on
some of the hardware because of PCI delays, etc.

So it seems this patch has some issues.  I have commented on:
  https://github.com/intel/openlldp/pull/3

And will work with upstream on it.
Comment 8 Mike Marciniszyn 2022-06-01 12:32:13 UTC 
(In reply to Aaron Conole from comment #2)
> 
> And will work with upstream on it.

So what is the status on an upstream fix?

The 1.0.1-16 has a fix for the nl socket buffer segfault, but the issue associated with a non-stable index.
Comment 9 loberman 2022-06-10 20:21:13 UTC 
Here is some justification and another example.

 A couple of struggles with the Marvell Qlogic driver in Virt configurations where we would drop frames and lose paths seems to now be understood.

The new out of box driver that was provided for some scatter/gather fixes in the driver and firmware disables priority flow control if lldpad is enabled on boot.

The problem is vdsm in RHV will keep starting even if it is set to disabled, so we need to remove the vdsm dependency on lldpad.

The lldpad service is only needed for software based FCOE, not the Marvell full offload qedf adapters so now with these new driver changes is going break stuff for customers with the ubiquitous qedf Fastlinq adapters in HPE servers.

Note that the inbox drivers in 8.5 for example dont break even with lldpad enabled and that is how this has escaped us for so long.

It is the new Marvell F/W and driver changes that see this new issue.

So we need a BZ created for the correct team in RHEV/Virt ENG to get this resolved please.

If you create the BZ ping me and I will provide a technical update.

Thanks
Laurence
Comment 17 Matt Lucius 2022-08-19 13:30:11 UTC 
Trying to reproduce the issue against lldpad 1.0.1-14 with a variety of boards setting lldpad to start on boot, then following the "set, reboot, get" sequence described above. I'm not able to see the issue with any type of NIC so far. Are there any which are more likely to have the problem?
Comment 18 Aaron Conole 2022-08-22 20:08:27 UTC 
It might be more likely to reproduce with Virtual machines.  I know I saw the problem when debugging using some virtual nics.
Comment 19 Aaron Conole 2022-08-22 20:17:21 UTC 
I've pushed a build for this.
Comment 20 Aaron Conole 2022-08-23 13:47:37 UTC 
Build is at https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=2130614
Comment 42 errata-xmlrpc 2022-11-08 10:56:47 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (lldpad bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:7807
Note You need to log in before you can comment on or make changes to this bug.