Spec URL: https://dcavalca.fedorapeople.org/review/dnf-flunk_dependent_remove/dnf-flunk-dependent-remove.spec SRPM URL: https://dcavalca.fedorapeople.org/review/dnf-flunk_dependent_remove/dnf-flunk_dependent_remove-1.0-3.fc36.src.rpm Description: Do not allow "dnf -y remove" to expand the list of packages to remove to include packages which require one of the explicitly listed packages. Fail the request instead. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=74589544
This probably warrants some additional context. This package is an updated version of https://github.com/facebookincubator/rpm-backports/tree/main/rpms/python3-dnf-flunk-dependent-remove and is meant to protect the system from automation (e.g. config management systems) accidentally removing more packages than originally expected via "dnf -y remove". It does that by simply failing the transaction. I'm including the source as part of the packages because it's a tiny Python script, and it seems overkill to setup a whole repo just for that, but I can go down that path if necessary (the rpm-backports repo I linked above is a legacy thing and will go away soon).
Taking this review.
(In reply to Davide Cavalca from comment #2) > This probably warrants some additional context. This package is an updated > version of > https://github.com/facebookincubator/rpm-backports/tree/main/rpms/python3- > dnf-flunk-dependent-remove and is meant to protect the system from > automation (e.g. config management systems) accidentally removing more > packages than originally expected via "dnf -y remove". It does that by > simply failing the transaction. > > I'm including the source as part of the packages because it's a tiny Python > script, and it seems overkill to setup a whole repo just for that, but I can > go down that path if necessary (the rpm-backports repo I linked above is a > legacy thing and will go away soon). It's fine to do it this way, though if it ever gets more complex, you probably would want to set up a proper repo.
> Summary: Do not remove packages recursively via automation This doesn't indicate that it's a DNF plugin... The package name should probably also change to have "dnf-plugin-" prefix instead of "dnf-" prefix.
Spec URL: https://dcavalca.fedorapeople.org/review/dnf-plugin-flunk_dependent_remove/dnf-plugin-flunk-dependent-remove.spec SRPM URL: https://dcavalca.fedorapeople.org/review/dnf-plugin-flunk_dependent_remove/dnf-plugin-flunk_dependent_remove-1.0-4.fc36.src.rpm Changelog: - Rename to dnf-plugin-flunk-dependent-remove - Clarify summary and description
The spec file name doesn't match the SRPM name, which caused fedora-review to complain.
Spec URL: https://dcavalca.fedorapeople.org/review/dnf-plugin-flunk_dependent_remove/dnf-plugin-flunk_dependent_remove.spec SRPM URL: https://dcavalca.fedorapeople.org/review/dnf-plugin-flunk_dependent_remove/dnf-plugin-flunk_dependent_remove-1.0-5.fc36.src.rpm Changelog: - Fix specfile name to match the actual package
Review notes: - Packaging follows general guidelines - Package licensing is indicated correctly - Packaging builds and installs - No serious issues from rpmlint PACKAGE APPROVED
Thanks! $ fedpkg request-repo dnf-plugin-flunk_dependent_remove 1998370 https://pagure.io/releng/fedora-scm-requests/issue/36569
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/dnf-plugin-flunk_dependent_remove
FEDORA-2021-e33feb6ac0 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e33feb6ac0
FEDORA-2021-a2a9d304b1 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a2a9d304b1
FEDORA-EPEL-2021-9abed9303c has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-9abed9303c
FEDORA-2021-a2a9d304b1 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-a2a9d304b1 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a2a9d304b1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2021-9abed9303c has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-9abed9303c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-e33feb6ac0 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-e33feb6ac0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e33feb6ac0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2021-9abed9303c has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-a2a9d304b1 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-e33feb6ac0 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.