Bug 1998878 - Review Request: golang-github-clbanning-mxj - Decode/encode XML to/from map[string]interface{} (or JSON)
Summary: Review Request: golang-github-clbanning-mxj - Decode/encode XML to/from map[s...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1998858
TreeView+ depends on / blocked
 
Reported: 2021-08-29 17:07 UTC by Fabian Affolter
Modified: 2023-02-22 20:35 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-02-22 20:35:14 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Fabian Affolter 2021-08-29 17:07:51 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-clbanning-mxj.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-clbanning-mxj-1.8.4-1.fc36.src.rpm

Description:
Decode / encode XML to/from map[string]interface{} (or JSON); extract values
with dot-notation paths and wildcards. Replaces x2j and j2x packages.

Fedora Account System Username: fab

Comment 1 Mikel Olasagasti Uranga 2022-03-09 22:08:42 UTC
I see https://src.fedoraproject.org/rpms/golang-github-clbanning-mxj already exists, but I can't find the BZ where it was reviewed.

The scm-request doesn't have any BZ attached: https://pagure.io/releng/fedora-scm-requests/issue/36662 which is strange for me, I thought it was a requirement.

https://src.fedoraproject.org/rpms/golang-github-hudl-fargo/blob/rawhide/f/golang-github-hudl-fargo.spec doesn't have any dep on golang-github-clbanning-mxj even if 1.4.0 should depend on it based on https://github.com/hudl/fargo/blob/master/go.mod

Also, hudl-fargo requires 1.8.4 while hugo requires 2.5.5 and there was a break with 2.0.0.

I need to review all these more to better understand what happened or what is required. If any of you can/want to check, please do.

Comment 2 W. Michael Petullo 2022-03-12 19:32:51 UTC
We might be able to put this one on hold, since golang-github-clbanning-mxj exists. I thought at first that we needed to package github.com/clbanning/mxj/v2 for Hugo, but I was able to patch Hugo to use github.com/clbanning/mxj instead (i.e., drop the "v2").

I would like to keep this open until after #1930952 is complete. If I can get the recent Hugo release working without this, then we might be able to close this request.


Note You need to log in before you can comment on or make changes to this bug.