Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1998920

Summary: libvirt should forbid to live update the acpi index
Product: Red Hat Enterprise Linux 9 Reporter: yalzhang <yalzhang>
Component: libvirtAssignee: Laine Stump <laine>
libvirt sub component: General QA Contact: yalzhang <yalzhang>
Status: CLOSED ERRATA Docs Contact:
Severity: low    
Priority: unspecified CC: jdenemar, jsuchane, virt-maint, xuzhang
Version: 9.0Keywords: AutomationTriaged, Triaged
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-7.8.0-1.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-17 12:45:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version: 7.8.0
Embargoed:

Description yalzhang@redhat.com 2021-08-30 01:31:41 UTC
Description of problem:
libvirt should forbid to live update the acpi index

Version-Release number of selected component (if applicable):
libvirt-7.6.0-2.module+el8.5.0+12219+a5ea13d2.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Start a vm with interface as beblow:
# virsh dumpxml pc | grep /interface -B8
    <interface type='network'>
      <mac address='52:54:00:ef:b7:55'/>
      <source network='default' portid='3b0d8475-e565-48d6-8915-0c85a87726a8' bridge='virbr0'/>
      <target dev='vnet1'/>
      <model type='virtio'/>
      <alias name='net0'/>
      <acpi index='50'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x0'/>
    </interface>

2. tried to live update the "acpi index", the virsh command says succeed.
# cat new_interface.xml
<interface type='network'>
      <mac address='52:54:00:ef:b7:55'/>
      <source network='default' portid='3b0d8475-e565-48d6-8915-0c85a87726a8' bridge='virbr0'/>
      <target dev='vnet1'/>
      <model type='virtio'/>
      <alias name='net0'/>
      <acpi index='400'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x0'/>
    </interface>
# virsh update-device pc new_interface.xml
Device updated successfully

3. But check the "acpi index" , it is not updated:
# virsh dumpxml pc | grep /interface -B8
    <interface type='network'>
      <mac address='52:54:00:ef:b7:55'/>
      <source network='default' portid='3b0d8475-e565-48d6-8915-0c85a87726a8' bridge='virbr0'/>
      <target dev='vnet1'/>
      <model type='virtio'/>
      <alias name='net0'/>
      <acpi index='50'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x0'/>
    </interface>

Actual results:
In step 2, the update-device returns succeed, but in fact no updates.

Expected results:
In step 2, it should return error like "update acpi index is not supported"

Additional info:

Comment 1 John Ferlan 2021-09-08 13:30:56 UTC
Bulk update: Move RHEL-AV bugs to RHEL9. If necessary to resolve in RHEL8, then clone to the current RHEL8 release.

Comment 2 Laine Stump 2021-09-10 01:31:36 UTC
Fix posted upstream:

  https://listman.redhat.com/archives/libvir-list/2021-September/msg00230.html

Comment 3 Laine Stump 2021-09-10 01:32:55 UTC
(BTW, as with most other "lack of validation" bugs, I *don't* think this is necessary to be resolved in RHEL8.)

Comment 4 Laine Stump 2021-09-30 02:42:19 UTC
These two patches were pushed upstream and will be in libvirt-7.8.0

commit cf916af4a1f029bfbebe7db0431bc42955479cca
Author: Laine Stump <laine>
Date:   Thu Sep 9 12:57:32 2021 -0400

    conf: reformat virDomainDefCompatibleDevice for upcoming additional check
    
commit ddba9f1dc945383428a312fbd7a6d370d16f2865 (active-bz1998920)
Author: Laine Stump <laine>
Date:   Thu Sep 9 13:02:56 2021 -0400

    conf: log error on attempts to modify ACPI index of active device

Comment 5 yalzhang@redhat.com 2021-10-08 07:08:16 UTC
Test on libvirt-7.8.0-1.el9.x86_64, the result is as expected.

Add, delete or change the acpi index when the vm is running, it will report error as:
# virsh update-device rhel-pc interface2.xml
error: Failed to update device from interface2.xml
error: operation forbidden: changing device 'acpi index' is not allowed

While it can work when the vm is shutdown, which is as expected.

Comment 8 yalzhang@redhat.com 2021-10-21 09:40:38 UTC
Test on libvirt-7.8.0-1.el9.x86_64, the result is as expected, set the bug to be verified.

Comment 10 errata-xmlrpc 2022-05-17 12:45:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: libvirt), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2390