Spec URL: https://download.copr.fedorainfracloud.org/results/gundersanne/golang-github-segmentio-ksuid/fedora-rawhide-x86_64/02674041-golang-github-segmentio-ksuid/golang-github-segmentio-ksuid.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/gundersanne/golang-github-segmentio-ksuid/fedora-rawhide-x86_64/02674041-golang-github-segmentio-ksuid/golang-github-segmentio-ksuid-1.0.4-1.fc36.src.rpm Description: K-Sortable Globally Unique IDs: 4bytes of time + 16 random bytes Fedora Account System Username: gundersanne
https://copr.fedorainfracloud.org/coprs/gundersanne/golang-github-segmentio-ksuid/build/2674041/ build succeeded on f33/f34/f35/f36.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. ===== MUST items ===== Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Expat License", "Unknown or generated". 15 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/golang-github- segmentio-ksuid/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-segmentio-ksuid-devel [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: golang-github-segmentio-ksuid-1.0.4-1.fc36.x86_64.rpm golang-github-segmentio-ksuid-devel-1.0.4-1.fc36.noarch.rpm golang-github-segmentio-ksuid-1.0.4-1.fc36.src.rpm golang-github-segmentio-ksuid.x86_64: E: statically-linked-binary /usr/bin/ksuid golang-github-segmentio-ksuid.x86_64: W: no-manual-page-for-binary ksuid golang-github-segmentio-ksuid-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/segmentio/ksuid/.goipath golang-github-segmentio-ksuid.src:55: W: macro-in-%changelog %autochangelog 3 packages and 0 specfiles checked; 1 errors, 3 warnings. Rpmlint (debuginfo) ------------------- Checking: golang-github-segmentio-ksuid-debuginfo-1.0.4-1.fc36.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/segmentio/ksuid/archive/v1.0.4/ksuid-1.0.4.tar.gz : CHECKSUM(SHA256) this package : b8cec5b4e99f84249b34d8932f866b7abe47eb5fa7ef7b2f15e0a3ab3d62b8f6 CHECKSUM(SHA256) upstream package : b8cec5b4e99f84249b34d8932f866b7abe47eb5fa7ef7b2f15e0a3ab3d62b8f6 Requires -------- golang-github-segmentio-ksuid (rpmlib, GLIBC filtered): golang-github-segmentio-ksuid-devel (rpmlib, GLIBC filtered): go-filesystem Provides -------- golang-github-segmentio-ksuid: golang-github-segmentio-ksuid golang-github-segmentio-ksuid(x86-64) golang-github-segmentio-ksuid-devel: golang(github.com/segmentio/ksuid) golang-github-segmentio-ksuid-devel golang-ipath(github.com/segmentio/ksuid) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name golang-github-segmentio-ksuid --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: fonts, R, Haskell, Ocaml, Java, C/C++, SugarActivity, PHP, Python, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Ugh, hit enter after I pasted but before I could add comments. 🤦🏻♂️ Still checking this one over.
This package is approved. ✅ - Correct license included. - Followed go2rpm standards. - Build well on aarch64/ppc64le/x86_64 F35/F36.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-segmentio-ksuid
https://bodhi.fedoraproject.org/updates/FEDORA-2021-821faf0c44 landed in rawhide; closing.