Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1999167

Summary: [SPICE] RFE: Cannot change CD with ISO in RHV Data domain
Product: Red Hat Enterprise Virtualization Manager Reporter: Uri Lublin <uril>
Component: virt-viewerAssignee: Uri Lublin <uril>
Status: CLOSED ERRATA QA Contact: Nisim Simsolo <nsimsolo>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.4.8CC: apinnick, berrange, dfodor, emarcus, lsurette, lsvaty, mavital, nsimsolo, tpelka, virt-maint
Target Milestone: ovirt-4.5.1Keywords: FutureFeature, ZStream
Target Release: 4.5.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: virt-viewer-9.0-13.el9ev Doc Type: Enhancement
Doc Text:
Spice console remote-viewer now allows the Change CD command to work with data domains if no ISO domains exist. If there are multiple data domains, remote-viewer selects the first data domain on the list of available domains.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2022-07-14 12:23:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Spice RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Uri Lublin 2021-08-30 15:09:41 UTC 
This bug was initially created as a copy of Bug #1835640

I am copying this bug because: 



Description of problem:
When using remote-viewer with RHV 4.3 in a SPICE session, the option "Change CD" fails if the ISOs are in a data storage domain.

Version-Release number of selected component (if applicable):
virt-viewer-7.0-9.el8.x86_64
RHV 4.3.9


How reproducible:
Always

Steps to Reproduce:
1. RHV 4.3 setup with no ISO storage domain. All the ISOs are in a data storage domain.
2. Connect to a SPICE console:
# remote-viewer --verbose --debug --spice-debug console.vv

3. Click on File -> Change CD

Actual results:
I get the error: "Could not find ISO file collection"

Expected results:
To be able to choose ISO from a data storage domain

Additional info:

(remote-viewer:8136): virt-viewer-DEBUG: 10:43:24.277: Start fetching iso file collection

(remote-viewer:8136): libgovirt-CRITICAL **: 10:43:24.470: file ovirt-utils.c: line 290 (ovirt_utils_genum_get_value): should not be reached

(remote-viewer:8136): libgovirt-CRITICAL **: 10:43:24.470: ovirt_resource_set_description_from_xml: assertion 'desc_node->content != NULL' failed

(remote-viewer:8136): libgovirt-CRITICAL **: 10:43:24.470: file ovirt-utils.c: line 290 (ovirt_utils_genum_get_value): should not be reached

(remote-viewer:8136): libgovirt-CRITICAL **: 10:43:24.470: ovirt_resource_set_description_from_xml: assertion 'desc_node->content != NULL' failed
(remote-viewer:8136): virt-viewer-DEBUG: 10:43:24.470: Storage domain 'hosted_storage' type is not ISO
(remote-viewer:8136): virt-viewer-DEBUG: 10:43:24.470: Storage domain 'hosted_storage' is not valid
(remote-viewer:8136): virt-viewer-DEBUG: 10:43:24.470: Storage domain 'data' type is not ISO
(remote-viewer:8136): virt-viewer-DEBUG: 10:43:24.470: Storage domain 'data' is not valid
(remote-viewer:8136): virt-viewer-DEBUG: 10:43:24.470: Could not find valid ISO storage domain
(remote-viewer:8136): virt-viewer-DEBUG: 10:43:24.470: Error fetching ISO names: Could not find valid ISO storage domain
Comment 1 Uri Lublin 2021-08-30 15:13:37 UTC 
Use the same patch as in bug 1835640 and bug 1918877

Note that with this patch, ISO domain is still the default for ISO images.
If an ISO domain exists, ISO images from a Data domain are not shown.
If an ISO domain does not exists, ISO images from a Data domain are shown
and can be shared with the VM.
Comment 3 Sandro Bonazzola 2022-03-03 17:35:14 UTC 
Uri, any update on this BZ?
Comment 4 Uri Lublin 2022-03-10 10:32:45 UTC 
Thanks for the reminder. It would be nice to add this capability
Comment 5 Sandro Bonazzola 2022-03-25 15:18:22 UTC 
Uri, I'm not sure I understood what's the request.
Bug #1835640 is closed errata on virt-viewer-9.0-11.el8.
I would assume that there's nothing to be done on RHV side right?
Comment 6 Uri Lublin 2022-03-27 11:58:15 UTC 
This bug is for adding this capability to virt-viewer-rhv (el9ev).
Comment 10 Nisim Simsolo 2022-06-16 13:37:52 UTC 
Verified:
virt-viewer-rhv-9.0-13.el9ev.x86_64
ovirt-engine-4.5.1.1-0.14.el8ev
vdsm-4.50.1.2-1.el8ev.x86_64
qemu-kvm-6.2.0-11.module+el8.6.0+15489+bc23efef.1.x86_64
libvirt-8.0.0-5.2.module+el8.6.0+15256+3a0914fe.x86_64

Verification scenario:
1. Add some ISO files to data domain.
2. Remove ISO domain, attach CD to VM and select one of data domain ISO files, set console graphics protocol to SPICE. 
3. Run VM. 
   Verify VM is running with attached CD ISO file.
4. Change CD from SPICE console to a different ISO domain.
   Verify CD ISO file changed accordingly.
5. Repeat step 4 few more times.
6. Power off VM. change graphics protocol to VNC and repeat steps 3-5.
7. Power off VM. change graphics protocol to SPICE + VNC and repeat steps 3-5.
Comment 21 errata-xmlrpc 2022-07-14 12:23:20 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (SPICE client enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:5587