Bug 1999328 - Review Request: perl-Devel-MAT-Dumper - Write a heap dump file for later analysis
Summary: Review Request: perl-Devel-MAT-Dumper - Write a heap dump file for later anal...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1999332
TreeView+ depends on / blocked
 
Reported: 2021-08-30 22:11 UTC by Emmanuel Seyman
Modified: 2021-09-02 11:42 UTC (History)
2 users (show)

Fixed In Version: perl-Devel-MAT-Dumper-0.42-2.fc36
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-09-02 11:42:38 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2021-08-30 22:11:49 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Devel-MAT-Dumper/perl-Devel-MAT-Dumper.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Devel-MAT-Dumper/perl-Devel-MAT-Dumper-0.42-1.fc34.src.rpm
Description:
This module provides the memory-dumping function that creates a heap dump
file which can later be read by Devel::MAT::Dumpfile. It provides a single
function which is not exported, which writes a file to the given path.

Fedora Account System Username: eseyman
Rpmlint Output: 
perl-Devel-MAT-Dumper.src: W: spelling-error %description -l en_US Dumpfile -> Dump file, Dump-file, Dumpling
1 packages and 1 specfiles checked; 0 errors, 1 warnings.

Comment 1 Jitka Plesnikova 2021-08-31 13:16:41 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Devel-MAT-Dumper-0.42-1.fc36.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.3.4)(64bit)
      1 libc.so.6(GLIBC_2.34)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 perl(File::Basename)
      1 perl(File::Spec)
      1 perl(:MODULE_COMPAT_5.34.0)
      1 perl(POSIX)
      1 perl(strict)
      1 perl(warnings)
      1 perl(XSLoader)
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-Devel-MAT-Dumper-0.42-1.fc36.x86_64.rpm | sort | uniq -c
      1 perl(Devel::MAT::Dumper) = 0.42
      1 perl-Devel-MAT-Dumper = 0.42-1.fc36
      1 perl(Devel::MAT::Dumper::Helper) = 0.42 
      1 perl-Devel-MAT-Dumper(x86-64) = 0.42-1.fc36
Binary provides are Ok.

$ rpmlint ./perl-Devel-MAT-Dumper*
perl-Devel-MAT-Dumper.src: W: spelling-error %description -l en_US Dumpfile -> Dump file, Dump-file, Dumpling
perl-Devel-MAT-Dumper.x86_64: W: spelling-error %description -l en_US Dumpfile -> Dump file, Dump-file, Dumpling
perl-Devel-MAT-Dumper.x86_64: E: zero-length /usr/lib64/perl5/vendor_perl/auto/Devel/MAT/Dumper/Dumper.bs
2 packages and 1 specfiles checked; 1 errors, 2 warnings.

FIX: *.bs file should be removed in section %install
  find $RPM_BUILD_ROOT -type f -name '*.bs' -empty -delete

BuildRequires are almost ok
FIX: Please add perl-devel and gcc, because it is XS package

Please correct all 'FIX' items.

Otherwise the package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

Comment 2 Emmanuel Seyman 2021-09-01 05:21:17 UTC
(In reply to Jitka Plesnikova from comment #1):
>
> FIX: *.bs file should be removed in section %install
>   find $RPM_BUILD_ROOT -type f -name '*.bs' -empty -delete

Done (and findutils added to BuildRequires).

> BuildRequires are almost ok
> FIX: Please add perl-devel and gcc, because it is XS package

Done.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Devel-MAT-Dumper/perl-Devel-MAT-Dumper.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Devel-MAT-Dumper/perl-Devel-MAT-Dumper-0.42-2.fc34.src.rpm

Repo requested (https://pagure.io/releng/fedora-scm-requests/issue/36643).

Comment 3 Tomas Hrcka 2021-09-01 10:09:46 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Devel-MAT-Dumper

Comment 4 Emmanuel Seyman 2021-09-02 11:42:38 UTC
Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1826810


Note You need to log in before you can comment on or make changes to this bug.