Bug 1999471 - [F36FTBFS]: msitools fails to build generated msi.c file with reference to non-existent struct fields
Summary: [F36FTBFS]: msitools fails to build generated msi.c file with reference to no...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: vala
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Felipe Borges
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1936597 F36FTBFS
TreeView+ depends on / blocked
 
Reported: 2021-08-31 08:06 UTC by Ondrej Dubaj
Modified: 2021-09-01 19:26 UTC (History)
9 users (show)

Fixed In Version: vala-0.53.1-2.fc36
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-08-31 17:59:50 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Ondrej Dubaj 2021-08-31 08:06:31 UTC
Your package fails to build with the newest autoconf-2.71, which was part of a recent wide Fedora change. More information about Fedora autoconf Change available here: https://fedoraproject.org/wiki/Changes/Autoconf_271#How_To_Test. The easiest way to reproduce the problem is to execute a fedora scratch-build on your package. Thank you for cooperation!

Comment 1 Daniel Berrangé 2021-08-31 11:28:59 UTC
Where is the koji log showing the failure ?    msitools uses meson and doesn't have any direct dep on autoconf, so this bug report description feels dubious

Comment 2 Ondrej Dubaj 2021-08-31 12:04:12 UTC
Koji logs:

https://koji.fedoraproject.org/koji/taskinfo?taskID=74842235

The autoconf must not be the reason for FTBFS, but it can be. The tracker was automatically created, details were not investigated.

Comment 3 Daniel Berrangé 2021-08-31 12:38:20 UTC
Seems to be something majorly wrong with the generated code referencing struct fields that don't exist:

FAILED: tools/wixl/wixl.p/meson-generated_msi.c.o 
gcc -Itools/wixl/wixl.p -Itools/wixl -I../tools/wixl -I. -I.. -Iinclude -I../include -Ilibmsi -I../libmsi -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/libgsf-1 -I/usr/include/libxml2 -I/usr/include/libgcab-1.0 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -w -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m32 -march=i686 -mtune=generic -msse2 -mfpmath=sse -mstackrealign -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -pthread -include /builddir/build/BUILD/msitools-0.101.32-aeb8/redhat-linux-build/config.h -MD -MQ tools/wixl/wixl.p/meson-generated_msi.c.o -MF tools/wixl/wixl.p/meson-generated_msi.c.o.d -o tools/wixl/wixl.p/meson-generated_msi.c.o -c tools/wixl/wixl.p/msi.c
tools/wixl/wixl.p/msi.c: In function ‘wixl_msi_table_file_hash_class_init’:
tools/wixl/wixl.p/msi.c:1606:24: error: ‘WixlMsiTableFileHashClass’ {aka ‘struct _WixlMsiTableFileHashClass’} has no member named ‘name’
 1606 |         _g_free0 (klass->name);
      |                        ^~
tools/wixl/wixl.p/msi.c:37:24: note: in definition of macro ‘_g_free0’
   37 | #define _g_free0(var) (var = (g_free (var), NULL))
      |                        ^~~
tools/wixl/wixl.p/msi.c:1606:24: error: ‘WixlMsiTableFileHashClass’ {aka ‘struct _WixlMsiTableFileHashClass’} has no member named ‘name’
 1606 |         _g_free0 (klass->name);
      |                        ^~
tools/wixl/wixl.p/msi.c:37:39: note: in definition of macro ‘_g_free0’
   37 | #define _g_free0(var) (var = (g_free (var), NULL))
      |                                       ^~~
tools/wixl/wixl.p/msi.c:1607:14: error: ‘WixlMsiTableFileHashClass’ {aka ‘struct _WixlMsiTableFileHashClass’} has no member named ‘name’
 1607 |         klass->name = _tmp0_;
      |              ^~
tools/wixl/wixl.p/msi.c:1611:24: error: ‘WixlMsiTableFileHashClass’ {aka ‘struct _WixlMsiTableFileHashClass’} has no member named ‘sql_create’
 1611 |         _g_free0 (klass->sql_create);
      |                        ^~
tools/wixl/wixl.p/msi.c:37:24: note: in definition of macro ‘_g_free0’
   37 | #define _g_free0(var) (var = (g_free (var), NULL))
      |                        ^~~

This will need Marc-Andre's input I think.

Comment 4 Marc-Andre Lureau 2021-08-31 13:09:37 UTC
I opened https://gitlab.gnome.org/GNOME/vala/-/issues/1221

Comment 5 Marc-Andre Lureau 2021-08-31 16:00:33 UTC
Fixed upstream https://gitlab.gnome.org/GNOME/vala/-/commit/c0121583cee85656862516e689f8b63555a0ff20
moving to vala, preparing a PR

Comment 6 Marc-Andre Lureau 2021-08-31 16:07:32 UTC
https://src.fedoraproject.org/rpms/vala/pull-request/2

Comment 7 Fedora Update System 2021-08-31 17:57:40 UTC
FEDORA-2021-5e75e23bac has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2021-5e75e23bac

Comment 8 Fedora Update System 2021-08-31 17:59:50 UTC
FEDORA-2021-5e75e23bac has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2021-08-31 18:17:02 UTC
FEDORA-2021-f8c6366270 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f8c6366270

Comment 10 Fedora Update System 2021-09-01 19:26:15 UTC
FEDORA-2021-f8c6366270 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-f8c6366270`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-f8c6366270

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.


Note You need to log in before you can comment on or make changes to this bug.