Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1999476

Summary: [RHEL-9.0] [covscan] gssd/krb5_util.c fix the newly introduced defects invalid_type and incompatible_cast
Product: Red Hat Enterprise Linux 9 Reporter: Yongcheng Yang <yoyang>
Component: nfs-utilsAssignee: Steve Dickson <steved>
Status: CLOSED ERRATA QA Contact: Yongcheng Yang <yoyang>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.0CC: steved, xzhou
Target Milestone: rcKeywords: Patch, Triaged
Target Release: ---Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nfs-utils-2.5.4-7.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1988283 Environment:
Last Closed: 2022-05-17 16:01:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Deadline: 2022-01-31   

Description Yongcheng Yang 2021-08-31 08:06:55 UTC
This "Unsorted" failures also exist in rhel9 since nfs-utils updated beyond version 2.5.4-0.el9 and have not been fixed now.

https://cov01.lab.eng.brq.redhat.com/covscanhub/waiving/80324/217383/#defects
What's more, there're many other defects (in files other than gssd/krb5_utils.c).

+++ This bug was initially created as a clone of Bug #1988283 +++

Description of problem:
Then new version nfs-utils-2.3.3-44.el8 via bz1961056 introduces 2 more defects which looks like need to be fix. Please help have a look and check them.

https://cov01.lab.eng.brq.redhat.com/covscanhub/waiving/76192/206104/#defects

The first one:
 1. nfs-utils-2.3.3/utils/gssd/krb5_util.c:651: invalid_type: Argument "outhost" to format specifier "%0lx" was expected to have type "unsigned long" but has type "char *". 
 1. nfs-utils-2.3.3/utils/gssd/krb5_util.c:650: missing_argument: No argument for format specifier "%s". 

#   648|   
#   649|   	if (get_verbosity() && strcmp(inhost, outhost))
#   650|-> 		printerr(1, "%s(0x%0lx): inhost '%s' different than outhost'%s'\n", 
#   651|->   			inhost, outhost);
#   652|   


The second one:
 1. nfs-utils-2.3.3/utils/gssd/krb5_util.c:400: incompatible_cast: Pointer "&ple->endtime" points to an object whose effective type is "int" (32 bits, signed) but is dereferenced as a wider "long" (64 bits, signed). This may lead to memory corruption. 

#   398|   	if (ple->ccname && ple->endtime > now && !nocache) {
#   399|   		printerr(3, "%s(0x%lx): Credentials in CC '%s' are good until %s",
#   400|-> 			 __func__, tid, ple->ccname, ctime((time_t *)&ple->endtime));
#   401|   		code = 0;
#   402|   		pthread_mutex_unlock(&ple_lock);


Version-Release number of selected component (if applicable):
since nfs-utils-2.5.4-0.el9

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Steve Dickson 2022-01-11 17:09:54 UTC
commit cfe41d6f06af0e7744c1ca30503f93d28aca4d8b
Author: NeilBrown <neilb>
Date:   Tue Sep 21 12:47:10 2021 -0400

    gssd: fix crash in debug message.

Comment 4 Yongcheng Yang 2022-01-17 01:33:51 UTC
This defect has been fixed as Covscan test against nfs-utils-2.5.4-8.el9 shows:

https://cov01.lab.eng.brq.redhat.com/covscanhub/waiving/86048/232376/fixed/#defects

Comment 6 errata-xmlrpc 2022-05-17 16:01:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: nfs-utils), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:4028