Spec URL: https://raw.githubusercontent.com/dulsi/thrust/master/inertiablast.spec SRPM URL: http://identicalsoftware.com/inertiablast/inertiablast-0.91-1.fc34.src.rpm Description: The rebellion captured several warships but lack the energy pod to power the ships. You are part of a risky expedition to steal the energy pods. Defense systems will attempt to stop you. The energy pods are often stored in tunnels making them hard to retrieve. The massive weight of the pod increases the difficultly in getting out. Inertia Blast is a remake of an C64 game called Thrust. Fedora Account System Username: dulsi
> License: GPLv2+ The README mentions some graphics which are under different licences, namely CC0, CC-BY-3.0 and (CC-BY-3.0 or GPLv3). These should also be included here. > BuildRequires: gcc-c++ Is this correct? Looking at the source, it's C, not C++. Since gcc-c++ pulls in gcc, the RPM builds fine, but the point stands. > files > %{_datadir}/icons/hicolor/*/apps/inertiablast.png > %{_metainfodir}/%{name}.metainfo.xml The list of files mixes "inertiablast" and "%{name}". Please choose one and stick to it. Also, the upstream source archive contains a man page, which is not included in the RPM (possibly because CMakeLists.txt doesn't specify it as a file to be installed). Consider manually copying it into the buildroot.
Spec URL: https://raw.githubusercontent.com/dulsi/thrust/master/inertiablast.spec SRPM URL: http://identicalsoftware.com/inertiablast/inertiablast-0.91-2.fc34.src.rpm (In reply to Artur Frenszek-Iwicki from comment #1) > > BuildRequires: gcc-c++ > Is this correct? Looking at the source, it's C, not C++. Since gcc-c++ pulls > in gcc, the RPM builds fine, but the point stands. cmake tries to detect c++ compiler even though it is not used. It fails if no c++ compiler is found. I don't know of a way to stop that. All other comments have been addressed.
In CMakeLists.txt: > Project (inertiablast) Try patching this to: > Project (inertiablast C) Per CMake's docs: > By default C and CXX are enabled if no language options are given. https://cmake.org/cmake/help/latest/command/project.html
Spec URL: https://raw.githubusercontent.com/dulsi/thrust/master/inertiablast.spec SRPM URL: http://identicalsoftware.com/inertiablast/inertiablast-0.92-1.fc34.src.rpm Thanks for the help.
Building in Mock failed: > CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:849 (message): > None of the required 'sdl2' found > Call Stack (most recent call first): > CMakeLists.txt:11 (pkg_search_module) > -- Checking for one of the modules 'SDL2_mixer' > CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:849 (message): > None of the required 'SDL2_mixer' found In the spec, you have: > BuildRequires: SDL-devel > BuildRequires: SDL_mixer-devel These are for SDL1, whereas the game uses SDL2. Change to: > BuildRequires: SDL2-devel > BuildRequires: SDL2_mixer-devel
Spec URL: https://raw.githubusercontent.com/dulsi/thrust/master/inertiablast.spec SRPM URL: http://identicalsoftware.com/inertiablast/inertiablast-0.92-2.fc34.src.rpm
> License: GPLv2+ and CC-BY-SA The README says some assets are licensed under CC-BY or GPL 3.0, CC-BY, CC0. License field should hence be "GPLv2+ and CC0 and CC-BY and (CC-BY or GPLv3)". > E: incorrect-fsf-address /usr/share/licenses/inertiablast/COPYING Please fix this in the source tarball (since you're the upstream as well). Apart from these two issues, package looks good. Approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. NOTE: License field is "GPLv2+ and CC-BY-SA" The README says some assets are licensed under: - CC-BY or GPL 3.0 - CC-BY - CC0 License field should hence be "GPLv2+ and CC0 and CC-BY and (CC-BY or GPLv3)" [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. NOTE: Successful scratch build in koji can be found at: https://koji.fedoraproject.org/koji/taskinfo?taskID=75657093 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: inertiablast-0.92-2.fc36.x86_64.rpm inertiablast-debuginfo-0.92-2.fc36.x86_64.rpm inertiablast-debugsource-0.92-2.fc36.x86_64.rpm inertiablast-0.92-2.fc36.src.rpm inertiablast.x86_64: E: incorrect-fsf-address /usr/share/licenses/inertiablast/COPYING 4 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (debuginfo) ------------------- Checking: inertiablast-debuginfo-0.92-2.fc36.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- http://identicalsoftware.com/inertiablast//inertiablast-0.92.tgz : CHECKSUM(SHA256) this package : 4515958487e3b9da5e45dc637ffd0c9c7901db6209db7a10e845ce27c117a74e CHECKSUM(SHA256) upstream package : 4515958487e3b9da5e45dc637ffd0c9c7901db6209db7a10e845ce27c117a74e Requires -------- inertiablast (rpmlib, GLIBC filtered): hicolor-icon-theme libSDL2-2.0.so.0()(64bit) libSDL2_mixer-2.0.so.0()(64bit) libc.so.6()(64bit) libgamerzilla.so.0()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) inertiablast-debuginfo (rpmlib, GLIBC filtered): inertiablast-debugsource (rpmlib, GLIBC filtered): Provides -------- inertiablast: application() application(inertiablast.desktop) inertiablast inertiablast(x86-64) metainfo() metainfo(inertiablast.metainfo.xml) inertiablast-debuginfo: debuginfo(build-id) inertiablast-debuginfo inertiablast-debuginfo(x86-64) inertiablast-debugsource: inertiablast-debugsource inertiablast-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2001378 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Java, PHP, SugarActivity, Python, Ocaml, fonts, Haskell, Perl, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/inertiablast