Bug 2001636 - [RFE] libguestfs: Add detection of AlmaLinux and CloudLinux
Summary: [RFE] libguestfs: Add detection of AlmaLinux and CloudLinux
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact:
URL:
Whiteboard:
: 2001635 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-09-06 15:46 UTC by sasha121196
Modified: 2021-09-07 20:34 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-09-07 16:34:49 UTC
Embargoed:

Attachments (Terms of Use)
Add AlmaLinux and CloudLinux detection (231 bytes, text/plain)
2021-09-06 15:46 UTC, sasha121196 		no flags Details
View All

Description sasha121196 2021-09-06 15:46:52 UTC 
Created attachment 1820916 [details]
Add AlmaLinux and CloudLinux detection

Description of problem:


Automatic detection of the distribution doesn't work for AlmaLinux and CloudLinux, so for building you have to specify --with-distro = REDHAT
Comment 1 Richard W.M. Jones 2021-09-06 16:03:58 UTC 
https://github.com/libguestfs/libguestfs/commit/4e02c1394165d9f894c2bcf16fb66187911390ee

BTW if you prefer you can just email patches to libguestfs
Comment 2 Richard W.M. Jones 2021-09-06 17:23:04 UTC 
*** Bug 2001635 has been marked as a duplicate of this bug. ***
Comment 3 sasha121196 2021-09-07 12:33:37 UTC 

(In reply to Richard W.M. Jones from comment #1)
> https://github.com/libguestfs/libguestfs/commit/
> 4e02c1394165d9f894c2bcf16fb66187911390ee
> 
> BTW if you prefer you can just email patches to libguestfs


Thank you for the quick reply. Could you please add this patch to these branches too?
rhel-8.4.0
rhel-8.5.0
rhel-9.0.0
stable-1.40
stable-1.42
stable-1.44
Comment 4 Richard W.M. Jones 2021-09-07 12:42:09 UTC 
Not the RHEL ones because those are Red Hat's "private" branches.

I can do a libguestfs 1.44 release containing this and other
fixes soon.

We wouldn't normally backport enablement patches to earlier branches,
only security issues and serious bugs.  Can Alma/Cloud not carry
downstream patches?
Comment 5 sasha121196 2021-09-07 16:32:38 UTC 
OK, Understood! Thank you for adding patch to the next version of stable-1.44 branch.
Comment 6 Richard W.M. Jones 2021-09-07 20:34:53 UTC 
This is included in 1.44.2:
https://download.libguestfs.org/1.44-stable/
Note You need to log in before you can comment on or make changes to this bug.