Bug 2001902 - %{ansible_collection_url} macro is unexpanded in a source package
Summary: %{ansible_collection_url} macro is unexpanded in a source package
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ansible-pcp
Version: 34
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nathan Scott
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-09-07 12:18 UTC by Petr Pisar
Modified: 2021-11-22 01:13 UTC (History)
3 users (show)

Fixed In Version: ansible-pcp-2.2.2-1.fc35 ansible-pcp-2.2.2-1.fc34 ansible-pcp-2.2.2-1.fc33
Clone Of:
Environment:
Last Closed: 2021-11-13 01:06:58 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Petr Pisar 2021-09-07 12:18:21 UTC
A user reported <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/HCJA63UQ4GS7SFX22W2YR7OKRK5WNJYU/> that Fedora Update Notification for ansible-pcp-2.0.3-1.fc33 <https://lists.fedoraproject.org/archives/list/package-announce@lists.fedoraproject.org/message/WXTHUIAFXNBD37OWHLL5XA24GZZBLLMA/> contains an unexpanded RPM macro in URL value:

--------------------------------------------------------------------------------
Fedora Update Notification
FEDORA-2020-fa6dea3553
2020-11-27 01:20:50.552660
--------------------------------------------------------------------------------

Name        : ansible-pcp
Product     : Fedora 33
Version     : 2.0.3
Release     : 1.fc33
URL         : %{ansible_collection_url}
Summary     : Ansible Metric collection for Performance Co-Pilot

That's because source packages are built in a SRPM build root where "ansible" package, which defined the macro, cannot be installed.

This can be reproduced with:

# dnf remove ansible
$ fedpkg srpm
$ rpm -q -p ansible-pcp-*.src.rpm --qf '%{URL}\n'
%{ansible_collection_url}

Please do not use macros in RPM tags which go to source package RPM metadata and which are not available in the SRPM build root.

You can either replace the macro with a literal value in ansible-pcp.spec. Or you can move the macro definition to a dedicated package under /usr/lib/rpm/macros.d/macros.ansible-srpm file and make it required by redhat-rpm-config.

Comment 1 Nathan Scott 2021-09-09 05:30:54 UTC
Thanks Petr, I'll get that fixed up with the next update.

Comment 2 Ben Cotton 2021-11-04 13:44:17 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Ben Cotton 2021-11-04 14:13:48 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 Ben Cotton 2021-11-04 15:11:25 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Fedora Update System 2021-11-12 04:49:41 UTC
FEDORA-2021-94d7cd302e has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-94d7cd302e

Comment 6 Fedora Update System 2021-11-12 04:49:42 UTC
FEDORA-2021-e3a80a09f6 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e3a80a09f6

Comment 7 Fedora Update System 2021-11-12 04:49:43 UTC
FEDORA-2021-cf88ee5240 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-cf88ee5240

Comment 8 Fedora Update System 2021-11-13 01:06:58 UTC
FEDORA-2021-cf88ee5240 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2021-11-14 01:58:50 UTC
FEDORA-2021-94d7cd302e has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-94d7cd302e`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-94d7cd302e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-11-14 02:26:35 UTC
FEDORA-2021-e3a80a09f6 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-e3a80a09f6`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e3a80a09f6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2021-11-22 01:10:03 UTC
FEDORA-2021-e3a80a09f6 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2021-11-22 01:13:11 UTC
FEDORA-2021-94d7cd302e has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.