Bug 2003362 - eigen_mma.patch not effective because -devel subpackage is noarch
Summary: eigen_mma.patch not effective because -devel subpackage is noarch
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: eigen3
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rich Mattes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2001592
TreeView+ depends on / blocked
 
Reported: 2021-09-11 14:27 UTC by Mamoru TASAKA
Modified: 2021-09-12 04:59 UTC (History)
2 users (show)

Fixed In Version: eigen3-3.4.0-3.fc36
Clone Of:
Environment:
Last Closed: 2021-09-12 04:59:38 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Mamoru TASAKA 2021-09-11 14:27:19 UTC
Description of problem:
eigen3-3.4.0-2.fc36 introduces eigen_mma.patch on ppc64le to avoid gcc issue bug 1996330 :
 https://src.fedoraproject.org/rpms/eigen3/c/0f45292bb14babd384f29c273ee5a76c2238b07a?branch=rawhide

But since -devel subpackage is currently marked as noarch, even if on koji -devel subpackage is built on every arch, it looks like finally only "one" -devel subpacakge is chose from some random arch, see:

https://koji.fedoraproject.org/koji/buildinfo?buildID=1823310 : there is only "one" -devel noarch rpm

and currently on chosen -devel rpm, eigen_mma.patch is not applied.


Version-Release number of selected component (if applicable):
eigen3-3.4.0-2.fc36

How reproducible:
100%

Steps to Reproduce:
1. build some package requiring eigen3-devel on ppc64le, e.g. bug 2001592
2. see result
3.

Actual results:
Even if eigen3-3.4.0-2.fc36 is used, using eigen3-devel still sees the issue of bug 1996330
https://koji.fedoraproject.org/koji/taskinfo?taskID=75057052

Expected results:
bug 1996330 issue disappears


Additional info:
So -devel subpackage is marked as noarch,  "%ifarch ppc64le" must be removed from eigen3.spec.
One possible solution is to add some arch dependent ifdefs on patch, e.g.

----------------------------------------------
#ifdef __PPC64__
#define EIGEN_ALTIVEC_DISABLE_MMA
#endif
----------------------------------------------

(I've checked that on ppc64le, __PPC64__ is actually defined))

Comment 1 Rich Mattes 2021-09-12 02:21:10 UTC
Thanks for the report.  I've updated the spec to apply the patch unconditionally, and updated the patch with the ifdef guards you suggested.  It's in the buildroot now.

I did a test build with PCL, it looks like the patch is working correctly now.

Comment 2 Mamoru TASAKA 2021-09-12 04:57:26 UTC
Looks good, votca-csg now builds, thank you.
https://koji.fedoraproject.org/koji/taskinfo?taskID=75532483


Note You need to log in before you can comment on or make changes to this bug.