Bug 2004265 - keyboard layouts should use short country names (was: official name for Taiwan is wrong)
Summary: keyboard layouts should use short country names (was: official name for Taiwa...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: rawhide
Hardware: All
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mike FABIAN
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-09-14 20:24 UTC by Julian Groß
Modified: 2024-12-12 10:36 UTC (History)
20 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-12-12 10:36:13 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
anaconda-tw-kbd-en.png (54.02 KB, image/png)
2022-05-25 10:48 UTC, Jens Petersen
no flags Details
kde live fedora 41 (102.77 KB, image/png)
2024-12-12 10:36 UTC, Katerina Koukiou
no flags Details

Description Julian Groß 2021-09-14 20:24:37 UTC
Description of problem:
The "official name" of the country on Taiwan is wrong. It states "Province of China", which is obviously not its official name. No country would call itself "Province" of another country. The official name is "Republic of China".

Some sources:
- Official government website https://www.taiwan.gov.tw by the RoC Ministry of Foreign Affairs
- You can ask any person living on the Island.
- As an IT person, you might have some hardware labeled "Made in RoC".
- The Hong Kong and the Taiwanese locale both have "中華民國" as a translation, which means "Republic of China".

Comment 1 Parag Nemade 2021-09-15 01:11:35 UTC
This is an upstream issue. Fedora only package what upstream provided. I request to report this issue to upstream project -> https://salsa.debian.org/iso-codes-team/iso-codes/-/issues

Comment 2 Hagen 2022-05-24 05:37:08 UTC
@Parag - when installing fedora and adding a keyboard, Taiwan states 'Province of China' which is obviously incorrect, however none of the ISO codes in the linked repository appear to have 'Province of China', so this must be coming from somewhere else.

Comment 4 Mamoru TASAKA 2022-05-24 07:14:22 UTC
Actually ISO-3166-1 defines "Short name" of Taiwan as "TAIWAN, PROVINCE OF CHINA" :

https://www.iso.org/obp/ui/#iso:code:3166:TW

although it seems Taiwan wants to change this.

Comment 5 Jens Petersen 2022-05-24 08:51:48 UTC
Ya, seems strange to me: the short name should clearly be just "Taiwan".
Getting consensus on the long name is another story, of course...

Comment 6 Jens Petersen 2022-05-24 08:54:52 UTC
(In reply to Parag Nemade from comment #1)
> I request to report this issue to upstream project ->
> https://salsa.debian.org/iso-codes-team/iso-codes/-/issues

Also surprised that noone seems to have reported any issue for Taiwan.

Comment 7 Jens Petersen 2022-05-24 08:59:44 UTC
Actually sorry iso-codes is okay: so the problem is usage of official_name perhaps in this context.

I mean using the full official long form country names just for keyboard layouts seems rather overkill to me.

Comment 8 Jens Petersen 2022-05-24 09:12:25 UTC
(In reply to Hagen from comment #2)
> @Parag - when installing fedora and adding a keyboard, Taiwan states
> 'Province of China' which is obviously incorrect, however none of the ISO
> codes in the linked repository appear to have 'Province of China', so this
> must be coming from somewhere else.

If I am not mistaken this is actually coming from xkeyboard-config.

Since there is no context for the original report, I would suggest
to move this bug there - or file a separate bug if there was some
other context intended here.

Comment 9 Hagen 2022-05-25 02:22:57 UTC
I only commented in here because it seemed like this might have been the same issue. If they are two separate issues then I don't mind raising a bug.

I'm also unsure if the issue is different between the DE: Gnome / KDE Plasma, as I'm using KDE Plasma and noticed this (again) when doing a clean install, and it always bothers me when I add the keyboard.

Comment 10 Parag Nemade 2022-05-25 02:28:50 UTC
I appreciate if someone shares a steps to reproduce this issue or screenshot where they see wrong text. It will be easy for all of us to understand what exactly we are discussing here and what text need to be changed.

Comment 11 Parag Nemade 2022-05-25 02:49:07 UTC
Also, I am tired of attempting to create upstream account, not even working via authenticating via my gitlab account name. Will keep trying again.

Comment 12 Julian Groß 2022-05-25 05:30:54 UTC
(In reply to Jens Petersen from comment #6)

> Also surprised that noone seems to have reported any issue for Taiwan.

Linux isn't exactly a big thing in Taiwan, and the translator actually changed the name when translating to Traditional Chinese.
https://salsa.debian.org/iso-codes-team/iso-codes/-/merge_requests/24

Comment 13 Mike FABIAN 2022-05-25 09:40:59 UTC
My guess is that anaconda gets this by using python3-pycountry which gets its data from ico-codes:

$ python3
Python 3.10.4 (main, Mar 25 2022, 00:00:00) [GCC 12.0.1 20220308 (Red Hat 12.0.1-0)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pycountry
>>> pycountry.countries.get(alpha_2='TW')
Country(alpha_2='TW', alpha_3='TWN', common_name='Taiwan', flag='🇹🇼', name='Taiwan, Province of China', numeric='158', official_name='Taiwan, Province of China')

Anaconda could maybe use langtable instead:

$ python3
Python 3.10.4 (main, Mar 25 2022, 00:00:00) [GCC 12.0.1 20220308 (Red Hat 12.0.1-0)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import langtable
>>> langtable.territory_name('TW')
'Taiwan'
>>> 

langtable doesn’t get its data from iso-codes but from CLDR and if the CLDR English names or translated names are inappropriate, I can change it easily.

Comment 14 Hagen 2022-05-25 09:43:01 UTC
> the translator actually changed the name when translating to Traditional Chinese.

Really disappointing that my home continues to be discriminated against because of China strong-arming everyone.

> I appreciate if someone shares a steps to reproduce this issue or screenshot where they see wrong text.

During the install of Fedora KDE Plasma, the options in the installer for language / keyboards specifies this.

After installing, inside KDE Plasma if you add a 2nd keyboard its written as Traditional Chinese (in Chinese).

Comment 15 Mike FABIAN 2022-05-25 09:49:51 UTC
Or, if anaconda does not switch to using python3-langtable but keeps using python3-pycountry for this, it could maybe use the common_name='Taiwan' instead of name='Taiwan, Province of China'

“common_name” sounds it might be more useful for displaying information to the user than “name” or “official_name”. 

But as the goal of langtable development is “do whatever anaconda needs”, using langtable might be the better option.

Comment 16 Jens Petersen 2022-05-25 10:44:30 UTC
(My earlier comment about xkeyboard-layouts was incorrect: it seems anaconda actually uses libxklavier which depends on iso-codes)

Comment 17 Jens Petersen 2022-05-25 10:48:47 UTC
Created attachment 1883255 [details]
anaconda-tw-kbd-en.png

Anaconda screenshot of adding tw keyboard from English

Comment 18 Parag Nemade 2022-05-25 12:27:32 UTC
Thank you Jens for the screenshot.

Like I said in my initial comment its from iso-codes package.

Thanks to Julian for this https://salsa.debian.org/iso-codes-team/iso-codes/-/merge_requests/24 link which have some discussion around this bug.

It appears upstream considers https://www.iso.org/obp/ui/#iso:code:3166:TW as official source but how to get this entry changed is the question now?

Comment 19 Hagen 2022-05-25 15:14:40 UTC
> but how to get this entry changed is the question now?

China is a member of ISO which claims it speaks for Taiwan, despite historically China having never having any control over Taiwan.

So getting the ISO standard updated to reflect reality and not the false claims of the CCP is going to be impossible. 

:(

Comment 20 Ben Cotton 2022-08-09 13:12:06 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 37 development cycle.
Changing version to 37.

Comment 21 haisun 2022-09-05 16:33:00 UTC
we must clear to know "TAIWAN" is one province of China, we can write as "中国台湾"

Comment 22 Jens Petersen 2022-09-07 08:22:15 UTC
It just needs to show the short name "Taiwan" in this case.

Ping :-)

Comment 23 Vendula Poncova 2022-10-04 15:21:21 UTC
Hi, we read data from instances of Xkl.ConfigItem [0]. The following strings are available:

* get_name() returns "TW"
* get_short_description() doesn't return anything
* get_description() returns "Taiwan, Province of China"

[0] https://lazka.github.io/pgi-docs/index.html#Xkl-1.0/classes/ConfigItem.html#Xkl.ConfigItem

There is nothing that would return just "Taiwan".

Comment 24 Aoife Moloney 2023-11-23 00:06:20 UTC
This message is a reminder that Fedora Linux 37 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 37 on 2023-12-05.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '37'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 37 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 25 Jens Petersen 2023-11-27 08:36:16 UTC
As a worst case using TW would be better than now...

Comment 26 Jens Petersen 2023-11-27 08:52:07 UTC
Also likely langtable could take care of this?

Comment 27 Julian Groß 2024-07-22 09:05:16 UTC
> it seems anaconda actually uses libxklavier which depends on iso-codes

If there is an issue with upstream that upstream won't accept a fix for, maybe we should just include a patch in the iso-codes package? While the package name would make people expect it to comply with ISO standards, I would be surprised if anyone or anything depends on Taiwan having a wrong name.
Alternatively, there could be a second package or even just a rename of the original. Perhaps something like “locale-codes”?
Though, I would personally prefer to just add a patch, since we are talking about just a single country.

Comment 28 Katerina Koukiou 2024-12-12 10:36:13 UTC
This is not longer reproducible, tested with Fedora-41 KDE Live ISO.

Comment 29 Katerina Koukiou 2024-12-12 10:36:46 UTC
Created attachment 2062140 [details]
kde live fedora 41


Note You need to log in before you can comment on or make changes to this bug.