Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2004412

Summary: Minimize skipped checks in vdsm flake8 configuration
Product: [oVirt] vdsm Reporter: Sandro Bonazzola <sbonazzo>
Component: GeneralAssignee: Sandro Bonazzola <sbonazzo>
Status: CLOSED CURRENTRELEASE QA Contact: Guilherme Santos <gdeolive>
Severity: low Docs Contact:
Priority: low    
Version: 4.50CC: bugs, nsoffer
Target Milestone: ovirt-4.5.0Keywords: CodeChange
Target Release: 4.50.0.10Flags: sbonazzo: ovirt-4.5+
sbonazzo: devel_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: vdsm-4.50.0.10 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-01-26 09:00:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Sandro Bonazzola 2021-09-15 08:43:55 UTC 
VDSM code is failing flake8 test.
tox has been configured to not fail by skipping several tests but it should be addressed.

# Ignore errors in current code to make the build pass
# 31    E402 module level import not at top of file
# 25    E731 do not assign a lambda expression, use a def
# 43    E305 expected 2 blank lines after class or function definition, found 1
# 173   E722 do not use bare except'
# 4     E741 ambiguous variable name 'l'
# 25    E117 over-indented
# 1     E124 closing bracket does not match visual indentation
# 1     E127 continuation line over-indented for visual indent
# 1     F507 '...' % ... has 1 placeholder(s) but 2 substitution(s)
# 1     F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
# 2     F811 redefinition of unused 'key_cert_pair' from line 36
# 3     F841 local variable 'e' is assigned to but never used
# 5     W605 invalid escape sequence '\*'
Comment 1 Nir Soffer 2021-09-15 10:51:28 UTC 
Vdsm disables some checks in flake8 that were not important enough to spend time
on at the time we enabled flake8 in the build.

It good idea to minimize the number of skip checks, but removing all of them is
not non-goal.

I don't think we need a bug for these kind of changes, and no QE is needed.
Comment 2 Sandro Bonazzola 2022-04-20 06:32:24 UTC 
This bugzilla is included in oVirt 4.5.0 release, published on April 20th 2022.

Since the problem described in this bug report should be resolved in oVirt 4.5.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.