+++ This bug was initially created as a clone of Bug #2005086 +++

Description of problem:
ValidateGatewaysIcmp: False doesn't work because the ansible variable it maps to is incorrect for the role.

Version-Release number of selected component (if applicable):
openstack-tripleo-heat-templates-11.5.1-2.20210603174823.el8ost.9.noarch

How reproducible:


Steps to Reproduce:
1. Deploy with default gateway that is unavailable
2. Attempt to disable the check with ValidateGatewaysIcmp: False
3.

Actual results:
Deployment will fail in the tripleo_node_valiadtion role

2021-09-16 13:10:01.139075 | fa163e35-3c83-bd89-fd69-00000000115a |       TASK | Check Default IPv4 Gateway availability
2021-09-16 13:10:04.260888 | fa163e35-3c83-bd89-fd69-00000000115a |      FATAL | Check Default IPv4 Gateway availability | overcloud-controller-1 | error={"changed": false, "cmd": ["ping", "-w", "10", "-c", "1", "192.168.24.1"], "delta": "0:00:03.110230", "end": "2021-09-16 13:10:03.221896", "msg": "non-zero return code", "rc": 1, "start": "2021-09-16 13:10:00.111666", "stderr": "", "stderr_lines": [], "stdout": "PING 192.168.24.1 (192.168.24.1) 56(84) bytes of data.\nFrom 192.168.24.80 icmp_seq=1 Destination Host Unreachable\nFrom 192.168.24.80 icmp_seq=2 Destination Host Unreachable\nFrom 192.168.24.80 icmp_seq=3 Destination Host Unreachable\n\n--- 192.168.24.1 ping statistics ---\n3 packets transmitted, 0 received, +3 errors, 100% packet loss, time 2081ms\npipe 3", "stdout_lines": ["PING 192.168.24.1 (192.168.24.1) 56(84) bytes of data.", "From 192.168.24.80 icmp_seq=1 Destination Host Unreachable", "From 192.168.24.80 icmp_seq=2 Destination Host Unreachable", "From 192.168.24.80 icmp_seq=3 Destination Host Unreachable", "", "--- 192.168.24.1 ping statistics ---", "3 packets transmitted, 0 received, +3 errors, 100% packet loss, time 2081ms", "pipe 3"]}
2021-09-16 13:10:04.262705 | fa163e35-3c83-bd89-fd69-00000000115a |     TIMING | tripleo_nodes_validation : Check Default IPv4 Gateway availability | overcloud-controller-1 | 0:01:04.533632 | 3.41s
2021-09-16 13:10:04.484673 | fa163e35-3c83-bd89-fd69-00000000115a |      FATAL | Check Default IPv4 Gateway availability | overcloud-controller-0 | error={"changed": false, "cmd": ["ping", "-w", "10", "-c", "1", "192.168.24.1"], "delta": "0:00:03.109112", "end": "2021-09-16 13:10:03.415206", "msg": "non-zero return code", "rc": 1, "start": "2021-09-16 13:10:00.306094", "stderr": "", "stderr_lines": [], "stdout": "PING 192.168.24.1 (192.168.24.1) 56(84) bytes of data.\nFrom 192.168.24.38 icmp_seq=1 Destination Host Unreachable\nFrom 192.168.24.38 icmp_seq=2 Destination Host Unreachable\nFrom 192.168.24.38 icmp_seq=3 Destination Host Unreachable\n\n--- 192.168.24.1 ping statistics ---\n3 packets transmitted, 0 received, +3 errors, 100% packet loss, time 2077ms\npipe 3", "stdout_lines": ["PING 192.168.24.1 (192.168.24.1) 56(84) bytes of data.", "From 192.168.24.38 icmp_seq=1 Destination Host Unreachable", "From 192.168.24.38 icmp_seq=2 Destination Host Unreachable", "From 192.168.24.38 icmp_seq=3 Destination Host Unreachable", "", "--- 192.168.24.1 ping statistics ---", "3 packets transmitted, 0 received, +3 errors, 100% packet loss, time 2077ms", "pipe 3"]}
2021-09-16 13:10:04.485914 | fa163e35-3c83-bd89-fd69-00000000115a |     TIMING | tripleo_nodes_validation : Check Default IPv4 Gateway availability | overcloud-controller-0 | 0:01:04.756857 | 3.50s
2021-09-16 13:10:04.550175 | fa163e35-3c83-bd89-fd69-00000000115a |      FATAL | Check Default IPv4 Gateway availability | overcloud-controller-2 | error={"changed": false, "cmd": ["ping", "-w", "10", "-c", "1", "192.168.24.1"], "delta": "0:00:03.061904", "end": "2021-09-16 13:10:03.795394", "msg": "non-zero return code", "rc": 1, "start": "2021-09-16 13:10:00.733490", "stderr": "", "stderr_lines": [], "stdout": "PING 192.168.24.1 (192.168.24.1) 56(84) bytes of data.\nFrom 192.168.24.78 icmp_seq=1 Destination Host Unreachable\nFrom 192.168.24.78 icmp_seq=2 Destination Host Unreachable\nFrom 192.168.24.78 icmp_seq=3 Destination Host Unreachable\n\n--- 192.168.24.1 ping statistics ---\n3 packets transmitted, 0 received, +3 errors, 100% packet loss, time 2030ms\npipe 3", "stdout_lines": ["PING 192.168.24.1 (192.168.24.1) 56(84) bytes of data.", "From 192.168.24.78 icmp_seq=1 Destination Host Unreachable", "From 192.168.24.78 icmp_seq=2 Destination Host Unreachable", "From 192.168.24.78 icmp_seq=3 Destination Host Unreachable", "", "--- 192.168.24.1 ping statistics ---", "3 packets transmitted, 0 received, +3 errors, 100% packet loss, time 2030ms", "pipe 3"]}
2021-09-16 13:10:04.551453 | fa163e35-3c83-bd89-fd69-00000000115a |     TIMING | tripleo_nodes_validation : Check Default IPv4 Gateway availability | overcloud-controller-2 | 0:01:04.822390 | 3.49s
2021-09-16 13:10:04.665212 | fa163e35-3c83-bd89-fd69-00000000115a |      FATAL | Check Default IPv4 Gateway availability | overcloud-novacompute-0 | error={"changed": false, "cmd": ["ping", "-w", "10", "-c", "1", "192.168.24.1"], "delta": "0:00:03.107185", "end": "2021-09-16 13:10:03.389430", "msg": "non-zero return code", "rc": 1, "start": "2021-09-16 13:10:00.282245", "stderr": "", "stderr_lines": [], "stdout": "PING 192.168.24.1 (192.168.24.1) 56(84) bytes of data.\nFrom 192.168.24.99 icmp_seq=1 Destination Host Unreachable\nFrom 192.168.24.99 icmp_seq=2 Destination Host Unreachable\nFrom 192.168.24.99 icmp_seq=3 Destination Host Unreachable\n\n--- 192.168.24.1 ping statistics ---\n3 packets transmitted, 0 received, +3 errors, 100% packet loss, time 2076ms\npipe 3", "stdout_lines": ["PING 192.168.24.1 (192.168.24.1) 56(84) bytes of data.", "From 192.168.24.99 icmp_seq=1 Destination Host Unreachable", "From 192.168.24.99 icmp_seq=2 Destination Host Unreachable", "From 192.168.24.99 icmp_seq=3 Destination Host Unreachable", "", "--- 192.168.24.1 ping statistics ---", "3 packets transmitted, 0 received, +3 errors, 100% packet loss, time 2076ms", "pipe 3"]}
2021-09-16 13:10:04.666574 | fa163e35-3c83-bd89-fd69-00000000115a |     TIMING | tripleo_nodes_validation : Check Default IPv4 Gateway availability | overcloud-novacompute-0 | 0:01:04.937518 | 3.53s


Expected results:
This check should not be run

Workaround:

You can use <role>ExtraGroupVars to specify the correct ansible var.

Example:
parameter_defaults:
   ControllerExtraGroupVars:
       tripleo_nodes_validation_validate_gateway_icmp: false
   ComputeExtraGroupVars:
       tripleo_nodes_validation_validate_gateway_icmp: false