Bug 2005343 - System repositories can be disabled by clicking on the row
Summary: System repositories can be disabled by clicking on the row
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-software
Version: 35
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Milan Crha
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: RejectedBlocker
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-09-17 13:18 UTC by Alessio
Modified: 2022-04-13 12:20 UTC (History)
7 users (show)

Fixed In Version: gnome-software-41.1
Clone Of:
Environment:
Last Closed: 2022-04-13 12:20:28 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
GNOME Gitlab GNOME gnome-software merge_requests 992 0 None None None 2021-09-20 08:45:21 UTC

Description Alessio 2021-09-17 13:18:47 UTC
Description of problem:

In GNOME Software, go to Software Repositories.
There are slide switches enabled that are grayed out (that looks like they are the basic Fedora repositories, Fedora 35, Fedora Modular 35, registry.fedoraproject.org, etc.). 
Like if "this repository can't be disabled". Indeed if you click on it, nothing happens. And ok. Makes sense.
But if you click outside of the slide switch (i.e. on the repository name), then the repository can be disabled.


Version-Release number of selected component (if applicable):

gnome-software-41~rc-2.fc35.x86_64



Expected results:

Well. 
If the slide switch is ON and gray (you can't change its state) in order to prevent that system repositories can be disabled, ok. But in this case you should not be able to disable it at all. So the fact that you can disable the repository if you click outside the slide switch looks like a bug.
On the other hand, if it is possible to disable these repositories, the slide switch should not be grayed out.

There is something that I don't understand, or there is a misbehaving somewhere?

Comment 1 sammy 2021-09-17 13:30:42 UTC
Fedora testing button is greyed out. I could slide on fedora testing button, but cannot slide it off again.

Comment 2 sammy 2021-09-17 13:40:26 UTC
If I click in region very close around the slide button, it works. But sliding the button does not work.

Comment 3 Fedora Blocker Bugs Application 2021-09-17 14:51:00 UTC
Proposed as a Blocker for 35-final by Fedora user alciregi using the blocker tracking app because:

 Default application functionality: package manager

All applications that can be launched using the standard graphical mechanism after a default installation of Fedora Workstation on the x86_64 architecture must start successfully and withstand a basic functionality test.

I suppose that enabling and disabling a repository in gnome-software is a basic functionality test :-)

Comment 4 Milan Crha 2021-09-20 08:45:22 UTC
Thanks for a bug report. System repositories cannot be disabled (they can be enabled, if they are disabled, but they cannot be disabled from the GUI again). That's by the (new) design.

It's a bug it can be disabled by clicking on the row. I opened [1] for it.

> I suppose that enabling and disabling a repository in gnome-software is a basic functionality test

I do not think this worth the beta blocker.

[1] https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/992

Comment 5 Geraldo Simião 2021-09-20 17:30:28 UTC
I checked that on a new build with today's updates (20/09/2021) it still occurs.

Comment 6 Geoffrey Marr 2021-09-20 17:45:30 UTC
Discussed during the 2021-09-20 blocker review meeting: [0]

The decision to classify this bug as a "RejectedBlocker (Final)" was made as, while this seems like an unfortunate behavior and it'd be good to fix it, but it's not really serious enough to violate the "basic functionality" criterion or any others.

[0] https://meetbot.fedoraproject.org/fedora-blocker-review/2021-09-20/f35-blocker-review.2021-09-20-16.00.txt

Comment 7 Milan Crha 2021-09-21 07:43:08 UTC
(In reply to Geraldo Simião from comment #5)
> I checked that on a new build with today's updates (20/09/2021) it still
> occurs.

Yes, of course, the change was only proposed upstream, it was not included in the sources anywhere.

Comment 8 Milan Crha 2022-04-13 12:20:28 UTC
The upstream change landed for 41.1, I'm closing this.


Note You need to log in before you can comment on or make changes to this bug.