Bug 2005488 - golang-x-tools-0.1.8 is available
Summary: golang-x-tools-0.1.8 is available
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: golang-x-tools
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1978517
TreeView+ depends on / blocked
 
Reported: 2021-09-17 18:47 UTC by Upstream Release Monitoring
Modified: 2022-01-28 21:22 UTC (History)
3 users (show)

Fixed In Version: golang-x-tools-0.1.8-0.1.fc35 golang-x-tools-0.1.8-0.1.fc34 golang-x-tools-0.1.9-0.3.fc36
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-12-31 01:20:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Upstream Release Monitoring 2021-09-17 18:47:56 UTC
Latest upstream release: 0.1.6
Current version/release in rawhide: 0.1.5-0.1.fc35
URL: https://github.com/golang/tools

Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/


More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from anitya: https://release-monitoring.org/project/9382/

Comment 1 Upstream Release Monitoring 2021-09-17 18:47:59 UTC
Skipping the scratch build because an SRPM could not be built: ['rpmbuild', '-D', '_sourcedir .', '-D', '_topdir .', '-bs', '/var/tmp/thn-98pmznmg/golang-x-tools.spec'] returned 1: b'error: line 30: Tag takes single token only: Release:        %autorelease 1.fc32\n'

Comment 2 Upstream Release Monitoring 2021-09-29 22:14:33 UTC
Latest upstream release: 0.1.7
Current version/release in rawhide: 0.1.5-0.1.fc35
URL: https://github.com/golang/tools

Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/


More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from anitya: https://release-monitoring.org/project/9382/

Comment 3 Upstream Release Monitoring 2021-09-29 22:14:35 UTC
Skipping the scratch build because an SRPM could not be built: ['rpmbuild', '-D', '_sourcedir .', '-D', '_topdir .', '-bs', '/var/tmp/thn-po58corz/golang-x-tools.spec'] returned 1: b'error: line 30: Tag takes single token only: Release:        %autorelease 1.fc32\n'

Comment 4 Upstream Release Monitoring 2021-12-04 08:33:37 UTC
Latest upstream release: 0.1.8
Current version/release in rawhide: 0.1.5-0.1.fc35
URL: https://github.com/golang/tools

Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/


More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from anitya: https://release-monitoring.org/project/9382/

Comment 5 Upstream Release Monitoring 2021-12-04 08:33:41 UTC
Skipping the scratch build because an SRPM could not be built: ['git', 'commit', '-a', '-m', 'Update to 0.1.8 (#2005488)'] returned 1: b'On branch rawhide\nYour branch is up to date with \'origin/rawhide\'.\n\nUntracked files:\n  (use "git add <file>..." to include in what will be committed)\n\tSRPMS/\n\nnothing added to commit but untracked files present (use "git add" to track)\n'

Comment 6 Fedora Update System 2021-12-22 03:03:46 UTC
FEDORA-2021-583ab23c5b has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-583ab23c5b

Comment 7 Maxwell G 2021-12-22 03:07:40 UTC
I updated F34 and F35, but tests are failing with go 1.18 on F36[1]. Can someone more knowledgeable than me please look into it?

[1]: https://koji.fedoraproject.org/koji/taskinfo?taskID=80309026

Comment 8 Fedora Update System 2021-12-22 03:15:48 UTC
FEDORA-2021-25b98ef3f3 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-25b98ef3f3

Comment 9 Robert-André Mauchin 🐧 2021-12-22 07:07:32 UTC
(In reply to Maxwell G from comment #7)
> I updated F34 and F35, but tests are failing with go 1.18 on F36[1]. Can
> someone more knowledgeable than me please look into it?
> 
> [1]: https://koji.fedoraproject.org/koji/taskinfo?taskID=80309026

Package the latest git tip by adding

%global commit 8d383106f7e7ea8a4a51f70b452d532c65fe6e3e

(don't remove the Version, just add it below it) 

There has been commits to fix compatibility with Go 1.18, for example:https://github.com/golang/tools/commit/d3358c1fb7d397621cd5dd5f49a8823f07bae94b#diff-4409098685f18ad267a4f3dd23007e9627c74df39ced82f8722277ad834a4817

Comment 10 Maxwell G 2021-12-22 18:23:10 UTC
(In reply to Robert-André Mauchin 🐧 from comment #9)
> (In reply to Maxwell G from comment #7)
> > I updated F34 and F35, but tests are failing with go 1.18 on F36[1]. Can
> > someone more knowledgeable than me please look into it?
> > 
> > [1]: https://koji.fedoraproject.org/koji/taskinfo?taskID=80309026
> 
> Package the latest git tip by adding
> 
> %global commit 8d383106f7e7ea8a4a51f70b452d532c65fe6e3e
> 
> (don't remove the Version, just add it below it) 
> 
> There has been commits to fix compatibility with Go 1.18, for
> example:https://github.com/golang/tools/commit/
> d3358c1fb7d397621cd5dd5f49a8823f07bae94b#diff-
> 4409098685f18ad267a4f3dd23007e9627c74df39ced82f8722277ad834a4817

Should I do so for all branches or just `rawhide`? Also, I created a buildroot override for `f34` and `f35`. Should I create buildroot overrides when updating go packages in the future?

Thanks,
Maxwell

Comment 11 Robert-André Mauchin 🐧 2021-12-22 19:24:04 UTC
(In reply to Maxwell G from comment #10)
> (In reply to Robert-André Mauchin 🐧 from comment #9)
> > (In reply to Maxwell G from comment #7)
> > > I updated F34 and F35, but tests are failing with go 1.18 on F36[1]. Can
> > > someone more knowledgeable than me please look into it?
> > > 
> > > [1]: https://koji.fedoraproject.org/koji/taskinfo?taskID=80309026
> > 
> > Package the latest git tip by adding
> > 
> > %global commit 8d383106f7e7ea8a4a51f70b452d532c65fe6e3e
> > 
> > (don't remove the Version, just add it below it) 
> > 
> > There has been commits to fix compatibility with Go 1.18, for
> > example:https://github.com/golang/tools/commit/
> > d3358c1fb7d397621cd5dd5f49a8823f07bae94b#diff-
> > 4409098685f18ad267a4f3dd23007e9627c74df39ced82f8722277ad834a4817
> 
> Should I do so for all branches or just `rawhide`? Also, I created a
> buildroot override for `f34` and `f35`. Should I create buildroot overrides
> when updating go packages in the future?
> 
> Thanks,
> Maxwell

I generally do it for the stables branch too.

I do BOs of 15 days zhen i build a series of package or big package like this one.

Comment 12 Maxwell G 2021-12-22 20:50:07 UTC
(In reply to Robert-André Mauchin 🐧 from comment #11)
> (In reply to Maxwell G from comment #10)
> > (In reply to Robert-André Mauchin 🐧 from comment #9)
> > > (In reply to Maxwell G from comment #7)
> > > > I updated F34 and F35, but tests are failing with go 1.18 on F36[1]. Can
> > > > someone more knowledgeable than me please look into it?
> > > > 
> > > > [1]: https://koji.fedoraproject.org/koji/taskinfo?taskID=80309026
> > > 
> > > Package the latest git tip by adding
> > > 
> > > %global commit 8d383106f7e7ea8a4a51f70b452d532c65fe6e3e
> > > 
> > > (don't remove the Version, just add it below it) 
> > > 
> > > There has been commits to fix compatibility with Go 1.18, for
> > > example:https://github.com/golang/tools/commit/
> > > d3358c1fb7d397621cd5dd5f49a8823f07bae94b#diff-
> > > 4409098685f18ad267a4f3dd23007e9627c74df39ced82f8722277ad834a4817
> > 
> > Should I do so for all branches or just `rawhide`? Also, I created a
> > buildroot override for `f34` and `f35`. Should I create buildroot overrides
> > when updating go packages in the future?
> > 
> > Thanks,
> > Maxwell
> 
> I generally do it for the stables branch too.
> 
> I do BOs of 15 days zhen i build a series of package or big package like
> this one.

The latest upstream commit has a new dependency (github.com/jba/printsrc) that is not packaged. I created a specfile with go2rpm and successfully built it locally. Is it necessary to go through the package review process for that?

Comment 13 Fedora Update System 2021-12-23 01:08:28 UTC
FEDORA-2021-25b98ef3f3 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-25b98ef3f3`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-25b98ef3f3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2021-12-23 01:43:00 UTC
FEDORA-2021-583ab23c5b has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-583ab23c5b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-583ab23c5b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Robert-André Mauchin 🐧 2021-12-23 17:11:02 UTC
(In reply to Maxwell G from comment #12)
> (In reply to Robert-André Mauchin 🐧 from comment #11)
> > (In reply to Maxwell G from comment #10)
> > > (In reply to Robert-André Mauchin 🐧 from comment #9)
> > > > (In reply to Maxwell G from comment #7)
> > > > > I updated F34 and F35, but tests are failing with go 1.18 on F36[1]. Can
> > > > > someone more knowledgeable than me please look into it?
> > > > > 
> > > > > [1]: https://koji.fedoraproject.org/koji/taskinfo?taskID=80309026
> > > > 
> > > > Package the latest git tip by adding
> > > > 
> > > > %global commit 8d383106f7e7ea8a4a51f70b452d532c65fe6e3e
> > > > 
> > > > (don't remove the Version, just add it below it) 
> > > > 
> > > > There has been commits to fix compatibility with Go 1.18, for
> > > > example:https://github.com/golang/tools/commit/
> > > > d3358c1fb7d397621cd5dd5f49a8823f07bae94b#diff-
> > > > 4409098685f18ad267a4f3dd23007e9627c74df39ced82f8722277ad834a4817
> > > 
> > > Should I do so for all branches or just `rawhide`? Also, I created a
> > > buildroot override for `f34` and `f35`. Should I create buildroot overrides
> > > when updating go packages in the future?
> > > 
> > > Thanks,
> > > Maxwell
> > 
> > I generally do it for the stables branch too.
> > 
> > I do BOs of 15 days zhen i build a series of package or big package like
> > this one.
> 
> The latest upstream commit has a new dependency (github.com/jba/printsrc)
> that is not packaged. I created a specfile with go2rpm and successfully
> built it locally. Is it necessary to go through the package review process
> for that?

Send me the Review request qnd I'll process it (mail me directly or NEEDINFO me, otherwise I might miss it)

Comment 16 Fedora Update System 2021-12-31 01:20:25 UTC
FEDORA-2021-583ab23c5b has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2021-12-31 01:34:30 UTC
FEDORA-2021-25b98ef3f3 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Maxwell G 2022-01-08 02:48:25 UTC
(In reply to Robert-André Mauchin 🐧 from comment #9)
> (In reply to Maxwell G from comment #7)
> > I updated F34 and F35, but tests are failing with go 1.18 on F36[1]. Can
> > someone more knowledgeable than me please look into it?
> > 
> > [1]: https://koji.fedoraproject.org/koji/taskinfo?taskID=80309026
> 
> Package the latest git tip by adding
> 
> %global commit 8d383106f7e7ea8a4a51f70b452d532c65fe6e3e
> 
> (don't remove the Version, just add it below it) 
> 
> There has been commits to fix compatibility with Go 1.18, for
> example:https://github.com/golang/tools/commit/
> d3358c1fb7d397621cd5dd5f49a8823f07bae94b#diff-
> 4409098685f18ad267a4f3dd23007e9627c74df39ced82f8722277ad834a4817

Updating to the latest commit (and packaging the new dependency, of course) fixed one of the test failures but not the other. Should I just disable the test?

---

Released version (https://kojipkgs.fedoraproject.org//work/tasks/5640/80975640/build.log):

```
golang.org/x/tools/go/internal/gcimporter
--- FAIL: TestImportedTypes (0.09s)
    gcimporter_test.go:279: context.Context: got "type Context interface{Deadline() (deadline time.Time, ok bool); Done() <-chan struct{}; Err() error; Value(key any) any}"; want "type Context interface{Deadline() (deadline time.Time, ok bool); Done() <-chan struct{}; Err() error; Value(key interface{}) interface{}}"
--- FAIL: TestImportTypeparamTests (0.00s)
    iexport_go118_test.go:101: open /usr/lib/golang/test/typeparam: no such file or directory
FAIL
exit status 1
FAIL	golang.org/x/tools/go/internal/gcimporter	22.213s
```

Git snapshot (https://download.copr.fedorainfracloud.org/results/gotmax23/gotmax23_copr/fedora-rawhide-x86_64/03133381-golang-x-tools/builder-live.log.gz):

```
golang.org/x/tools/go/internal/gcimporter
--- FAIL: TestImportTypeparamTests (0.00s)
    iexport_go118_test.go:101: open /usr/lib/golang/test/typeparam: no such file or directory
FAIL
exit status 1
FAIL	golang.org/x/tools/go/internal/gcimporter	27.944s
```

Comment 19 Fedora Update System 2022-01-28 21:18:00 UTC
FEDORA-2022-cdb78438d5 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-cdb78438d5

Comment 20 Fedora Update System 2022-01-28 21:22:26 UTC
FEDORA-2022-cdb78438d5 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.