RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2005790 - Backport upstream PR #20670
Summary: Backport upstream PR #20670
Keywords:
Status: CLOSED DUPLICATE of bug 1970945
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: systemd
Version: 8.4
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: Michal Sekletar
QA Contact: Frantisek Sumsal
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-09-20 07:45 UTC by Michal Sekletar
Modified: 2022-06-01 08:25 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-06-01 08:25:03 UTC
Type: Bug
Target Upstream Version:
Embargoed:
pm-rhel: mirror+


Attachments (Terms of Use)
Reproducer (1.44 KB, text/x-csrc)
2021-09-20 08:56 UTC, Michal Sekletar
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github systemd systemd pull 20670 0 None Merged sd-event: take ref on event loop object before dispatching event sources 2021-09-20 09:20:29 UTC
Red Hat Issue Tracker RHELPLAN-97613 0 None None None 2021-09-20 07:49:12 UTC

Description Michal Sekletar 2021-09-20 07:45:36 UTC
Description of problem:
We should backport fix addressed in #20670 in order to prevent potential use-after-free bugs.


Version-Release number of selected component (if applicable):
systemd-239-45.el8

How reproducible:
unknown

Steps to Reproduce:
1. There are no clear steps to trigger this issue in systemd (as in service manager) context, but it should be possible to write synthetic reproducer in C that would use the sd-event APIs in a way that triggers the bug.

Actual results:
Use after free of sd-event object.

Expected results:
Reference count for sd-event is not dropped to 0 by user-provided callback and main sd-event loop object is not freed prematurely.

Additional info:
https://github.com/systemd/systemd/pull/20670

Comment 2 Michal Sekletar 2021-09-20 08:56:35 UTC
Created attachment 1824565 [details]
Reproducer

This short C program demonstrates the problem. Compile it and run under valgrind to see errors reported when run against unpatched version of libsystemd.

gcc -ggdb3 -O0 -o bz2005790 bz2005790.c -lsystemd


Note You need to log in before you can comment on or make changes to this bug.