RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2005877 - Fix annocheck fail (optimization level too low) in bundled argon2 implementation
Summary: Fix annocheck fail (optimization level too low) in bundled argon2 implementation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: cryptsetup
Version: 9.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: 9.0
Assignee: Ondrej Kozina
QA Contact: guazhang@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-09-20 11:52 UTC by Ondrej Kozina
Modified: 2022-05-17 16:07 UTC (History)
5 users (show)

Fixed In Version: cryptsetup-2.4.1-1.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-17 15:48:06 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-97626 0 None None None 2021-09-20 11:53:19 UTC
Red Hat Product Errata RHBA-2022:3913 0 None None None 2022-05-17 15:48:21 UTC

Description Ondrej Kozina 2021-09-20 11:52:07 UTC
Description of problem:

The annocheck fail is triggered by following code snippet in lib/crypto_backend/argon2/core.c (bundled argon2 implementation in cryptsetup library):

void __attribute__((optimize("O0"))) secure_wipe_memory(void *v, size_t n) {
#if defined(_MSC_VER) && VC_GE_2005(_MSC_VER)
    SecureZeroMemory(v, n);
#elif defined memset_s
    memset_s(v, n, 0, n);
#elif defined(HAVE_EXPLICIT_BZERO)
    explicit_bzero(v, n);
#else
    static void *(*const volatile memset_sec)(void *, int, size_t) = &memset;
    memset_sec(v, 0, n);
#endif
}

Basically referential implementation of argon2 algorithm is using sub-optimal solution to avoid security related memory wipe function being optimized out by compiler.

Note that explicit_bzero() function is available in RHEL9 glibc so the optimization annotation is basically useless (explicit_bzero can not be optimized out by definition).

The bug is not critical since it's only single function used only in argon2 implementation.

Comment 3 Ondrej Kozina 2021-09-21 07:42:39 UTC
Fixed by https://gitlab.com/cryptsetup/cryptsetup/-/merge_requests/216

Comment 6 guazhang@redhat.com 2021-10-10 11:56:12 UTC
move to verified since test pass with fixed package.

Comment 8 errata-xmlrpc 2022-05-17 15:48:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: cryptsetup), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:3913


Note You need to log in before you can comment on or make changes to this bug.