Bug 2005982 - Review Request: rust-inlinable_string - Alternative Rust String implementation
Summary: Review Request: rust-inlinable_string - Alternative Rust String implementation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-09-20 15:29 UTC by Jan Baudisch
Modified: 2022-05-18 01:24 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-08 07:57:17 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Comment 1 Fabio Valentini 2022-04-30 09:54:23 UTC
Are you still interested in packaging this crate? What do you need it for?
Blocking the review request bug for the package you need it for helps others prioritize which packages to review first.

Side note: Please regenerate the packaging with rust2rpm 21 and replace the Summary. It's WAY TOO LONG (it should fit within 80 columns).
For example: "Summary: Owned, grow-able UTF-8 string that stores small strings inline"

Comment 2 Jan Baudisch 2022-05-03 09:27:37 UTC
Refreshed with rust2rpm 21.

Comment 3 Jan Baudisch 2022-05-03 09:33:10 UTC
Yes, I intend to still package the crates that I opened requests for and some others. I want to package Rocket to be able to build vaultwarden, but that is still some packages away so right now I am trying to get all Rocket dependencies into Fedora.

Also fixed the summary.

Comment 4 Fabio Valentini 2022-05-04 09:35:15 UTC
Thanks, looks good to me now.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT and ASL 2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 5 Gwyn Ciesla 2022-05-04 21:04:55 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-inlinable_string

Comment 6 Fedora Update System 2022-05-08 07:56:21 UTC
FEDORA-2022-886c335242 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-886c335242

Comment 7 Fedora Update System 2022-05-08 07:57:17 UTC
FEDORA-2022-886c335242 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2022-05-08 08:00:07 UTC
FEDORA-2022-14d43a7484 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-14d43a7484

Comment 9 Fedora Update System 2022-05-08 08:00:45 UTC
FEDORA-2022-33fa436d08 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-33fa436d08

Comment 10 Fedora Update System 2022-05-08 09:01:21 UTC
FEDORA-2022-37e3e17898 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-37e3e17898

Comment 11 Fedora Update System 2022-05-09 02:04:57 UTC
FEDORA-2022-37e3e17898 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-37e3e17898 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-37e3e17898

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-05-09 02:24:47 UTC
FEDORA-2022-14d43a7484 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-14d43a7484 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-14d43a7484

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-05-09 02:54:54 UTC
FEDORA-2022-33fa436d08 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-33fa436d08 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-33fa436d08

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fabio Valentini 2022-05-09 11:23:11 UTC
> Side note: Please regenerate the packaging with rust2rpm 21 and replace the Summary. It's WAY TOO LONG (it should fit within 80 columns).
> For example: "Summary: Owned, grow-able UTF-8 string that stores small strings inline"

Looks like you (accidentally?) reverted your fix for this when you imported the package:
https://src.fedoraproject.org/rpms/rust-inlinable_string/blob/rawhide/f/rust-inlinable_string.spec#_10

Please fix this ASAP.

Comment 15 Jan Baudisch 2022-05-09 16:40:06 UTC
Yes, this was by accident, sorry for that. Should be fixed now.

Comment 16 Fedora Update System 2022-05-10 01:04:45 UTC
FEDORA-2022-14d43a7484 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-14d43a7484 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-14d43a7484

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2022-05-10 01:29:52 UTC
FEDORA-2022-37e3e17898 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-37e3e17898 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-37e3e17898

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2022-05-10 02:05:07 UTC
FEDORA-2022-33fa436d08 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-33fa436d08 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-33fa436d08

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Fedora Update System 2022-05-18 01:08:30 UTC
FEDORA-2022-33fa436d08 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2022-05-18 01:11:06 UTC
FEDORA-2022-37e3e17898 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2022-05-18 01:24:51 UTC
FEDORA-2022-14d43a7484 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.