Bug 2007051 - fedpkg-minimal: branch for epel9
Summary: fedpkg-minimal: branch for epel9
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: fedpkg-minimal
Version: epel9
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ondřej Nosek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2039901 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-09-23 00:29 UTC by Carl George 🤠
Modified: 2022-01-21 16:41 UTC (History)
8 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-01-21 16:41:32 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Carl George 🤠 2021-09-23 00:29:59 UTC
Description of problem:
I'm in the process of setting up epel9-next.  The first build I'll need is fedpkg-minimal.  Please add me as a co-maintainer of this package so I can request an epel9-next branch.


Additional info:
https://docs.fedoraproject.org/en-US/epel/epel-about-next/

Comment 1 Ondřej Nosek 2021-09-23 21:37:35 UTC
I think, that maintainer permission is not needed for requesting the branch. Are you following the procedure from https://docs.fedoraproject.org/en-US/epel/epel-about-next/ ?
There is command:
    fedpkg request-branch epel8-next
As far as I know, the Pagure token needs to be configured before executing 'request-branch' command.

But 'request-branch' command initially checks available packages and architectures in files here:
https://infrastructure.fedoraproject.org/repo/json/
So far there is no epel9* json file, so the 'request-branch' command will fail. And without minor changes (I didn't get any requirements regarding that) in the fedpkg code, only a manual approach can be used for requesting the branch = opening ticket here: https://pagure.io/releng/fedora-scm-requests/issues (the request must have exact format)
I have no idea, how json files are created and who is responsible for them.

But having the branch is not necessary every time. For fedpkg-minimal there are no changes between el7, el8, f33, f34 and rawhide specfiles. So epel9-next target can be built from rawhide as well. There is no epel9 build so far. I did the epel9-next build this way:
    git checkout rawhide
    fedpkg --release epel9-next scratch-build   (https://koji.fedoraproject.org/koji/taskinfo?taskID=76185489)
    fedpkg --release epel9-next build   (https://koji.fedoraproject.org/koji/taskinfo?taskID=76185595)
    
Is it OK for you?

Comment 2 Carl George 🤠 2021-09-24 17:03:39 UTC
Anyone can run `fedpkg request-branch`, but fedscm-admin will reject the request if you are not a maintainer.

https://pagure.io/fedscm-admin/blob/a28ddf39ab8307de46d08573a0f1ccc9cf930d4c/f/fedscm_admin/utils.py#_579

I have an open pull request to fedscm-admin to have it check CentOS Stream 9 compose metadata instead of the pkg_elX.json files.  I don't plan on requesting the branch until after that is merged.

https://pagure.io/fedscm-admin/pull-request/72

That build you did will be sufficient to unblock us with standing up epel9-next.  I still think there should be a branch just for consistency, but that can be done later.

I'd still like to become a co-maintainer of the package if you're willing to have me, as I'll need to repeat these steps every 3 years for the standup of each new epel major version.

Comment 3 Ondřej Nosek 2021-09-29 21:29:41 UTC
Ok, thanks for the explanation. It wasn't obvious to me you have to have specific permissions. So I granted you some, hopefully, it will work.
It also looks like I will have to apply the patch (https://pagure.io/fedscm-admin/pull-request/72) or at least a very similar code to fedpkg to allow checking for the epel 9 and newer.
https://pagure.io/fedpkg/blob/master/f/fedpkg/utils.py#_332
I will wait for the approval/merge of the https://pagure.io/fedscm-admin/pull-request/72 before applying it to fedpkg.

Comment 4 Carl George 🤠 2021-10-06 20:32:47 UTC
https://pagure.io/fedscm-admin/pull-request/72 has been merged, and I've submitted https://pagure.io/fedpkg/pull-request/453 to match.

Comment 5 Miro Hrončok 2021-12-06 17:58:11 UTC
Requesting branches works now.

Comment 6 Kevin Fenzi 2021-12-13 19:11:14 UTC
Just FYI, this is causing all local epel9/epel9-next mock builds to fail (mock installs fedpkg-minimal as part of it's setup packages). 

So, it would be nice to branch/build this for epel9 soon.

Comment 7 Miro Hrončok 2021-12-13 21:32:44 UTC
FTR mock already removed the package from the list, but a release of mock-core-configs was not yet made: https://github.com/rpm-software-management/mock/pull/793

Comment 8 Fedora Update System 2022-01-12 19:01:05 UTC
FEDORA-EPEL-2022-ad29b77d82 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-ad29b77d82

Comment 9 Carl George 🤠 2022-01-12 19:31:03 UTC
I'd like to request an epel9 branch of this package, but I do not have any permissions on this package.  Please add my FAS, carlwgeorge.

Comment 10 Carl George 🤠 2022-01-12 21:11:50 UTC
*** Bug 2039901 has been marked as a duplicate of this bug. ***

Comment 11 Ondřej Nosek 2022-01-13 22:41:55 UTC
'epel9' branch created.
Update created:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-762e2fb6ac

Comment 12 Troy Dawson 2022-01-21 16:41:32 UTC
fedpkg-minimal is in epel9 now.
Thank You


Note You need to log in before you can comment on or make changes to this bug.