Spec URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-yansi/rust-yansi.spec Patch URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-yansi/remove-parking_lot.patch SRPM URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-yansi/rust-yansi-0.5.0-1.fc37.src.rpm Description: Rust terminal color painting library Fedora Account System Username: janbaudisch COPR package: https://copr.fedorainfracloud.org/coprs/janbaudisch/rust/package/rust-yansi Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=82768027
Taking this review (removing the blocker on FE-NEEDSPONSOR since you're sponsored now!) One change request: so the %bcond_without you see at the top of the spec as generated by rust2rpm actually controls whether that flag is enabled or not, see https://rpm-software-management.github.io/rpm/manual/conditionalbuilds.html so: %bcond_without check means %{with check} by default, unless compiled --without check If the Rust compiler we have is too old for the test suite, then you just flip that definition to be %bcond_with check, and put a comment above it, no need to comment out the entire %check section This makes it easy to test locally if you think checks can be enabled again: fedpkg srpm (or rpmbuild -bs rust-yansi.spec) mock /path/to/rust-yansi-*.src.rpm --with check
Thank you for pointing this out. I changed it and updated the spec and srpm.
*** This bug has been marked as a duplicate of bug 2079341 ***