Bug 2009155 - Review Request: python-oslo-messaging - OpenStack common messaging library
Summary: Review Request: python-oslo-messaging - OpenStack common messaging library
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jakub Kadlčík
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1663668 1991145 1992629 2009146
TreeView+ depends on / blocked
 
Reported: 2021-09-30 06:14 UTC by Hirotaka Wakabayashi
Modified: 2024-04-19 03:00 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
xavier: fedora-review?


Attachments (Terms of Use)

Description Hirotaka Wakabayashi 2021-09-30 06:14:46 UTC
Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec
SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-12.9.1-1.fc36.src.rpm
Description: 
The Oslo project intends to produce a python library containing
infrastructure code shared by OpenStack projects. The APIs provided
by the project should be high quality, stable, consistent and generally
useful.

The Oslo messaging API supports RPC and notifications over a number of
different messaging transports.
Fedora Account System Username: hiwkby

This package retired two years ago but the former packager says feel free
to take it. I will take this and update to 12.9.1.
https://src.fedoraproject.org/rpms/python-oslo-messaging
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/G4FL3WR6BXVRZ23WO4FRLDPGHLCIAKYP/

Comment 2 Jakub Kadlčík 2022-10-29 21:07:21 UTC
Hello Hirotaka,
thank you for the package.

> Koji(success!): https://koji.fedoraproject.org/koji/taskinfo?taskID=93461252 

Not a success :D

    No matching package to install: 'python3-oslo-metrics'
    No matching package to install: 'python3-oslo-middleware'
    No matching package to install: 'python3-oslo-service'

The python3-oslo-middleware is being done in RHBZ 1992629 but I can't
find tickets for the remaining two. If you will be adding them
yourself, feel free to ping me and I will prioritize their review.

Comment 3 Hirotaka Wakabayashi 2022-11-01 00:55:49 UTC
Hi Jakub! Thanks a lot for your feedback! I filed the remaining two packages and fixed the issues on them. I would truly appreciate it if you would kindly check them too!

* python-oslo-metrics
  https://bugzilla.redhat.com/show_bug.cgi?id=2009146#c3
* python-oslo-service
  https://bugzilla.redhat.com/show_bug.cgi?id=1991145#c3

I also fixed the issues on python-oslo-middleware.

* python-oslo-middleware
  https://bugzilla.redhat.com/show_bug.cgi?id=1992629#c7

> Not a success :D

I am sorry that I missed the failure...orz 
I updated the python-oslo-messaging.spec. However koji build is still unsuccessful because of the package dependencies.

Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec
SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-14.0.0-2.fc38.src.rpm 
Koji(unsuccess...orz): https://koji.fedoraproject.org/koji/taskinfo?taskID=93644843

```
$ diff -c public_html/python-oslo-messaging.spec python-oslo-messaging.spec 
*** public_html/python-oslo-messaging.spec      2022-10-26 10:15:08.634392166 +0000
--- python-oslo-messaging.spec  2022-11-01 00:04:05.652081505 +0000
***************
*** 12,30 ****
  by the project should be high quality, stable, consistent and generally \
  useful.
  
- %global common_desc1 \
- Tests for the OpenStack common messaging library.
- 
  %global pypi_name oslo.messaging
  %global pkg_name oslo-messaging
  
  Name:       python-oslo-messaging
  Version:    14.0.0
! Release:    1%{?dist}
  Summary:    OpenStack common messaging library
  
  License:    ASL 2.0
! URL:        https://launchpad.net/oslo
  Source0:    https://tarballs.openstack.org/%{pypi_name}/%{pypi_name}-%{upstream_version}.tar.gz
  # Required for tarball sources verification
  %if 0%{?sources_gpg} == 1
--- 12,27 ----
  by the project should be high quality, stable, consistent and generally \
  useful.
  
  %global pypi_name oslo.messaging
  %global pkg_name oslo-messaging
  
  Name:       python-oslo-messaging
  Version:    14.0.0
! Release:    2%{?dist}
  Summary:    OpenStack common messaging library
  
  License:    ASL 2.0
! URL:        https://opendev.org/openstack/oslo.messaging
  Source0:    https://tarballs.openstack.org/%{pypi_name}/%{pypi_name}-%{upstream_version}.tar.gz
  # Required for tarball sources verification
  %if 0%{?sources_gpg} == 1
***************
*** 52,58 ****
  BuildRequires: python3-fixtures
  BuildRequires: python3-hacking
  BuildRequires: python3-kombu >= 1:4.6.6
- BuildRequires: python3-mock
  BuildRequires: python3-oslo-config
  BuildRequires: python3-oslo-metrics
  BuildRequires: python3-oslo-middleware
--- 49,54 ----
***************
*** 139,145 ****
  BuildRequires: python3-kafka
  
  %description -n python3-%{pkg_name}-tests
! %{common_desc1}
  
  %description
  %{common_desc}
--- 135,141 ----
  BuildRequires: python3-kafka
  
  %description -n python3-%{pkg_name}-tests
! Tests for the OpenStack common messaging library.
  
  %description
  %{common_desc}
***************
*** 193,198 ****
--- 189,197 ----
  
  
  %changelog
+ * Tue Nov 01 2022 Hirotaka Wakabayashi hiwkby - 14.0.0-2
+ - Fixes issues on the packaging guidelines
+ 
  * Wed Oct 26 2022 Hirotaka Wakabayashi hiwkby - 14.0.0-1
  - Update to 14.0.0
  

```

Thanks in advance,
Hirotaka

Comment 4 Hirotaka Wakabayashi 2022-11-08 02:44:35 UTC
Hello, I fixed the issue on the packaging guidelines

Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec
SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-14.0.0-3.fc38.src.rpm 
Koji(unsuccess...orz): https://koji.fedoraproject.org/koji/taskinfo?taskID=93926697

```
$ diff -c public_html/python-oslo-messaging.spec python-oslo-messaging.spec
*** public_html/python-oslo-messaging.spec      2022-11-01 00:25:44.540360201 +0000
--- python-oslo-messaging.spec  2022-11-08 02:11:07.003786314 +0000
***************
*** 17,23 ****
  
  Name:       python-oslo-messaging
  Version:    14.0.0
! Release:    2%{?dist}
  Summary:    OpenStack common messaging library
  
  License:    ASL 2.0
--- 17,23 ----
  
  Name:       python-oslo-messaging
  Version:    14.0.0
! Release:    3%{?dist}
  Summary:    OpenStack common messaging library
  
  License:    ASL 2.0
***************
*** 39,45 ****
  
  %package -n python3-%{pkg_name}
  Summary:    OpenStack common messaging library
! %{?python_provide:%python_provide python3-%{pkg_name}}
  
  BuildRequires: python3-devel
  BuildRequires: python3-setuptools
--- 39,45 ----
  
  %package -n python3-%{pkg_name}
  Summary:    OpenStack common messaging library
! %py_provides python3-pkg_resources
  
  BuildRequires: python3-devel
  BuildRequires: python3-setuptools
***************
*** 189,194 ****
--- 189,197 ----
  
  
  %changelog
+ * Tue Nov 08 2022 Hirotaka Wakabayashi hiwkby - 14.0.0-3
+ - Fixes issues on the packaging guidelines
+ 
  * Tue Nov 01 2022 Hirotaka Wakabayashi hiwkby - 14.0.0-2
  - Fixes issues on the packaging guidelines
  
```

```
$ sudo dnf install -y ~/dev/packages/RPMS/noarch/python3-oslo-messaging-14.0.0-3.fc38.noarch.rpm 
$ rpm -q --whatprovides python3-oslo-messaging
python3-oslo-messaging-14.0.0-3.fc38.noarch
```

Comment 5 Hirotaka Wakabayashi 2022-11-09 03:28:31 UTC
Sorry, I fixed an issue on the guidelines again because I read the old guidelines and made a mistake...orz

Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec
SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-14.0.0-4.fc38.src.rpm 
Koji(unsuccess...orz): https://koji.fedoraproject.org/koji/taskinfo?taskID=93962680

```
$ diff -c public_html/python-oslo-messaging.spec python-oslo-messaging.spec
*** public_html/python-oslo-messaging.spec      2022-11-08 02:11:07.003786314 +0000
--- python-oslo-messaging.spec  2022-11-09 02:40:02.835283149 +0000
***************
*** 17,23 ****
  
  Name:       python-oslo-messaging
  Version:    14.0.0
! Release:    3%{?dist}
  Summary:    OpenStack common messaging library
  
  License:    ASL 2.0
--- 17,23 ----
  
  Name:       python-oslo-messaging
  Version:    14.0.0
! Release:    4%{?dist}
  Summary:    OpenStack common messaging library
  
  License:    ASL 2.0
***************
*** 39,45 ****
  
  %package -n python3-%{pkg_name}
  Summary:    OpenStack common messaging library
! %py_provides python3-pkg_resources
  
  BuildRequires: python3-devel
  BuildRequires: python3-setuptools
--- 39,45 ----
  
  %package -n python3-%{pkg_name}
  Summary:    OpenStack common messaging library
! %py_provides python3-%{pkg_name}
  
  BuildRequires: python3-devel
  BuildRequires: python3-setuptools
***************
*** 189,194 ****
--- 189,197 ----
  
  
  %changelog
+ * Wed Nov 09 2022 Hirotaka Wakabayashi hiwkby - 14.0.0-4
+ - Fixes issues on the packaging guidelines
+ 
  * Tue Nov 08 2022 Hirotaka Wakabayashi hiwkby - 14.0.0-3
  - Fixes issues on the packaging guidelines
```

```
$ rpmspec -P python-oslo-messaging.spec | grep -B 3 Provides 

%package -n python3-oslo-messaging
Summary:    OpenStack common messaging library
Provides: python3-oslo-messaging = 14.0.0-4.fc38
Provides: python3.11-oslo-messaging = 14.0.0-4.fc38
Provides: python-oslo-messaging = 14.0.0-4.fc38

$ sudo dnf install -y ~/dev/packages/RPMS/noarch/python3-oslo-messaging-14.0.0-4.fc38.noarch.rpm 
$ rpm -q --whatprovides python3-oslo-messaging
python3-oslo-messaging-14.0.0-4.fc38.noarch

```

Comment 6 Hirotaka Wakabayashi 2022-11-16 04:23:42 UTC
Hello, I fixed another issue.

Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec
SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-14.0.0-5.fc38.src.rpm
Koji(unsuccess...orz): https://koji.fedoraproject.org/koji/taskinfo?taskID=94227860

```
$ diff -c public_html/python-oslo-messaging.spec python-oslo-messaging.spec
*** public_html/python-oslo-messaging.spec      2022-11-09 02:40:02.835283149 +0000
--- python-oslo-messaging.spec  2022-11-16 03:46:52.397596333 +0000
***************
*** 17,23 ****
  
  Name:       python-oslo-messaging
  Version:    14.0.0
! Release:    4%{?dist}
  Summary:    OpenStack common messaging library
  
  License:    ASL 2.0
--- 17,23 ----
  
  Name:       python-oslo-messaging
  Version:    14.0.0
! Release:    5%{?dist}
  Summary:    OpenStack common messaging library
  
  License:    ASL 2.0
***************
*** 173,179 ****
  %license LICENSE
  %doc README.rst
  %{python3_sitelib}/oslo_messaging
! %{python3_sitelib}/*.egg-info
  %{_bindir}/oslo-messaging-send-notification
  %{_bindir}/oslo-messaging-send-notification-3
  %exclude %{python3_sitelib}/oslo_messaging/tests
--- 173,179 ----
  %license LICENSE
  %doc README.rst
  %{python3_sitelib}/oslo_messaging
! %{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info
  %{_bindir}/oslo-messaging-send-notification
  %{_bindir}/oslo-messaging-send-notification-3
  %exclude %{python3_sitelib}/oslo_messaging/tests
***************
*** 189,194 ****
--- 189,197 ----
  
  
  %changelog
+ * Wed Nov 16 2022 Hirotaka Wakabayashi hiwkby - 14.0.0-5
+ - Fixes issues on the packaging guidelines
+ 
  * Wed Nov 09 2022 Hirotaka Wakabayashi hiwkby - 14.0.0-4
  - Fixes issues on the packaging guidelines
  

```

Comment 7 Hirotaka Wakabayashi 2022-12-09 05:52:49 UTC
Hello, I fixed another issue.

Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec
SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-14.0.0-6.fc38.src.rpm
Koji(unsuccess...orz): https://koji.fedoraproject.org/koji/taskinfo?taskID=95115668

The reason for unsuccess is due to a dependent package is still unavailable but the package will be available soon. Please see: https://bugzilla.redhat.com/show_bug.cgi?id=1991145

```
*** python-oslo-messaging.spec.14.0.0-5 2022-12-09 05:44:25.988831648 +0000
--- python-oslo-messaging.spec  2022-12-09 05:45:20.223081852 +0000
***************
*** 17,23 ****

  Name:       python-oslo-messaging
  Version:    14.0.0
! Release:    5%{?dist}
  Summary:    OpenStack common messaging library

  License:    ASL 2.0
--- 17,23 ----

  Name:       python-oslo-messaging
  Version:    14.0.0
! Release:    6%{?dist}
  Summary:    OpenStack common messaging library

  License:    ASL 2.0
***************
*** 62,68 ****
  BuildRequires: python3-cachetools
  BuildRequires: python3-redis
  BuildRequires: python3-kafka
! 

  Requires:   python3-pbr
  Requires:   python3-amqp >= 2.5.2
--- 62,70 ----
  BuildRequires: python3-cachetools
  BuildRequires: python3-redis
  BuildRequires: python3-kafka
! BuildRequires: python3-testscenarios
! BuildRequires: python3-pifpaf
! BuildRequires: python3-confluent-kafka

  Requires:   python3-pbr
  Requires:   python3-amqp >= 2.5.2
***************
*** 189,210 ****


  %changelog
! * Wed Nov 16 2022 Hirotaka Wakabayashi hiwkby - 14.0.0-5
  - Fixes issues on the packaging guidelines

! * Wed Nov 09 2022 Hirotaka Wakabayashi hiwkby - 14.0.0-4
  - Fixes issues on the packaging guidelines

! * Tue Nov 08 2022 Hirotaka Wakabayashi hiwkby - 14.0.0-3
  - Fixes issues on the packaging guidelines

! * Tue Nov 01 2022 Hirotaka Wakabayashi hiwkby - 14.0.0-2
  - Fixes issues on the packaging guidelines

! * Wed Oct 26 2022 Hirotaka Wakabayashi hiwkby - 14.0.0-1
  - Update to 14.0.0

! * Thu Sep 30 2021 Hirotaka Wakabayashi hiwkby - 12.9.1-1
  - Un-retired and update to 12.9.1

  * Tue Feb 26 2019 Alfredo Moralejo <amoralej> - 8.1.2-1
--- 191,216 ----


  %changelog
! * Fri Dec 09 2022 Hirotaka Wakabayashi <hiwkby> - 14.0.0-6
! - Adds BuildRequires for tests
! - Fixes issues on the packaging guidelines
! 
! * Wed Nov 16 2022 Hirotaka Wakabayashi <hiwkby> - 14.0.0-5
  - Fixes issues on the packaging guidelines

! * Wed Nov 09 2022 Hirotaka Wakabayashi <hiwkby> - 14.0.0-4
  - Fixes issues on the packaging guidelines

! * Tue Nov 08 2022 Hirotaka Wakabayashi <hiwkby> - 14.0.0-3
  - Fixes issues on the packaging guidelines

! * Tue Nov 01 2022 Hirotaka Wakabayashi <hiwkby> - 14.0.0-2
  - Fixes issues on the packaging guidelines

! * Wed Oct 26 2022 Hirotaka Wakabayashi <hiwkby> - 14.0.0-1
  - Update to 14.0.0

! * Thu Sep 30 2021 Hirotaka Wakabayashi <hiwkby> - 12.9.1-1
  - Un-retired and update to 12.9.1

  * Tue Feb 26 2019 Alfredo Moralejo <amoralej> - 8.1.2-1
```

Thanks in advance,
Hirotaka

Comment 8 Hirotaka Wakabayashi 2022-12-14 00:30:33 UTC
> The reason for unsuccess is due to a dependent package is still unavailable but the package will be available soon. Please see: https://bugzilla.redhat.com/show_bug.cgi?id=1991145

Koji(success!)
https://koji.fedoraproject.org/koji/taskinfo?taskID=95330465

Comment 9 Package Review 2023-12-14 00:45:25 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 10 Jakub Kadlčík 2023-12-22 10:52:38 UTC
Hello Hirotaka,
I am really sorry, that I didn't reply. This somehow went under my radar.

The package looks good, and I'd give +1 but I have an issue when trying to build it in Copr. I am getting:

    No matching package to install: 'python3-pyngus'

Also, there is now 14.2.3 version but that can be updated after the package review.

Comment 11 Hirotaka Wakabayashi 2023-12-23 01:17:29 UTC
Hello Jakub, Thanks for the comment!! 

> No matching package to install: 'python3-pyngus'

OK, I will check the package status and update this package.

> Also, there is now 14.2.3 version but that can be updated after the package review.

Sure, I will update the version too.

Hirotaka

Comment 12 Hirotaka Wakabayashi 2024-03-02 04:00:58 UTC
Thanks for the updates. This bug is WIP. python3-pyngus, on which oslo.messaging depends, was retired half a year ago as a FTBFS/FTI bugs. So, I am working to unretire the pyngus package firstly.

Comment 13 Hirotaka Wakabayashi 2024-04-19 03:00:02 UTC
(In reply to Hirotaka Wakabayashi from comment #12)
> Thanks for the updates. This bug is WIP. python3-pyngus, on which
> oslo.messaging depends, was retired half a year ago as a FTBFS/FTI bugs. So,
> I am working to unretire the pyngus package firstly.

Hello, the unretirement of the pyngus package is completed and I uploaded the new spec file that updates the version to 14.7.0.

Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec
SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-14.7.0-1.fc41.src.rpmHere is the diff

Koji scratch build result(success)
https://koji.fedoraproject.org/koji/taskinfo?taskID=116584453

Here is the diff.
```
$ diff -c python-oslo-messaging.spec.1 python-oslo-messaging.spec
*** python-oslo-messaging.spec.1	Fri Dec  9 05:45:20 2022
--- python-oslo-messaging.spec	Fri Apr 19 02:41:43 2024
***************
*** 1,5 ****
  %{!?sources_gpg: %{!?dlrn:%global sources_gpg 1} }
! %global sources_gpg_sign 0xa63ea142678138d1bb15f2e303bdfd64dd164087
  
  %{!?upstream_version: %global upstream_version %{version}%{?milestone}}
  %global with_doc 1
--- 1,5 ----
  %{!?sources_gpg: %{!?dlrn:%global sources_gpg 1} }
! %global sources_gpg_sign 0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318
  
  %{!?upstream_version: %global upstream_version %{version}%{?milestone}}
  %global with_doc 1
***************
*** 16,23 ****
  %global pkg_name oslo-messaging
  
  Name:       python-oslo-messaging
! Version:    14.0.0
! Release:    6%{?dist}
  Summary:    OpenStack common messaging library
  
  License:    ASL 2.0
--- 16,23 ----
  %global pkg_name oslo-messaging
  
  Name:       python-oslo-messaging
! Version:    14.7.0
! Release:    1%{?dist}
  Summary:    OpenStack common messaging library
  
  License:    ASL 2.0
***************
*** 191,196 ****
--- 191,199 ----
  
  
  %changelog
+ * Fri Apr 19 2024 Hirotaka Wakabayashi <hiwkby> - 14.7.0-1
+ - Update to 14.7.0
+ 
  * Fri Dec 09 2022 Hirotaka Wakabayashi <hiwkby> - 14.0.0-6
  - Adds BuildRequires for tests
  - Fixes issues on the packaging guidelines
```

Koji scratch build result(success)
https://koji.fedoraproject.org/koji/taskinfo?taskID=116584453

Thanks in advance,
Hirotaka


Note You need to log in before you can comment on or make changes to this bug.