Spec URL: https://smani.fedorapeople.org/review/mingw-qt6-qtshadertools.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-qt6-qtshadertools-6.2.0-0.2.rc2.fc36.src.rpm Description: Qt6 for Windows - Qt Shader Tools component Fedora Account System Username: smani Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=76504658
Spec URL: https://smani.fedorapeople.org/review/mingw-qt6-qtshadertools.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-qt6-qtshadertools-6.2.0-1.fc36.src.rpm Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=76634512
Spec URL: https://smani.fedorapeople.org/review/mingw-qt6-qtshadertools.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-qt6-qtshadertools-6.2.2-1.fc36.src.rpm https://koji.fedoraproject.org/koji/taskinfo?taskID=80052118
Taking this review
Looks fine, LGTM -- but looks like the spec on the spec URL is missing mingw*-gcc-c++ but the one in the SRPM has that, make sure you use the right one when building Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: mingw32-qt6-qtshadertools : /usr/i686-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/6.2.2/QtShaderTools/private/qshaderbaker_p.h mingw32-qt6-qtshadertools : /usr/i686-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/6.2.2/QtShaderTools/private/qshaderbatchablerewriter_p.h mingw32-qt6-qtshadertools : /usr/i686-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/6.2.2/QtShaderTools/private/qspirvcompiler_p.h mingw32-qt6-qtshadertools : /usr/i686-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/6.2.2/QtShaderTools/private/qspirvshader_p.h mingw32-qt6-qtshadertools : /usr/i686-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/6.2.2/QtShaderTools/private/qspirvshaderremap_p.h mingw32-qt6-qtshadertools : /usr/i686-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/6.2.2/QtShaderTools/private/qtshadertoolsglobal_p.h mingw32-qt6-qtshadertools : /usr/i686-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/qtshadertoolsglobal.h mingw32-qt6-qtshadertools : /usr/i686-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/qtshadertoolsversion.h mingw64-qt6-qtshadertools : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/6.2.2/QtShaderTools/private/qshaderbaker_p.h mingw64-qt6-qtshadertools : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/6.2.2/QtShaderTools/private/qshaderbatchablerewriter_p.h mingw64-qt6-qtshadertools : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/6.2.2/QtShaderTools/private/qspirvcompiler_p.h mingw64-qt6-qtshadertools : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/6.2.2/QtShaderTools/private/qspirvshader_p.h mingw64-qt6-qtshadertools : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/6.2.2/QtShaderTools/private/qspirvshaderremap_p.h mingw64-qt6-qtshadertools : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/6.2.2/QtShaderTools/private/qtshadertoolsglobal_p.h mingw64-qt6-qtshadertools : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/qtshadertoolsglobal.h mingw64-qt6-qtshadertools : /usr/x86_64-w64-mingw32/sys- root/mingw/include/qt6/QtShaderTools/qtshadertoolsversion.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: mingw32-qt6-qtshadertools, mingw64-qt6-qtshadertools. Illegal package name: mingw32-qt6-qtshadertools, mingw64-qt6-qtshadertools. Does not provide -static: mingw32-qt6-qtshadertools, mingw64-qt6-qtshadertools. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 3", "*No copyright* [generated file]", "GNU General Public License v3.0 or later", "Khronos License", "*No copyright* Apache License 2.0", "Apache License 2.0", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License", "GNU Free Documentation License v1.3". 103 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/2009221-mingw- qt6-qtshadertools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package irrelevant for MinGW [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. there is an ExcludeArch but it's listed [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw32-qt6-qtshadertools , mingw64-qt6-qtshadertools [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- http://download.qt.io/official_releases/qt/6.2/6.2.2/submodules/qtshadertools-everywhere-src-6.2.2.tar.xz : CHECKSUM(SHA256) this package : f97505e72358c1fa2a2131c3a9a5b3497a2b9ea65b75a5beaf7f46c4b56a89e5 CHECKSUM(SHA256) upstream package : f97505e72358c1fa2a2131c3a9a5b3497a2b9ea65b75a5beaf7f46c4b56a89e5 Requires -------- mingw32-qt6-qtshadertools (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libgcc_s_dw2-1.dll) mingw32(libssp-0.dll) mingw32(libstdc++-6.dll) mingw32(msvcrt.dll) mingw32(qt6core.dll) mingw32(qt6gui.dll) mingw32-crt mingw32-filesystem qt6-qtshadertools-devel mingw64-qt6-qtshadertools (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libgcc_s_seh-1.dll) mingw64(libssp-0.dll) mingw64(libstdc++-6.dll) mingw64(msvcrt.dll) mingw64(qt6core.dll) mingw64(qt6gui.dll) mingw64-crt mingw64-filesystem qt6-qtshadertools-devel Provides -------- mingw32-qt6-qtshadertools: mingw32(qt6shadertools.dll) mingw32-qt6-qtshadertools mingw64-qt6-qtshadertools: mingw64(qt6shadertools.dll) mingw64-qt6-qtshadertools Diff spec file in url and in SRPM --------------------------------- --- /home/michel/src/fedora/reviews/2009221-mingw-qt6-qtshadertools/srpm/mingw-qt6-qtshadertools.spec 2021-12-15 15:32:54.565496028 -0800 +++ /home/michel/src/fedora/reviews/2009221-mingw-qt6-qtshadertools/srpm-unpacked/mingw-qt6-qtshadertools.spec 2021-12-14 12:15:53.000000000 -0800 @@ -39,8 +39,10 @@ BuildRequires: mingw32-filesystem >= 96 +BuildRequires: mingw32-gcc-c++ BuildRequires: mingw32-qt6-qtbase = %{version} BuildRequires: mingw32-vulkan-headers BuildRequires: mingw64-filesystem >= 96 +BuildRequires: mingw64-gcc-c++ BuildRequires: mingw64-qt6-qtbase = %{version} BuildRequires: mingw64-vulkan-headers Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2009221 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: C/C++, Perl, Java, Python, SugarActivity, PHP, R, Haskell, fonts, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Ack, thanks a lot!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-qt6-qtshadertools