Spec URL: https://smani.fedorapeople.org/review/mingw-qt6-qtwebsockets.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-qt6-qtwebsockets-6.2.0-0.2.rc2.fc36.src.rpm Description: Qt6 for Windows - QtWebSockets component Fedora Account System Username: smani Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=76505031
DEBUG util.py:444: Error: DEBUG util.py:444: Problem 1: cannot install the best candidate for the job DEBUG util.py:444: - nothing provides qt6-qtbase-devel = 6.2.0~rc2 needed by mingw32-qt6-qtbase-6.2.0-0.2.rc2.fc36.x86_64 DEBUG util.py:444: Problem 2: cannot install the best candidate for the job DEBUG util.py:444: - nothing provides qt6-qtdeclarative-devel = 6.2.0~rc2 needed by mingw32-qt6-qtdeclarative-6.2.0-0.3.rc2.fc36.noarch DEBUG util.py:444: Problem 3: cannot install the best candidate for the job DEBUG util.py:444: - nothing provides qt6-qtbase-devel = 6.2.0~rc2 needed by mingw64-qt6-qtbase-6.2.0-0.2.rc2.fc36.x86_64 DEBUG util.py:444: Problem 4: cannot install the best candidate for the job DEBUG util.py:444: - nothing provides qt6-qtdeclarative-devel = 6.2.0~rc2 needed by mingw64-qt6-qtdeclarative-6.2.0-0.3.rc2.fc36.noarch DEBUG util.py:446: (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)
Spec URL: https://smani.fedorapeople.org/review/mingw-qt6-qtwebsockets.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-qt6-qtwebsockets-6.2.0-1fc36.src.rpm %changelog * Sun Oct 03 2021 Sandro Mani <manisandro> - 6.2.0-1 - Update to 6.2.0 Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=76634394
Spec URL: https://smani.fedorapeople.org/review/mingw-qt6-qtwebsockets.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-qt6-qtwebsockets-6.2.0-1.fc36.src.rpm %changelog * Sun Oct 03 2021 Sandro Mani <manisandro> - 6.2.0-1 - Update to 6.2.0 Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=76634394
Ping?
Sorry for the delay; I meant to look over the MinGW guidelines and didn't have a chance. I only have two minor questions: - Why use %define instead of %global? - Can the Description mention bitness? It's not in the Summary or Description. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw32-qt6-qtwebsockets , mingw64-qt6-qtwebsockets [?]: Package functions as described. [-]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define release_version %(echo %{version} | awk -F. '{print $1"."$2}') [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mingw32-qt6-qtwebsockets-6.2.0-1.fc36.noarch.rpm mingw64-qt6-qtwebsockets-6.2.0-1.fc36.noarch.rpm mingw32-qt6-qtwebsockets-debuginfo-6.2.0-1.fc36.noarch.rpm mingw64-qt6-qtwebsockets-debuginfo-6.2.0-1.fc36.noarch.rpm mingw-qt6-qtwebsockets-6.2.0-1.fc36.src.rpm mingw32-qt6-qtwebsockets.noarch: W: no-documentation mingw64-qt6-qtwebsockets.noarch: W: no-documentation mingw32-qt6-qtwebsockets-debuginfo.noarch: W: only-non-binary-in-usr-lib mingw64-qt6-qtwebsockets-debuginfo.noarch: W: only-non-binary-in-usr-lib mingw-qt6-qtwebsockets.src:7: W: macro-in-comment %{commit} mingw-qt6-qtwebsockets.src: E: specfile-error warning: Macro expanded in comment on line 7: (c=%{commit}; echo ${c:0:7}) mingw-qt6-qtwebsockets.src: E: specfile-error warning: Macro expanded in comment on line 7: (c=%{commit}; echo ${c:0:7}) 5 packages and 0 specfiles checked; 2 errors, 5 warnings. Source checksums ---------------- http://download.qt.io/official_releases/qt/6.2/6.2.0/submodules/qtwebsockets-everywhere-src-6.2.0.tar.xz : CHECKSUM(SHA256) this package : 4278a1aa961f4b9c752db38ee3f5319b56f1033d0e6982eabbba6eaffb14c59f CHECKSUM(SHA256) upstream package : 4278a1aa961f4b9c752db38ee3f5319b56f1033d0e6982eabbba6eaffb14c59f Requires -------- mingw32-qt6-qtwebsockets (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libgcc_s_dw2-1.dll) mingw32(libstdc++-6.dll) mingw32(msvcrt.dll) mingw32(qt6core.dll) mingw32(qt6network.dll) mingw32-crt mingw32-filesystem mingw64-qt6-qtwebsockets (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libstdc++-6.dll) mingw64(msvcrt.dll) mingw64(qt6core.dll) mingw64(qt6network.dll) mingw64-crt mingw64-filesystem mingw32-qt6-qtwebsockets-debuginfo (rpmlib, GLIBC filtered): mingw64-qt6-qtwebsockets-debuginfo (rpmlib, GLIBC filtered): Provides -------- mingw32-qt6-qtwebsockets: mingw32(qt6websockets.dll) mingw32-qt6-qtwebsockets mingw64-qt6-qtwebsockets: mingw64(qt6websockets.dll) mingw64-qt6-qtwebsockets mingw32-qt6-qtwebsockets-debuginfo: mingw32-qt6-qtwebsockets-debuginfo mingw64-qt6-qtwebsockets-debuginfo: mingw64-qt6-qtwebsockets-debuginfo Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2009223 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: C/C++, R, Ocaml, Python, SugarActivity, Perl, Java, PHP, Haskell, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
%define is already dropped in 6.2.0-1, I'll update the descriptions in all mingw-qt6 packages.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-qt6-qtwebsockets
Thanks!