Bug 2009987 - Review Request: python-sphinx-sitemap - Sitemap generator for Sphinx
Summary: Review Request: python-sphinx-sitemap - Sitemap generator for Sphinx
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Sandro Mani
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-10-02 17:35 UTC by Jerry James
Modified: 2021-10-29 22:58 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-10-29 22:58:12 UTC
Type: ---
Embargoed:
manisandro: fedora-review+


Attachments (Terms of Use)

Description Jerry James 2021-10-02 17:35:53 UTC
Spec URL: https://jjames.fedorapeople.org/python-sphinx-sitemap/python-sphinx-sitemap.spec
SRPM URL: https://jjames.fedorapeople.org/python-sphinx-sitemap/python-sphinx-sitemap-2.2.0-1.fc36.src.rpm
Fedora Account System Username: jjames
Description: This package contains a Sphinx extension to generate multiversion and multilanguage sitemaps.org-compliant sitemaps for the HTML version of your Sphinx documentation.

Comment 1 Sandro Mani 2021-10-02 18:20:42 UTC
- Spec is sane
- License is correct
- Requires and provides are sane
- File ownership is okay
- No errors from rpmlint

Approved

At your option: suggested change to use %generate_buildrequires:

--- python-sphinx-sitemap.spec  2021-10-02 19:48:57.892462842 +0200
+++ python-sphinx-sitemap.spec.new      2021-10-02 20:17:54.463164873 +0200
@@ -12,11 +12,6 @@
 BuildArch:      noarch
 
 BuildRequires:  python3-devel
-BuildRequires:  %{py3_dist pip}
-BuildRequires:  %{py3_dist setuptools}
-BuildRequires:  %{py3_dist six}
-BuildRequires:  %{py3_dist sphinx}
-BuildRequires:  %{py3_dist wheel}
 
 %global _description %{expand:
 This package contains a Sphinx extension to generate multiversion and
@@ -30,6 +25,9 @@
 
 %description -n python3-%{srcname} %_description
 
+%generate_buildrequires
+%pyproject_buildrequires -r
+
 %prep
 %autosetup -n %{srcname}-%{version}

Comment 2 Jerry James 2021-10-03 16:20:38 UTC
(In reply to Sandro Mani from comment #1)
> At your option: suggested change to use %generate_buildrequires:

I have resisted using %generate_buildrequires because it ruins a common workflow of mine, where I use grep to look through spec files to figure out build-time dependencies.  I'll probably give in eventually, but not until I figure out a new workflow that is just as simple.

Thank you for the review!

Comment 3 Gwyn Ciesla 2021-10-04 13:36:10 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sphinx-sitemap

Comment 4 Fedora Update System 2021-10-04 17:12:12 UTC
FEDORA-2021-a2814f37b9 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a2814f37b9

Comment 5 Fedora Update System 2021-10-05 15:17:48 UTC
FEDORA-2021-a2814f37b9 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-a2814f37b9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a2814f37b9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2021-10-29 22:58:12 UTC
FEDORA-2021-a2814f37b9 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.