Spec URL: https://jackorp.fedorapeople.org/rpms/rubygem-cucumber-create-meta/rubygem-cucumber-create-meta.spec SRPM URL: https://jackorp.fedorapeople.org/rpms/rubygem-cucumber-create-meta/rubygem-cucumber-create-meta-6.0.1-1.fc36.src.rpm Description: Produce the meta message for Cucumber Ruby. Fedora Account System Username: jackorp copr build: https://copr.fedorainfracloud.org/coprs/pvalena/rubygems/build/2873572/
Full review below, issues: 1. Package must contain Requires: ruby(release) [1]. 2. Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gems/doc, /usr/share/gems => I think these should probably be owned by ruby itself? Filed as #2033820 => Approved, but please fix 1 when importing [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_ruby_compatibility Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains Requires: ruby(release). ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gems/doc, /usr/share/gems [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ruby: [x]: Platform dependent files must all go under %{gem_extdir_mri}, platform independent under %{gem_dir}. [x]: Gem package must not define a non-gem subpackage [x]: Macro %{gem_extdir} is deprecated. [x]: Gem package is named rubygem-%{gem_name} [x]: Package contains BuildRequires: rubygems-devel. [x]: Gem package must define %{gem_name} macro. [x]: Pure Ruby package must be built as noarch [x]: Package does not contain Requires: ruby(abi). ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [?]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Ruby: [x]: Gem package should exclude cached Gem. [x]: Gem should use %gem_install macro. [x]: gems should not require rubygems package [x]: Specfile should use macros from rubygem-devel package. [x]: Test suite should not be run by rake. [x]: Test suite of the library should be run. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://rubygems.org/gems/cucumber-create-meta-6.0.1.gem : CHECKSUM(SHA256) this package : d117510c4b0da92cb76550e78046f8a2e965f7bf552d634c49b80d9b004566c4 CHECKSUM(SHA256) upstream package : d117510c4b0da92cb76550e78046f8a2e965f7bf552d634c49b80d9b004566c4 Requires -------- rubygem-cucumber-create-meta (rpmlib, GLIBC filtered): (rubygem(cucumber-messages) >= 17.0 with rubygem(cucumber-messages) < 18 with rubygem(cucumber-messages) >= 17.0.1) (rubygem(sys-uname) >= 1.2 with rubygem(sys-uname) < 2 with rubygem(sys-uname) >= 1.2.2) ruby(rubygems) rubygem-cucumber-create-meta-doc (rpmlib, GLIBC filtered): rubygem-cucumber-create-meta Provides -------- rubygem-cucumber-create-meta: rubygem(cucumber-create-meta) rubygem-cucumber-create-meta rubygem-cucumber-create-meta-doc: rubygem-cucumber-create-meta-doc Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2010350 Buildroot used: fedora-rawhide-x86_64 Active plugins: Ruby, Shell-api, Generic Disabled plugins: fonts, Ocaml, Python, Haskell, Perl, PHP, Java, SugarActivity, R, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
> 1. Package must contain Requires: ruby(release) [1]. This does not apply to gems[1]. The automatically generated dependency on RubyGems is enough. > 2. Package must own all directories that it creates. Rubygems owns it and the require on rubygems is auto-generated [1]. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_rubygems Thanks!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-cucumber-create-meta
rubygem-cucumber-create-meta-6.0.1-1.fc36 This is done ^^, right?
*** Bug 2001679 has been marked as a duplicate of this bug. ***