Bug 2010608 - rpm2flatpak doesn't use custom build of a dependency
Summary: rpm2flatpak doesn't use custom build of a dependency
Alias: None
Product: Fedora Modules
Classification: Fedora
Component: flatpak-runtime
Version: unspecified
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 2010597
TreeView+ depends on / blocked
Reported: 2021-10-05 07:59 UTC by Milan Crha
Modified: 2021-10-13 20:43 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2021-10-13 20:43:56 UTC
Type: Bug

Attachments (Terms of Use)

Description Milan Crha 2021-10-05 07:59:16 UTC
The bug #2010597 uncovered a problem in the build of the 'evolution' package.

The evolution package in the flaptak requires a special build of the evolution-data-server, to have a specific D-Bus prefix used in the container. That's done by:

      macros: |
        %_eds_dbus_services_prefix org.gnome.Evolution

in the evolution.yaml [1]. The evolution-data-server knows of this variable [2].

I guess, and only guess, that the build re-used a plain build of the evolution-data-server, instead of the one required by the evolution. I do not have a clue where to verify it, I only know that these things work properly.

When I enter the container I see the included evolution-source-registry uses D-Bus name `org.gnome.evolution.dataserver.Sources5`, which is wrong, it should use `org.gnome.Evolution.org.gnome.evolution.dataserver.Sources5`. That's causing the trouble in the bug #2010597.

This used to work properly in the past. I've no idea when it broke.

[1] https://src.fedoraproject.org/flatpaks/evolution//blob/stable/f/evolution.yaml#_27
[2] https://src.fedoraproject.org/rpms/evolution-data-server/blob/f34/f/evolution-data-server.spec#_46

Comment 1 Kalev Lember 2021-10-05 11:14:32 UTC
Hm, if I look at the build logs, it looks like the flatpak container build has indeed picked up the evolution-data-server build from flatpak-common. I guess it's because the evolution-data-server build from flatpak-common happened to have a higher release number:

evolution-data-server-3.40.4-1.module_f34+12673+4f71ea37 (flatpak-common)
evolution-data-server-3.40.4-1.module_f34+12632+5ae7e8f8 (evolution)

A quick fix should be to just drop evolution-data-server from flatpak-common to work this around for now. I'm in the process of rebuilding all flatpaks to be based on F35 flatpak runtime and I can take care of this while doing the rebuilds.

Comment 2 Kalev Lember 2021-10-05 11:21:03 UTC

I'll update the ticket once the evolution build is done.

Comment 3 Milan Crha 2021-10-05 11:56:37 UTC
> A quick fix should be to just drop evolution-data-server from flatpak-common to work this around for now.

Won't that break the other apps, which expect it being available? I think of the GNOME Calendar and such, but I do not know how they build here.

Comment 4 Kalev Lember 2021-10-05 14:44:38 UTC
Yeah, we'll have to add it to the manifest for all the other apps that need it -- I'll take care of it.

Comment 5 Fedora Update System 2021-10-05 14:45:46 UTC
FEDORA-FLATPAK-2021-c6503004da has been submitted as an update to Fedora 35 Flatpaks. https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2021-c6503004da

Comment 6 Fedora Update System 2021-10-05 17:08:19 UTC
FEDORA-FLATPAK-2021-c6503004da has been pushed to the Fedora 35 Flatpaks testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2021-c6503004da

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2021-10-13 20:43:56 UTC
FEDORA-FLATPAK-2021-c6503004da has been pushed to the Fedora 35 Flatpaks stable repository.
If problem still persists, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.