Bug 2010660 - certain apps are shown among system repos
Summary: certain apps are shown among system repos
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-software
Version: 35
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Milan Crha
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: RejectedBlocker AcceptedFreezeException
Depends On:
Blocks: F35FinalFreezeException
TreeView+ depends on / blocked
 
Reported: 2021-10-05 10:01 UTC by Kamil Páral
Modified: 2021-10-11 22:28 UTC (History)
6 users (show)

Fixed In Version: gnome-software-41.0-5.fc35
Clone Of:
Environment:
Last Closed: 2021-10-11 22:28:52 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
screenshot of a spurious homebank repo (80.00 KB, image/png)
2021-10-05 10:01 UTC, Kamil Páral
no flags Details
The status quo after RPM installation and after every start of Software (112.95 KB, image/png)
2021-10-11 10:05 UTC, Lukas Ruzicka
no flags Details
Two installed Homebanks when Software allows for another installation (170.95 KB, image/png)
2021-10-11 10:06 UTC, Lukas Ruzicka
no flags Details


Links
System ID Private Priority Status Summary Last Updated
GNOME Gitlab GNOME gnome-software issues 1485 0 None None None 2021-10-05 14:07:54 UTC

Description Kamil Páral 2021-10-05 10:01:43 UTC
Created attachment 1829342 [details]
screenshot of a spurious homebank repo

Description of problem:
This is a hilarious bug. If you have certain apps installed, they show up in gnome-software listed as a system repository (see the screenshot). The repo can't be disabled, the toggle is insensitive. And the spurious repo is displayed if you show the repo dialog twice or more.

So far I identified HomeBank ('homebank' package) to trigger this. There are probably more apps to do this.

The repo dialog looks normal on its first display, but if you show it again during the gnome-software runtime [1], it exhibits the bug. Also if you make changes to configured repos, sometimes it also triggers this bug and the spurious repo appears in the top (even on the first display of the dialog).

[1] gnome-software is running all the time in the background, so even if you "close" gnome-software and reopen it later, or suspend the machine and resume it, etc, it still counts as the same runtime.

The spurious repo is only visible in gnome-software. "dnf repolist" or "pkcon repo-list" doesn't show it. So this really only seems to be a display problem in gnome-software.


Version-Release number of selected component (if applicable):
gnome-software-41.0-1.fc35.x86_64
PackageKit-1.2.4-2.fc35.x86_64
dnf-4.9.0-1.fc35.noarch


How reproducible:
always

Steps to Reproduce:
1. install a clean F35 Workstation
2. install HomeBank through gnome-software
3. in gnome-software, open Software Repositories. See that "HomeBank" repo is not there.
4. reopen Software Repositories. See that "HomeBank" repo is there, can't be operated.
5. close gnome-software, reopen gnome-software, open Software Repositories, see HomeBank still there
6. check "dnf repolist" and "pkcon repo-list", no homebank in there
7. reboot, relogin or "killall gnome-software"
8. in gnome-software, open Software Repositories, see that HomeBank repo is not present
9. switch the "Enable New Repositories" toggle (this seems to be the most reliable way to trigger the bug without dialog reopening)
10. see that HomeBank repo appears in the top

Expected results:
only actual repos show as repos, not individual applications

Comment 1 Kamil Páral 2021-10-05 10:08:12 UTC
I'm proposing this bug for a blocker discussion. It's not a severe bug in the sense that it would break something. As far as I could find out, it doesn't have any harmful effects. At the same time, it can be confusing to our users, and it can be argued that displaying system repos correctly is a basic expected functionality of a package manager. On the other hand, so far I only saw a single app causing this problem (HomeBank, doesn't mean there aren't more of them - probably something related to their metadata?), and the repo dialog needs to be interacted in a specific way (quite easy to trigger, though).

Comment 2 Milan Crha 2021-10-05 14:07:54 UTC
Thanks for a bug report. I can reproduce it when I install the RPM version of the HomeBank, but not when I install it from the Flathub remote.

I filled it upstream, as:
https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1485

Comment 3 Adam Williamson 2021-10-07 22:51:03 UTC
-5 blocker / +6 FE in https://pagure.io/fedora-qa/blocker-review/issue/498 , so marking appropriately.

Comment 4 Fedora Update System 2021-10-08 06:04:23 UTC
FEDORA-2021-979587cebf has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-979587cebf

Comment 5 Fedora Update System 2021-10-08 19:08:06 UTC
FEDORA-2021-979587cebf has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-979587cebf`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-979587cebf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2021-10-11 07:38:55 UTC
FEDORA-2021-979587cebf has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-979587cebf

Comment 7 Lukas Ruzicka 2021-10-11 10:04:08 UTC
The problem described in this bug is fixed by the gnome-software-41.0-5.fc35.x86_64 version. However, there seem to be some new problems introduced (see below). 

I have tested with the `homebank` package and realized that:

* when I install Homebank as an RPM, the installation finishes, but when I switched to installed applications, it shows that the installation is "In Progress" (screenshot), it suggests that application does not refresh the status after it has been confirmed installed. (inprogress.png).
* when restarting Software, the application is again listed as "In Progress", although it is installed and can be started. Restarting PackageKit does not help either.
* when I look for it using the search function, the application is offered for installation again, although already installed. 
* when I hit the Install button, the application is installed as Flatpak and then is correctly shown in Installed applications. On my system, there are two Homebanks. (two_homebanks.png)
* when I downgrade to the previous version (41.0-4), Homebank is correctly shown in Installed applications, even when installed from RPM.
* when I update to the latest version and the application was listed in Installed in the previous version, it is also listed in the latest version.

Comment 8 Lukas Ruzicka 2021-10-11 10:05:09 UTC
Created attachment 1831812 [details]
The status quo after RPM installation and after every start of Software

Comment 9 Lukas Ruzicka 2021-10-11 10:06:13 UTC
Created attachment 1831813 [details]
Two installed Homebanks when Software allows for another installation

Comment 10 Milan Crha 2021-10-11 10:41:22 UTC
> * when I look for it using the search function, the application is offered for installation again, although already installed. 

When you look at the top-right corner, there's a "Source:" shown, which tells you which version of the application you've selected.

Why that yours missed to change the state, or better why it failed to update the Updates page properly, I do not know. I'll check whether I can reproduce it here.

By the way, when you say you restarted the GNOME Software, was it by closing the window and open it again, or you killed the running process, please? The process is running in the background even when the window is closed (otherwise you won't have regular checks for update - or at least it's made like that currently).

Comment 11 Kamil Páral 2021-10-11 10:42:57 UTC
Hey Lukas, I suggest you file the problem from comment 7 separately. This particular bug (comment 0) seems fixed with gnome-software-41.0-5.fc35.

Comment 12 Milan Crha 2021-10-11 10:52:15 UTC
(In reply to Milan Crha from comment #10)
> Why that yours missed to change the state, or better why it failed to update
> the Updates page properly, I do not know. I'll check whether I can reproduce
> it here.

Okay, I can reproduce it too and it behaves truly strangely (I face also a variant of [1]).

I agree with Kamil, the best to open a new issue, ideally upstream:
https://gitlab.gnome.org/GNOME/gnome-software/-/issues/new

[1] https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1465

Comment 13 Kamil Páral 2021-10-11 11:22:43 UTC
(In reply to Lukas Ruzicka from comment #7)

I filed bug 2012817 which covers some parts of your comment (not all, though).

Comment 14 Fedora Update System 2021-10-11 17:16:32 UTC
FEDORA-2021-979587cebf has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-979587cebf`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-979587cebf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2021-10-11 22:28:52 UTC
FEDORA-2021-979587cebf has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.