Bug 2011176 - flathub repo can't be added through gnome-software
Summary: flathub repo can't be added through gnome-software
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-software
Version: 35
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Milan Crha
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedBlocker
Depends On:
Blocks: F35FinalBlocker
TreeView+ depends on / blocked
 
Reported: 2021-10-06 08:11 UTC by Kamil Páral
Modified: 2021-10-11 22:28 UTC (History)
6 users (show)

Fixed In Version: gnome-software-41.0-5.fc35
Clone Of:
Environment:
Last Closed: 2021-10-11 22:28:56 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
GNOME Gitlab GNOME gnome-software issues 1453 0 None None None 2021-10-06 08:45:21 UTC

Description Kamil Páral 2021-10-06 08:11:34 UTC
Description of problem:
On a clean F35 Workstation install (all defaults, 3rd party repos not enabled), Flathub repo can't be added through gnome-software. If you visit https://flatpak.org/setup/Fedora/ , click on "Flathub repository file" button, open it in gnome-software and click Install, it does nothing, and prints into journal:

Oct 06 10:06:32 fedora gnome-software[2143]: gs_plugin_app_install: assertion 'gs_app_get_kind (app) != AS_COMPONENT_KIND_REPOSITORY' failed
Oct 06 10:06:32 fedora gnome-software[2143]: flatpak did not set error for gs_plugin_app_install


Version-Release number of selected component (if applicable):
gnome-software-41.0-1.fc35.x86_64
flatpak-1.11.3-1.fc35.x86_64
Fedora-Workstation-Live-x86_64-35-20211005.n.0.iso

How reproducible:
always

Steps to Reproduce:
1. install a clean F35 Workstation
2. Visit https://flatpak.org/setup/Fedora/
3. Click on "Flathub repository file" button, open it in gnome-software 
4. Click Install, nothing happens

Additional info:
adding the repo through the command line works

Comment 1 Kamil Páral 2021-10-06 08:14:28 UTC
Proposing as a blocker for F35:
"All applications that can be launched using the standard graphical mechanism after a default installation of Fedora Workstation on the x86_64 architecture must start successfully and withstand a basic functionality test. "
https://fedoraproject.org/wiki/Fedora_35_Final_Release_Criteria#Default_application_functionality

Given the popularity of Flathub and how Fedora endorses it, adding its repo into the system seems like a basic functionality expected from gnome-software.

Comment 2 Milan Crha 2021-10-06 08:32:42 UTC
Thanks for a bug report. This had been fixed upstream for 41.1 [1].

[1] https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1453

Comment 3 Kamil Páral 2021-10-06 08:36:12 UTC
Milan, are you sure this is the same bug? I knew about the one you linked, but:
a) F35 Workstation doesn't have the filtered flathub repo enabled by default (I checked with `flatpak remotes` and it's not there)
b) the reporter says "There is no install button or obvious way to enable the repository". However, I do have an Install button there, it just does nothing.

Comment 4 Milan Crha 2021-10-06 08:45:22 UTC
Yes, it's a correct bug. The fix for it contains a series of patches [2], where the first [3] fixes this bug.

[2] https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/995/commits
[3] https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/995/diffs?commit_id=03ea59cc8db6bec34d56205d62ec495315e9ea96

Comment 5 Adam Williamson 2021-10-07 19:21:17 UTC
+5 in https://pagure.io/fedora-qa/blocker-review/issue/509 , marking accepted.

Comment 6 Adam Williamson 2021-10-07 23:34:40 UTC
Hi Milan! Do you think we could get an update with the fixes for this and https://bugzilla.redhat.com/show_bug.cgi?id=2010353 , by tomorrow if possible? It'd be really helpful to have as many blockers as possible knocked out before we get to the crunch time next week. Thanks!

Comment 7 Milan Crha 2021-10-08 05:11:20 UTC
(In reply to Adam Williamson from comment #6)
> Hi Milan! Do you think we could get an update with the fixes for this and
> https://bugzilla.redhat.com/show_bug.cgi?id=2010353

I'm on it. I did not notice an approval (like comment #5 here) at the bug #2010353, but I can include it as well, together with yesterday's https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/1035 .

Comment 8 Fedora Update System 2021-10-08 06:04:26 UTC
FEDORA-2021-979587cebf has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-979587cebf

Comment 9 Adam Williamson 2021-10-08 06:10:24 UTC
Milan: thanks! 2010353 was accepted as a blocker in comment 11.

Comment 10 Milan Crha 2021-10-08 06:34:42 UTC
(In reply to Adam Williamson from comment #9)
> 2010353 was accepted as a blocker in comment 11.

Err, my fault, I overlooked the bug #2010353 comment #11.

Comment 11 Lukas Ruzicka 2021-10-08 10:32:06 UTC
I can confirm that the update mentioned in comment #8 fixes this issue and now the Flathub repository can be added using the provided package via Gnome Software.

Comment 12 Fedora Update System 2021-10-08 19:08:08 UTC
FEDORA-2021-979587cebf has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-979587cebf`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-979587cebf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2021-10-11 07:38:57 UTC
FEDORA-2021-979587cebf has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-979587cebf

Comment 14 Kamil Páral 2021-10-11 10:35:13 UTC
Verified fixed with gnome-software-41.0-5.fc35

Comment 15 Fedora Update System 2021-10-11 17:16:34 UTC
FEDORA-2021-979587cebf has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-979587cebf`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-979587cebf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2021-10-11 22:28:56 UTC
FEDORA-2021-979587cebf has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.