Bug 2011274 - flathub filtered repo seems missing from F35 install
Summary: flathub filtered repo seems missing from F35 install
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Changes Tracking
Version: 35
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ben Cotton
QA Contact:
URL:
Whiteboard: https://ask.fedoraproject.org/t/we-ar...
Depends On:
Blocks: 1982741
TreeView+ depends on / blocked
 
Reported: 2021-10-06 10:23 UTC by Kamil Páral
Modified: 2021-12-03 01:10 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug


Attachments (Terms of Use)

Description Kamil Páral 2021-10-06 10:23:26 UTC
Description of problem:
I did a clean F35 Workstation install from Fedora-Workstation-Live-x86_64-35-20211005.n.0.iso. Regardless of whether I enable or not enable third party repos in the initial setup, I don't see flathub filtered repo [1] anywhere. 

$ flatpak remotes
Name   Options
fedora system,oci

In gnome-software, there are 4 repositories listed under "Fedora Third Party Repositories", but flathub filtered repo is not one of them. Under "Applications (Flatpak)" section it is not listed either.

So overall it seems disabled by default (even if I enable third party repos in initial setup/gnome-software) and I can't even find a place to enable it.

Note: I know that bug 1982741 comment 3 speaks about:
$ sudo fedora-third-party enable
but I don't think all users are expected to find out about it and run it manually.

Has the Change [1] failed to deliver this in F35? It doesn't state any status.

[1] https://fedoraproject.org/wiki/Changes/Filtered_Flathub_Applications

Version-Release number of selected component (if applicable):
fedora-flathub-remote-1-1.fc35.noarch
fedora-third-party-0.6-1.fc35.noarch
fedora-workstation-repositories-35-1.fc35.noarch
gnome-initial-setup-41.0-1.fc35.x86_64
gnome-software-41.0-1.fc35.x86_64

How reproducible:
always

Steps to Reproduce:
1. install clean F35 and try to find the flathub filtered repo anywhere

Comment 1 Owen Taylor 2021-10-06 14:03:25 UTC
OK, there are two separate things going on here:

 A) With the selinux problems in bug 2001837, opting-in through gnome-initial-setup leaves things in an inconsistent state - fedora-third-party thinks that the user has opted in, but the repositories are not actually enabled. Since fedora-third-party thinks that a user has made a selection, no info-bar is shown when gnome-software runs, and there is no option to opt-in again.

 B) There is problem with the GNOME Software repositories dialog design. The way we decided to do it is that the switch for third-party repositories only affects *future* third-party repositories that have not yet been added to the system - and is labelled that way. With the idea that the user who wants to opt-in later can toggle the switch then turn on the individual repositories. But we only create third-party Flatpak repositories when the user opts-in, so if the user has opted out intiially (or hit the bug in A), they don't see the Flathub repository *at all*, and have no way to create it.

Fixing B) is probably going to require switching Flatpak repositories to the enable/disable model, which is not a F35 change at this point - the most obvious fix would be require a Flatpak change to allow files in /etc/flatpaks/remotes.d to create *disabled* repositories.

So, given fix for problem A, here's a stab at some text for CommonBugs:

 When you install Fedora 35 or update to Fedora 35, if you don't opt-in to Fedora Third-party repositories initially, you are supposed to be able to opt-in through the GNOME Software repositories dialog later. However, the "Fedora Flathub Selection" third-party repository will not be visible there, so cannot be enabled. As a workaround, from the command line, run:

  sudo fedora-third-party disable
  sudo fedora-third-party enable

This will result in *all* third-party repositories being created and enabled. You can disable any repositories you don't want through the GNOME Software repositories dialog.

Comment 2 Milan Crha 2021-10-06 14:58:17 UTC
(In reply to Owen Taylor from comment #1)
>  B) There is problem with the GNOME Software repositories dialog design. The
> way we decided to do it is that the switch for third-party repositories only
> affects *future* third-party repositories that have not yet been added to
> the system - and is labelled that way.

I think it can be handled by the upstream, though it needs a design input.

Allan, could you make it upstream, please?

What I'd think of is to hide respective third party repositories in the dialog when the fedora-third-party reports "disabled" state. There would need to be a new switch for it, probably replacing the current one (that you described, for the future repos). The `--config-only` makes it even more complicated.

Comment 3 Kamil Páral 2021-10-06 14:59:39 UTC
Thanks for the CommonBugs draft, Owen. Adding a tag.


Note You need to log in before you can comment on or make changes to this bug.