Bug 2011327

Upstream commit:

0953e1ae cli: introduce --resource fibrechannel.appid option

Try to verify the bug with Package:
4.18.0-353.el8.x86_64
virt-manager-3.2.0-1.el8.noarch
virt-install-3.2.0-1.el8.noarch
libvirt-7.9.0-1.module+el8.6.0+13150+28339563.x86_64

Step 1. check the rng file
# cat /usr/share/libvirt/schemas/domaincommon.rng | grep fibrechannel -a10
>>
...
  <define name="fibrechannel">
    <element name="fibrechannel">
      <attribute name="appid">
        <data type="string">
          <!-- All printable characters -->
          <param name="pattern">[&#x20;-&#x7E;]{1,128}</param>
        </data>
      </attribute>
    </element>
  </define>
...
  </define>

  <define name="respartition">
    <element name="resource">
      <optional>
        <element name="partition">
          <ref name="absFilePath"/>
        </element>
      </optional>
      <optional>
        <ref name="fibrechannel"/>
      </optional>
    </element>
  </define>
...

Step 2. Create a vm by using --resource fibrechannel.appid=just_an_app_id parameter
#virt-install \
 --name t1 --memory 4096 \
 --disk path=/home/t2.img,size=10 \
 --location
http://download.eng.pek2.redhat.com/rhel-9/nightly/RHEL-9-Beta/latest-RHEL-9.0/compose/BaseOS/x86_64/os/ \
 --resource fibrechannel.appid=just_an_app_id
>>
Starting install...
Retrieving file vmlinuz...                                                                                                 |  10 MB  00:00:00     
Retrieving file initrd.img...                                                                                              |  76 MB  00:00:00     
Allocating 't2.img'                                                                                                        |  10 GB  00:00:00     
Removing disk 't2.img'                                                                                                     |    0 B  00:00:00     
ERROR    Unable to write '879:just_an_app_id' to '/sys/class/fc/fc_udev_device/appid_store': Invalid argument
Domain installation does not appear to have been successful.
If it was, you can restart your domain by running:
  virsh --connect qemu:///system start t1
otherwise, please restart your installation.

Test result: vm created failed because kernel has not support this feature

Step 3. Check privilege for /sys/class/fc/fc_udev_device/appid_store
# ls -l /sys/class/fc/fc_udev_device/appid_store
--w-------. 1 root root 4096 Dec  1 01:38 /sys/class/fc/fc_udev_device/appid_store

Comment: this step is make sure user has write permission for this file

Summary: RHEL8.6 have not support /sys/class/fc/fc_udev_device/appid_store yet. 


@jjongsma : Do we need more test for this bug or this is enough? I think we can just do a simple negative test before this feature released.

It seems that the virt-install portion is working correctly and passing the fibrechannel appid to libvirt/qemu. I'm not entirely sure what additional testing might be necessary here. What do you mean by "simple negative test"? 

Pavel, What testing did you do when developing this feature upstream?

By "simple negative test" I was meaning set up an environment that do not support FibreChannel VMID and see if we can get a clear error message.

Confirmed with Pavel offline, there will be no more test actions until this feature is available on RHEL8.6, comment 5 is enough for verifying this bug. So, I move it to VERIFIED status, thanks.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virt-manager bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:1862