Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2011328

Summary: Add support for FibreChannel VMID
Product: Red Hat Enterprise Linux 9 Reporter: Pavel Hrdina <phrdina>
Component: virt-managerAssignee: Virtualization Maintenance <virt-maint>
virt-manager sub component: Common QA Contact: Hongzhou Liu <hongzliu>
Status: CLOSED ERRATA Docs Contact:
Severity: unspecified    
Priority: unspecified CC: chhu, hongzliu, jjongsma, jsuchane, juzhou, mxie, tyan, tzheng, virt-maint, xiaodwan
Version: 9.0Keywords: FutureFeature, Triaged
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: virt-manager-3.2.0-10.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-17 13:28:11 UTC Type: Feature Request
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2000861    
Bug Blocks:    

Description Pavel Hrdina 2021-10-06 12:43:13 UTC 
Description of problem:

The FC SAN can provide various QOS levels, access control depending on the VMID. Also it can collect telemetry data at per-VM level which can be used to enhance the IO performance of the VM. To execute these, the FC SAN needs a mechanism to identify the VMID from where the frame originated. So, embedded the VMID in every FC frame would be of great use.
Comment 1 Pavel Hrdina 2021-10-06 12:48:04 UTC 
Upstream commit:

0953e1ae cli: introduce --resource fibrechannel.appid option
Comment 2 Hongzhou Liu 2021-11-18 03:39:39 UTC 
Try to do pre-verification for bug with the latest package:
virt-install-3.2.0-10.el9.noarch
virt-manager-3.2.0-10.el9.noarch
libvirt-7.9.0-1.el9.x86_64

Steps:
1. Check the rng file.

# cat /usr/share/libvirt/schemas/domaincommon.rng | grep fibrechannel -a10
            </choice>
          </attribute>
          <attribute name="enabled">
            <ref name="virYesNo"/>
          </attribute>
        </element>
      </oneOrMore>
    </element>
  </define>

  <define name="fibrechannel">
    <element name="fibrechannel">
      <attribute name="appid">
        <data type="string">
          <!-- All printable characters -->
          <param name="pattern">[&#x20;-&#x7E;]{1,128}</param>
        </data>
      </attribute>
    </element>
  </define>

  <!--
--
  </define>

  <define name="respartition">
    <element name="resource">
      <optional>
        <element name="partition">
          <ref name="absFilePath"/>
        </element>
      </optional>
      <optional>
        <ref name="fibrechannel"/>
      </optional>
    </element>
  </define>

2. Create a vm by using virt-install command with "--resource fibrechannel.appid=just_an_app_id" parameter

# virt-install --name  t1 --memory 2048 --disk path=/home/t2.img,size=5 --location http://download.eng.pek2.redhat.com/rhel-9/nightly/RHEL-9-Beta/latest-RHEL-9.0/compose/BaseOS/x86_64/os/ --resource fibrechannel.appid=just_an_app_id

Test result - virt-install command runs successfully and vm can be installed without error.

3. Check the xml related "--resource fibrechannel.appid=just_an_app_id" generated correctly.
# virsh dumpxml t1 | grep fibrechannel
...
  <resource>
    <partition>/machine</partition>
    <fibrechannel appid='13'/>
  </resource>
...  
 
So I add Verified:Tested to this bug, thanks.
Comment 4 Hongzhou Liu 2022-01-04 06:25:07 UTC 
Verified this bug on rhel9.0

packages:
virt-install-3.2.0-11.el9.noarch
virt-manager-3.2.0-11.el9.noarch
qemu-kvm-6.2.0-1.el9.x86_64

Steps
1. Check the rng file.

# cat /usr/share/libvirt/schemas/domaincommon.rng | grep fibrechannel -a10
           </element>
      </oneOrMore>
    </element>
  </define>

  <define name="fibrechannel">
    <element name="fibrechannel">
      <attribute name="appid">
        <data type="string">
          <!-- All printable characters -->
          <param name="pattern">[&#x20;-&#x7E;]{1,128}</param>
        </data>
--
        <element name="partition">
          <ref name="absFilePath"/>
        </element>
      </optional>
      <optional>
        <ref name="fibrechannel"/>
      </optional>
    </element>
  </define>

  <define name="clock">

2. Create a vm by using virt-install command with "--resource fibrechannel.appid=just_an_app_id" parameter

# virt-install 
--name  t1 \
--memory 2048 \
--disk path=/home/t2.img,size=50 \
--location http://download.eng.pek2.redhat.com/rhel-9/nightly/RHEL-9-Beta/latest-RHEL-9.0/compose/BaseOS/x86_64/os/ \
--resource fibrechannel.appid=just_an_app_id

the vm can be installed successfully

3. Check the xml for vm
<resource>
    <fibrechannel appid='just_an_app_id'/>
</resource>

Based on this result, I change the status to VERIFIED, Thanks.
Comment 6 errata-xmlrpc 2022-05-17 13:28:11 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: virt-manager), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2515