Spec URL: http://www.devin.com.br/eitch/fextras/SPECS/tuxpuck.spec SRPM URL: http://www.devin.com.br/eitch/fextras/SRPMS/tuxpuck-0.8.2-1.src.rpm Description: TuxPuck is a shufflepuck game written in C using SDL. The player moves a pad around a board and tries to shoot down the puck through the opponents defense. Easy to play, difficult to win.
SPEC looks clear, but mock build fails. You have to add BuildRequires: desktop-file-install
GOOD ==== * rpmlint output clean * Package and spec file named appropriately * Spec file legible and in Am. English * GPL license ok, license file included * Source matches upstream: fc839abc2b1f3eafae397e1ed6487079 tuxpuck-0.8.2.tar.gz * Builds in mock on FC4, FC5, and FC6 for both i386 and x86_64 * Not relocatable * No locales * No shared libs * RPM_BUILD_ROOT cleaned where necessary * macro usage consistent * .desktop file installed correctly * no -devel package needed * no need for -doc subpackage * Does not own directories that it should not. * Package runs, but won't let me win. ;) MUSTFIX ======= * Remove the comment about 'doesn't build with optflags', since you are building it with %optflags * Add BR: desktop-file-utils, as mentioned in comment #1
Thanks for the review guys. Package updated with fixes from Comment #1 and Comment #2: Spec URL: http://www.devin.com.br/eitch/fextras/SPECS/tuxpuck.spec SRPM URL: http://www.devin.com.br/eitch/fextras/SRPMS/tuxpuck-0.8.2-1.src.rpm
MUSTFIX items fixed. Please remember to bump the Release number and update the %changelog entries during the review. It makes it easier for the reviewers to track what's changed. APPROVED
I usually only bump the release number when in the reviews, the update to the specfile is major and significant :) Thanks for the review.
Imported and built. Thanks! Closing now.
Change owner to limb (orphaned)