Bug 201153 - Review Request: tuxpuck - 3D Shufflepuck Pong Game
Review Request: tuxpuck - 3D Shufflepuck Pong Game
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Wart
Fedora Package Reviews List
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2006-08-03 04:41 EDT by Hugo Cisneiros
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-08-07 09:17:33 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
wtogami: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Hugo Cisneiros 2006-08-03 04:41:45 EDT
Spec URL: http://www.devin.com.br/eitch/fextras/SPECS/tuxpuck.spec
SRPM URL: http://www.devin.com.br/eitch/fextras/SRPMS/tuxpuck-0.8.2-1.src.rpm
Description: 

TuxPuck is a shufflepuck game written in C using SDL. The player moves a pad
around a board and tries to shoot down the puck through the opponents defense.
Easy to play, difficult to win.
Comment 1 Michał Bentkowski 2006-08-03 06:39:18 EDT
SPEC looks clear, but mock build fails. You have to add BuildRequires:
desktop-file-install
Comment 2 Wart 2006-08-04 16:39:28 EDT
GOOD
====
* rpmlint output clean
* Package and spec file named appropriately
* Spec file legible and in Am. English
* GPL license ok, license file included
* Source matches upstream:
  fc839abc2b1f3eafae397e1ed6487079  tuxpuck-0.8.2.tar.gz
* Builds in mock on FC4, FC5, and FC6 for both i386 and x86_64
* Not relocatable
* No locales
* No shared libs
* RPM_BUILD_ROOT cleaned where necessary
* macro usage consistent
* .desktop file installed correctly
* no -devel package needed
* no need for -doc subpackage
* Does not own directories that it should not.
* Package runs, but won't let me win.  ;)


MUSTFIX
=======
* Remove the comment about 'doesn't build with optflags', since you are
  building it with %optflags

* Add BR: desktop-file-utils, as mentioned in comment #1
Comment 3 Hugo Cisneiros 2006-08-06 16:16:06 EDT
Thanks for the review guys. Package updated with fixes from Comment #1 and 
Comment #2:

Spec URL: http://www.devin.com.br/eitch/fextras/SPECS/tuxpuck.spec
SRPM URL: http://www.devin.com.br/eitch/fextras/SRPMS/tuxpuck-0.8.2-1.src.rpm
Comment 4 Wart 2006-08-07 01:39:37 EDT
MUSTFIX items fixed.  Please remember to bump the Release number and update the
%changelog entries during the review.  It makes it easier for the reviewers to
track what's changed.

APPROVED
Comment 5 Hugo Cisneiros 2006-08-07 06:46:42 EDT
I usually only bump the release number when in the reviews, the update to the 
specfile is major and significant :) Thanks for the review.
Comment 6 Hugo Cisneiros 2006-08-07 09:17:33 EDT
Imported and built. Thanks! Closing now.
Comment 7 Jon Ciesla 2007-02-26 15:26:22 EST
Change owner to limb@jcomserv.net (orphaned)

Note You need to log in before you can comment on or make changes to this bug.