RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2011602 - logger from util-linux incorrectly handles long messages
Summary: logger from util-linux incorrectly handles long messages
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: util-linux
Version: 8.4
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: Karel Zak
QA Contact: Vojtech Eichler
URL:
Whiteboard:
Depends On:
Blocks: 2033622
TreeView+ depends on / blocked
 
Reported: 2021-10-06 20:43 UTC by Paulo Andrade
Modified: 2022-05-10 16:55 UTC (History)
1 user (show)

Fixed In Version: util-linux-2.32.1-29.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2033622 (view as bug list)
Environment:
Last Closed: 2022-05-10 15:30:52 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-99091 0 None None None 2021-10-06 20:47:05 UTC
Red Hat Product Errata RHBA-2022:2100 0 None None None 2022-05-10 15:31:05 UTC

Internal Links: 2033622

Description Paulo Andrade 2021-10-06 20:43:35 UTC
In

https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/misc-utils/logger.c?h=stable%2Fv2.32#n963

we see:

	size_t max_usrmsg_size = ctl->max_message_size - strlen(ctl->hdr);
	char *const buf = xmalloc(max_usrmsg_size + 2 + 2);

since ctl->max_message_size defaults to 1024, unless the -S option is used,
a very long message will result in a very large unsigned value, causing
the malloc call to fail.

User suggests pseudo patch:

-	size_t max_usrmsg_size = ctl->max_message_size - strlen(ctl->hdr);
+	size_t usrmsg_size = strlen(ctl->hdr);
+	size_t max_usrmsg_size = (ctl->max_message_size < usrmgr_size) ? usrmgr_size : ctl->max_message_size);

  Need a careful review of the code, as a few lines below there is also:

				max_usrmsg_size =
				    ctl->max_message_size - strlen(ctl->hdr);

what again might write out of bounds due to negative value as unsigned.

Comment 2 Karel Zak 2021-10-21 16:55:07 UTC
Please, ignore the previous comment. I have reverted the patch. The proper bugfix is: https://github.com/karelzak/util-linux/commit/58e4ee082bca100034791a4a74481f263bb30a25

Comment 3 Paulo Andrade 2021-11-04 12:40:20 UTC
Just in case the above link appears broken... https://github.com/util-linux/util-linux/commit/58e4ee082bca100034791a4a74481f263bb30a25

Comment 9 errata-xmlrpc 2022-05-10 15:30:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (util-linux bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2100


Note You need to log in before you can comment on or make changes to this bug.