Spec URL: https://www.bachelot.org/fedora/SPECS/perl-Archive-Zip-SimpleZip.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-Archive-Zip-SimpleZip-0.040-1.fc35.src.rpm Description: Archive::Zip::SimpleZip is a module that allows the creation of Zip archives. For reading Zip archives, there is a companion module, called Archive::Zip::SimpleUnzip, that can read Zip archives. Fedora Account System Username: xavierb
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok BuildRequires FIX: Please add build-requires: coreutils - spec file: line 78 make - spec file: line 69,73,82 perl-interpreter - spec file: line 55,68 perl(Compress::Raw::Zlib) - t/111const-deflate.t:30 perl(Cwd) - t/010main-unzip.t:18 perl(Encode) - t/001main.t:30 perl(File::Copy) - private/MakeUtil.pm:7 perl(POSIX) - t/001main.t:109 perl(Test::More) - t/meta-json.t:7 TODO: Please add BR perl(Test::NoWarnings) which is optional for tests TODO: Please consider using macro for version of IO::Compress* and IO::Uncompress* modules. If you don't add the package to EPEL 7, please consider fixing these 'TODO' items: TODO: Add "NO_PACKLIST=1 NO_PERLLOCAL=1" to 'perl Makefile.PL' If you use option NO_PACKLIST=1, please add version constrain to ExtUtils::MakeMaker >= 6.76 Remove 'find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;'. TODO: Use %{make_install} instead of "make pure_install". TODO: Remove the deleting empty directories in %install section. If you add it to EPEL 7, please do: TODO: Replace PERL_INSTALL_ROOT with more common DESTDIR. FIX: Add following build-requires 'findutils' used in spec file. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. FIX: Build failed due to missing BR 'make'. + /usr/bin/make -j8 V=1 VERBOSE=1 /var/tmp/rpm-tmp.MIdw0C: line 33: /usr/bin/make: No such file or directory I will check binary provides and requires after successful build. Resolution: Not Approved
Thanks for the review. I believe to have addressed all the issues you outlined. Spec URL: https://www.bachelot.org/fedora/SPECS/perl-Archive-Zip-SimpleZip.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-Archive-Zip-SimpleZip-0.040-2.fc36.src.rpm
> BuildRequires > FIX: Please add build-requires: > coreutils - spec file: line 78 > make - spec file: line 69,73,82 > perl-interpreter - spec file: line 55,68 > perl(Compress::Raw::Zlib) - t/111const-deflate.t:30 > perl(Cwd) - t/010main-unzip.t:18 > perl(Encode) - t/001main.t:30 > perl(File::Copy) - private/MakeUtil.pm:7 > perl(POSIX) - t/001main.t:109 > perl(Test::More) - t/meta-json.t:7 Done. > TODO: Please add BR perl(Test::NoWarnings) which is optional for tests Done. > TODO: Please consider using macro for version of IO::Compress* and > IO::Uncompress* modules. Done. > If you don't add the package to EPEL 7, please consider fixing > these 'TODO' items: > TODO: Add "NO_PACKLIST=1 NO_PERLLOCAL=1" to 'perl Makefile.PL' > If you use option NO_PACKLIST=1, please add version constrain > to ExtUtils::MakeMaker >= 6.76 > Remove 'find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} > \;'. > TODO: Use %{make_install} instead of "make pure_install". > TODO: Remove the deleting empty directories in %install section. All done. $ rpm -qp --requires perl-Archive-Zip-SimpleZip-0.040-2.fc36.noarch.rpm | grep -v rpmlib | sort | uniq -c 1 perl(bytes) 1 perl(Carp) 1 perl(Config) 1 perl(constant) 1 perl(Exporter) 1 perl(Fcntl) 1 perl(File::Basename) 1 perl(File::Path) 1 perl(File::Spec) 1 perl(IO::Compress::Adapter::Deflate) >= 2.096 1 perl(IO::Compress::Base) >= 2.096 1 perl(IO::Compress::Base::Common) >= 2.096 1 perl(IO::Compress::Bzip2) >= 2.096 1 perl(IO::Compress::Lzma) >= 2.096 1 perl(IO::Compress::RawDeflate) >= 2.096 1 perl(IO::Compress::Xz) >= 2.096 1 perl(IO::Compress::Zip) >= 2.096 1 perl(IO::Compress::Zip::Constants) >= 2.096 1 perl(IO::Compress::Zstd) >= 2.096 1 perl(IO::File) 1 perl(IO::Uncompress::Base) >= 2.096 1 perl(IO::Uncompress::Bunzip2) >= 2.096 1 perl(IO::Uncompress::RawInflate) >= 2.096 1 perl(IO::Uncompress::UnLzma) >= 2.096 1 perl(IO::Uncompress::UnXz) >= 2.096 1 perl(IO::Uncompress::Unzip) >= 2.096 1 perl(IO::Uncompress::UnZstd) >= 2.096 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(Perl::OSType) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(:VERSION) >= 5.6.0 1 perl(warnings) Binary requires are ok. $ rpm -qp --provides perl-Archive-Zip-SimpleZip-0.040-2.fc36.noarch.rpm | sort | uniq -c 1 perl(Archive::Zip::SimpleUnzip) = 0.040 1 perl(Archive::Zip::SimpleUnzip::Handle) 1 perl(Archive::Zip::SimpleUnzip::Member) 1 perl(Archive::Zip::SimpleZip) = 0.040 1 perl-Archive-Zip-SimpleZip = 0.040-2.fc36 1 perl(Archive::Zip::SimpleZip::Handle) 1 perl(Archive::Zip::StreamedUnzip) = 0.040 1 perl(Archive::Zip::StreamedUnzip::Handle) 1 perl(Archive::Zip::StreamedUnzip::Member) Binary provides are ok. The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Archive-Zip-SimpleZip
FEDORA-2021-d38d4f7c04 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-d38d4f7c04
FEDORA-2021-23818d4355 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-23818d4355 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-23818d4355 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-d38d4f7c04 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-d38d4f7c04 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-d38d4f7c04 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2021-64ba45d661 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-64ba45d661 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-23818d4355 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-d38d4f7c04 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2021-64ba45d661 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report.